Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Developers Meeting on Thurs, Sep 19, 2024
Time/Location
from 14:00-15:00 UTC
Location: https://lyrasis.zoom.us/my/dspace?pwd=RTk4QUhISnhPRi9YenVrTFJKbDllQT09 (Meeting ID: 502 527 3040). Passcode: dspace
- More connection options available at DSpace Meeting Room
Agenda
- Discussion Topics - If you have a topic you'd like to have added to the agenda, please just add it.
- Next week: 2024 DSpace North American User Group Meeting. There will be a Developers meeting on Thurs, Sept 26 (as Tim will be back by then).
- DSpace 9.0 release (tentative April 2025)
- 9.0 Board is created: https://github.com/orgs/DSpace/projects/31/
- Early ideas/brainstorms captured at DSpace Release 9.0 Status
- Ongoing Discussions:
- Incentivizing Code Reviews and PR Testing
- High CPU with DSpace 7 SSR: https://github.com/DSpace/dspace-angular/issues/3110
- Using both public/private REST API URLs for better performance: https://github.com/DSpace/dspace-angular/issues/1485 (Assigned to 4Science)
- Simplifying the Installation Process: https://github.com/DSpace/dspace-angular/issues/3184
- Group Review of https://github.com/DSpace/dspace-angular/pull/2317 (from alanorth)
- Other topics
- feedback needed on https://github.com/DSpace/dspace-angular/pull/3199
- feedback needed on https://github.com/DSpace/dspace-angular/issues/1271#issuecomment-2358860597
- Board Review:
- 9.0 Project Board - Review PRs collaboratively or Assign new PRs to volunteers to code review and/or test.
- Backlog Board - Are there any tickets here stuck in the "Triage" column? We'd like to keep this column as small as possible.
- 8.x and 7.6.x Maintenance Board - Known bugs can be found here, along with any backported bug fixes.
- Upcoming Topics: (Let us know if there are topics you want to discuss in future weeks)
- DSpace accepts external identifiers (DOIs and such) from submitters, and manages others (DOIs again, Handles) itself. Should these be stored in separate metadata fields? what fields? what schema? Various bits of DSpace have disagreed on the answers. See also https://github.com/DSpace/DSpace/pull/1006.
- Discussion/proposal around refactoring and simplifying Live Import and External Data frameworks: https://github.com/DSpace/DSpace/issues/9758
(nothing concrete yet but would be great to get thoughts added to this issue and maybe find some collaborators)
Attendees
- Tim Donohue
- Holger Lenz
- Giuseppe Digilio (4Science)
- Paulo Graça
- Mark H. Wood
- Grazia Quercia (4Science)
- Corrado Lombardi (4Science)
- Julian Timal (eScire)
- Martin Walk
- Melissa Anez
- Oliver Goldschmidt
- Hrafn Malmquist
- Pascal-Nicolas Becker
- Pierre Lasou
- Kim Shepherd
- Nicholas Woodward
Current Work
Project Boards
- DSpace 9.0 board: https://github.com/orgs/DSpace/projects/31
- DSpace 8.x and 7.6.x board: https://github.com/orgs/DSpace/projects/29
To quickly find PRs assigned to you for review, visit https://github.com/pulls/review-requested (This is also available in the GitHub header under "Pull Requests → Review Requests")
Goals for 9.0
To be decided by DSpace Steering Group with feedback from Leadership Group.
Early brainstorms at DSpace Release 9.0 Status. Please feel free to add your own brainstorms or link in tickets that you wish to be considered.
Goals for 8.1 / 7.6.3
Deadline is TBD for both 8.1 and 7.6.3. Bug fix releases do not have fixed/scheduled deadlines. Instead, the developer team will determine when to create a release based on the significance of the issues to solve. (e.g. If major issues are fixed, then a bug fix release will occur more rapidly. If minor issues are found, then a bug fix release may be delayed until sufficient fixes have been made to warrant a release)
- Bug/security fixes only. These minor releases will not include any new features.
- New "themeable components" (for dspace-angular) are allowed in bug fix releases, provided that they don't significantly modify component behavior or similar.
- Accessibility fixes are also allowed in bug fix releases, provided they don't significantly modify component behavior or similar.
- Bug fix PRs should be created against "main" branch where possible. The "main" branch has the most strict code style rules. (i.e. PRs created against
dspace-7_x
are becoming more difficult to port forward.) - Per our support policy, bug fixes are only guaranteed to be ported back to 8.x. That said, where possible, we'll try to backport bug fixes (especially significant ones) to 7.6.x.
- Keep in mind, if a specific bug fix is important to you in 7.6.x, then it is best to create two PRs (one for main and one for "dspace-7_x"). If you are able to provide a backport version of the PR, then we will merge it alongside the "main" branch version.
- NOTE: In many scenarios, a backport to "dspace-8_x" should be possible to automate using the "port to [branch]" labels & the "Port merged Pull Request" GitHub Action
Try "Pull Request Trading" for a quicker review
Do you have a PR stuck in "under review" that you really want to see move forward? Or maybe it's someone else's PR but you want to get it more attention?
See Trading reviews on Pull Requests for how to get immediate attention to that PR!
Notes
Updates
- Holger and Tim will attend the NA User Group Meeting in Minneapolis from Sept. 23-25. This does not impact the regular meeting schedule of the weekly dev meetings
- Any agenda items for next week should be added by developers
DSpace 9.0 release
- No updates; upcoming Leadership meeting on October 2, where a final decision on 9.0 prioritization will be made
- In the meantime, we are working under the tentative assumption that prioritization will include items on the DSpace Release 9.0 Status page
Ongoing Discussion
- Incentivizing Code Reviews and PR Testing
- No updates; there will be a talk at the NA User Group Meeting including some PR testing; anyone who has ideas is encouraged to share
- High CPU with DSpace 7 SSR
- Latest update (from last week's meeting) relates to the small page regarding turning on SSR only for pages in sitemaps; details are in ticket
- No further updates
- Using both public/private REST API URLs for better performance
- Waiting on PR from 4Science
- No further updates
- Simplifying the Installation Process
- In 9.0, we are switching from yarn to npm (front-end); details are in ticket
- No further updates
Group review: Update ESLint configuration for json5 files
- Purpose: more consistency of translation files, less likelihood of merge conflicts
- Not complete; needs updating of json5 files
- Pascal raised issue to need to update the catalog before releases
- Need to figure out how to go about this
- Possibility to have a list of translators in a mailing list vs. contacting translators 1 by 1
- Possibility of running a script that updates json files
- Needs further discussion; someone who could investigate this further and explore ways of implementing this
- Pascal-Nicolas Becker will create discussion ticket to summarize the problem; anyone who has ideas about this, add to the ticket
- Reviewed https://github.com/DSpace/dspace-angular/pull/2317/files
- Giuseppe Digilio (4Science) will add a comment or create additional ticket/PR to discuss if we want to implement a check for duplicate tags in the json5 files.
Migrate cookie consent from Klaro to Orejime (#3199)
- Need to figure out if mandatory cookies need user consent according to GDPR compliance and if we need to display these (per pop-up) to users
- We believe the approach Orejime uses seems to be GDPR compliant. We believe the cookie popup does not need to be displayed if all cookies are mandatory.
- Pascal-Nicolas Becker noted that we may need to investigate DSpace's Solr Statistics to see if we need to add it to the cookie popup as an option to enable/disable (similar to Google Analytics).
- Pascal-Nicolas Becker also noted that the CORRELATION_ID used in the REST API may need to be investigated further. If it can be linked back to a user's account, then it could be a way to track user activities in the log. We need to determine if this is GDPR compliant, and whether it needs to be possible to opt out or disable it in some way.
- Need to create tickets to investigate both of these further (Pascal-Nicolas Becker will create ticket, link it back to this PR)
- Possibility of asking Steering for a small fund to address legal implications through a lawyer
Reorder buttons in Submission forms are not keyboard accessible (#1271)
- Art Lowel (Atmire) has a similar PR coming soon. Will create PR (link to #1271), Giuseppe Digilio (4Science) will review Art's approach
Board Review
- Feature curation link checker customizations 7.x (#9658)
- Reviewed and discussed changed files together
- Overall agree that this is a good fix, need to make sure that the maximum is configurable, allowing it to set to 0 as well, in order to avoid hitting an infinite loop