Developers Meeting on Thurs, Sep 12, 2024

Time/Location

12 Sep 2024 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace?pwd=RTk4QUhISnhPRi9YenVrTFJKbDllQT09 (Meeting ID: 502 527 3040).  Passcode: dspace

• More connection options available at DSpace Meeting Room

Agenda

• Discussion Topics - If you have a topic you'd like to have added to the agenda, please just add it. 
  1. DSpace 9.0 release (tentative April 2025)
     1. 9.0 Board is created: https://github.com/orgs/DSpace/projects/31/
     2. Early ideas/brainstorms captured at DSpace Release 9.0 Status
  2. Ongoing Discussions:
     1. Incentivizing Code Reviews and PR Testing
     2. High CPU with DSpace 7 SSR: https://github.com/DSpace/dspace-angular/issues/3110
     3. Using both public/private REST API URLs for better performance: https://github.com/DSpace/dspace-angular/issues/1485 (Assigned to 4Science)
     4. Simplifying the Installation Process: https://github.com/DSpace/dspace-angular/issues/3184
  3. Group Review of https://github.com/DSpace/dspace-angular/pull/3159 (from kshepherd)
  4. (Other topics?)
• Board Review:
  • 9.0 Project Board - Review PRs collaboratively or Assign new PRs to volunteers to code review and/or test.
  • Backlog Board - Are there any tickets here stuck in the "Triage" column?  We'd like to keep this column as small as possible.
  • 8.x and 7.6.x Maintenance Board - Known bugs can be found here, along with any backported bug fixes.
• Upcoming Topics: (Let us know if there are topics you want to discuss in future weeks)
  
  • DSpace accepts external identifiers (DOIs and such) from submitters, and manages others (DOIs again, Handles) itself.  Should these be stored in separate metadata fields? what fields? what schema?  Various bits of DSpace have disagreed on the answers.  See also https://github.com/DSpace/DSpace/pull/1006.
  • Discussion/proposal around refactoring and simplifying Live Import and External Data frameworks: https://github.com/DSpace/DSpace/issues/9758
    (nothing concrete yet but would be great to get thoughts added to this issue and maybe find some collaborators)

Attendees

• Tim Donohue 
• Holger Lenz 

• Art Lowel (Atmire) 

• Andrea Bollini (4Science)

• Giuseppe Digilio (4Science) 
• Paulo Graça
• Mark H. Wood 
• Grazia Quercia (4Science)
• Corrado Lombardi (4Science) 
• Julian Timal (eScire) 
• Martin Walk 
• Melissa Anez 
• Oliver Goldschmidt 
• Hrafn Malmquist 
• Pascal-Nicolas Becker 
• Pierre Lasou 
• Kim Shepherd 
• Nicholas Woodward 

Current Work

Project Boards

• DSpace 9.0 board: https://github.com/orgs/DSpace/projects/31
• DSpace 8.x and 7.6.x board: https://github.com/orgs/DSpace/projects/29

To quickly find PRs assigned to you for review, visit https://github.com/pulls/review-requested  (This is also available in the GitHub header under "Pull Requests → Review Requests")

Goals for 9.0

To be decided by DSpace Steering Group with feedback from Leadership Group. 

Early brainstorms at DSpace Release 9.0 Status.  Please feel free to add your own brainstorms or link in tickets that you wish to be considered. 

Goals for 8.1 / 7.6.3

Deadline is TBD for both 8.1 and 7.6.3.  Bug fix releases do not have fixed/scheduled deadlines. Instead, the developer team will determine when to create a release based on the significance of the issues to solve. (e.g. If major issues are fixed, then a bug fix release will occur more rapidly.  If minor issues are found, then a bug fix release may be delayed until sufficient fixes have been made to warrant a release)

• Bug/security fixes only.  These minor releases will not include any new features.
  • New "themeable components" (for dspace-angular) are allowed in bug fix releases, provided that they don't significantly modify component behavior or similar.
  • Accessibility fixes are also allowed in bug fix releases, provided they don't significantly modify component behavior or similar.
• Bug fix PRs should be created against "main" branch where possible. The "main" branch has the most strict code style rules. (i.e. PRs created against dspace-7_x  are becoming more difficult to port forward.)
• Per our support policy, bug fixes are only guaranteed to be ported back to 8.x.  That said, where possible, we'll try to backport bug fixes (especially significant ones) to 7.6.x.
  • Keep in mind, if a specific bug fix is important to you in 7.6.x, then it is best to create two PRs (one for main and one for "dspace-7_x").  If you are able to provide a backport version of the PR, then we will merge it alongside the "main" branch version.
  • NOTE: In many scenarios, a backport to "dspace-8_x" should be possible to automate using the "port to [branch]" labels & the "Port merged Pull Request" GitHub Action

Try "Pull Request Trading" for a quicker review

Do you have a PR stuck in "under review" that you really want to see move forward?  Or maybe it's someone else's PR but you want to get it more attention?

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

9.0 Prioritization updates

• No further updates from DSpace governance
• The first five items on the "Under Discussion for 9.0 list" (DSpace Release 9.0 Status) can be worked on until we receive further direction
  • Improving performance / scalability in general
  • Easier Installation and Upgrades
  • Code Cleanup / Maintenance
  • Modularization
  • Accessibility fixes and other major bug fixes
• Dependency on yarn has been removed for 9.0 (use of npm instead of yarn, #3173)
  • Has been included in Docker installation

Other updates

• Upcoming NA User Group Meeting in Minneapolis, Sept. 23-25, 2024
• Tim Donohue and Holger Lenz will attend and present

Ongoing Discussion

• Incentivizing Code Reviews and PR Testing: no updates
• High CPU with DSpace 7 SSR: New patch in ticket that allows to trigger SSR only on specific pages (see comment from user-1678f) 
• Using both public/private REST API URLs for better performance: Still waiting on PR from 4Science
• Simplifying the Installation Process: Transition to npm seems to be working well; if anyone encounters bugs, please report them
  • More on transition to npm: https://github.com/DSpace/dspace-angular/pull/3173

PR Group Reviews

• Various browse link rendering fixes (#3159)
  • Kim Shepherd described the problem (see ticket description)
  • The team reviewed the problem and the suggested solution
  • "Needs discussion" label has been removed
  • Needs testing to check if it behaves as expected.  Nick Woodward offered to retest
  • Tim Donohue added to list of reviewers
• Accessibility cookie settings (#3140)
  • Needs to be closed; invalid, replaced by #3199
  • UPDATE: After the meeting, Tim realized #3140 might still be necessary for DSpace 8.x and 7.x, as those will continue to use Klaro.  See https://github.com/DSpace/dspace-angular/pull/3140#issuecomment-2346615993
• Migrate cookie consent from Klaro to Orejime (#3199)
  • Needs more attention; a lot of translation tags are being removed from the JSON 5 files (UPDATE: After meeting Tim clarified this is necessary)
  • Removed configuration (lines 112-115) needs to be reviewed 
  • Tim Donohue and Art Lowel (Atmire) assigned to review
• Support for disabled elements for screen readers (#3268)
  • Finds an accessible way to disable buttons
  • Mark H. Wood: general recommendation to update accessibility documentation to add the dsdisabled directive
  • Observation: PR is missing code comments to describe code (especially the disabled-directive part)
  • Looks generally good, but needs a quick scan to make sure that it's complete
  • Tim Donohue assigned to PR review