Date
Call-in Information
Time: 10:00 am, Eastern Time (New York, GMT-04:00)
Join Zoom Meeting
https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09Meeting ID: 813 9822 8834
Passcode: 728426
Attendees
Indicating note-taker
Agenda
- Releases management
- Status
- Urgent action is needed to make VIVO 1.12.1 functional
- Next steps
- We are switching to time-based publishing releases process, therefore we need
- Efficient process
- Well documented
- More members capable to do that as a backup solution if Ralph is not available
- We are switching to time-based publishing releases process, therefore we need
- Status
Moving forward reviewing PRs on VIVO and Vitro
- https://github.com/vivo-project/Vitro/pulls and https://github.com/vivo-project/VIVO/pulls
- Tiny and big PRs classification
- labels - small, middle, large PR
- assignments of labels mostly done for 2021 PRs
- Should we discourage large PRs in the future?
- Probably not always possible
- Assignment of reviewers
- mostly done for 2021 PRs
- please, check and inform me if you are available and willing to perform review (and provide some estimation when that can happen)
- Using slack and core committers meetings for pre-reviewing discussion and reporting
- How to proceed with old PRs
- contributors are not active anymore in the VIVO community
- merging conflicts
- organization of repository might be changed
- Accepting and merging part of commits
- https://github.com/vivo-project/VIVO-languages/pull/99
- Any strategy already defined or previous experience
- VIVO 2.0 architecture
- https://docs.google.com/document/d/1z51mkqlAopQ2rLkitHiQVwRojijnPM9pB8tQelW-lSA/edit?usp=sharing
- Presentation of VIVO 2.0 to Leadership group is expected
- at high level of abstraction
Notes
- Releases management
- Status
- Urgent action is needed to make VIVO 1.12.1 functional
- Next steps
- We are switching to time-based publishing releases process, therefore we need
- Efficient process
- Well documented
- More members capable to do that as a backup solution if Ralph is not available
Dragan: release looks good but not working when test deployment
Ralph: possible dependencies needed to be enabled and will further test
Dragan: moving toward schedule based release and would like to have more ability to publish releases by the committer team
Ralph: release documentation continue to update and evolve
Dragan: unable to follow through without consequences of publishing
Dragan: can Ralph and I pair on next release to train for backup
Ralph: yeah
Brian: concerned about difficulty each committer setting up environment to publish release
William: can use docker image
Ralph: can look into docker image for publishing release to maven
- Moving forward reviewing PRs on VIVO and Vitro
- Tiny and big PRs classification
- labels - small, middle, large PR
- assignments of labels mostly done for 2021 PRs
- Should we discourage large PRs in the future?
- Probably not always possible
- Assignment of reviewers
- mostly done for 2021 PRs
- please, check and inform me if you are available and willing to perform review (and provide some estimation when that can happen)
- Using slack and core committers meetings for pre-reviewing discussion and reporting
- How to proceed with old PRs
- contributors are not active anymore in the VIVO community
- merging conflicts
- organization of repository might be changed
- Accepting and merging part of commits
- Any strategy already defined or previous experience
Dragan: ^^^
Dragan: questions regarding assigned PRs
Ralph: minor fixes needed and reask reviews
William: do we need build optimizations Improve MAVEN build Performance by ChenZhangg · Pull Request #247 · vivo-project/Vitro (github.com)
Ralph: No
William: No
Georgy: messy PR Vivo 2004 by michel-heon · Pull Request #243 · vivo-project/Vitro (github.com)
William: should request changes or hand off
Georgy: do we need it?
Benjamin: how to find issues I opened in Jira to determine if they need to be closed
Dragan: possible filter out by name and look through
William: can we have an expiration?
Benjamin: consider closing Graham’s PRs if not utility or not desired feature
Ralph: can close and reopen new dependency and plugin updates by EDemerzel · Pull Request #132 · vivo-project/Vitro (github.com)
Georgy: one committer comment that needs to be closed and second committer confirming and closing
Dragan: yes
Dragan: same for merging small PRs one comment and one merge
Dragan: should we discourage large PRs
William: yes, also express in PR template
Dragan: Change one label in initialTBoxAnnotations_fr_CA.nt by michel-heon · Pull Request #99 · vivo-project/VIVO-languages (github.com) how to handle?
- VIVO 2.0 architecture
- Presentation of VIVO 2.0 to Leadership group is expected
- at high level of abstraction
Actions
- Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.1 release
- Dragan Ivanovic to update PR template to discourage large PRs or at least to ask contributor for reason why it is necessary to have large PR
Previous actions
- Dragan Ivanovic to help Ralph in resolving publishing releases issue. Also, to try to improve documentation.
- Dragan Ivanovic to assign PRs to reviewers (committers)
- Later, we can improve contribution policy, including closing PR with inactive PR creators (who didn't responded on comments). We should also consider introducing Contributor license agreements in the process - link
- Ralph O'Flinn To investigate reversing publishing VIVO installer artifact to Sonatype
- Ralph O'Flinn first pass through PRs and sending out an email to other committers
- All to read and provide feedback for VIVO 2.0 architecture https://docs.google.com/document/d/1z51mkqlAopQ2rLkitHiQVwRojijnPM9pB8tQelW-lSA/edit?usp=sharing