You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 7 Current »

Date

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

Attendees

(star)  Indicating note-taker

  1. Brian Lowe  
  2. Georgy Litvinov 
  3. Ralph O'Flinn 
  4. William Welling (star)
  5. Benjamin Gross
  6. Dragan Ivanovic 
  7. Huda Khan 

Agenda

  1. Releases management
    1. Status
      1. Urgent action is needed to make VIVO 1.12.1 functional
    2. Next steps
      1. We are switching to time-based publishing releases process, therefore we need
        1. Efficient process
        2. Well documented
        3. More members capable to do that as a backup solution if Ralph is not available

  2. Moving forward reviewing PRs on VIVO and Vitro

    1. https://github.com/vivo-project/Vitro/pulls and https://github.com/vivo-project/VIVO/pulls
    2. Tiny and big PRs classification
      1. labels - small, middle, large PR
      2. assignments of labels mostly done for 2021 PRs
      3. Should we discourage large PRs in the future?
        1. Probably not always possible
    3. Assignment of reviewers
      1. mostly done for 2021 PRs
      2. please, check and inform me if you are available and willing to perform review (and provide some estimation when that can happen)
    4. Using slack and core committers meetings for pre-reviewing discussion and reporting
    5. How to proceed with old PRs
      1. contributors are not active anymore in the VIVO community
      2. merging conflicts
        1. organization of repository might be changed
    6. Accepting and merging part of commits 
      1. https://github.com/vivo-project/VIVO-languages/pull/99
      2. Any strategy already defined or previous experience
        1.  https://code-maven.com/merge-one-commit-from-a-pull-request
  3. VIVO 2.0 architecture
    1. https://docs.google.com/document/d/1z51mkqlAopQ2rLkitHiQVwRojijnPM9pB8tQelW-lSA/edit?usp=sharing
    2. Presentation of VIVO 2.0 to Leadership group is expected
      1. at high level of abstraction

Notes

  • Releases management
    • Status
      • Urgent action is needed to make VIVO 1.12.1 functional
    • Next steps
      • We are switching to time-based publishing releases process, therefore we need
        • Efficient process
        • Well documented
        • More members capable to do that as a backup solution if Ralph is not available

Dragan: release looks good but not working when test deployment

Ralph: possible dependencies needed to be enabled and will further test

Dragan: moving toward schedule based release and would like to have more ability to publish releases by the committer team

Ralph: release documentation continue to update and evolve

Dragan: unable to follow through without consequences of publishing

Dragan: can Ralph and I pair on next release to train for backup

Ralph: yeah

Brian: concerned about difficulty each committer setting up environment to publish release

William: can use docker image

Ralph: can look into docker image for publishing release to maven

  • Moving forward reviewing PRs on VIVO and Vitro
    • Tiny and big PRs classification
      • labels - small, middle, large PR
      • assignments of labels mostly done for 2021 PRs
      • Should we discourage large PRs in the future?
        • Probably not always possible
    • Assignment of reviewers
      • mostly done for 2021 PRs
      • please, check and inform me if you are available and willing to perform review (and provide some estimation when that can happen)
    • Using slack and core committers meetings for pre-reviewing discussion and reporting
    • How to proceed with old PRs
      • contributors are not active anymore in the VIVO community
      • merging conflicts
      • organization of repository might be changed
    • Accepting and merging part of commits 
      • Any strategy already defined or previous experience

Dragan: ^^^

Dragan: questions regarding assigned PRs

Ralph: minor fixes needed and reask reviews

William: do we need build optimizations Improve MAVEN build Performance by ChenZhangg · Pull Request #247 · vivo-project/Vitro (github.com)

Ralph: No

William: No

Georgy: messy PR Vivo 2004 by michel-heon · Pull Request #243 · vivo-project/Vitro (github.com)

William: should request changes or hand off

Georgy: do we need it?

Benjamin: how to find issues I opened in Jira to determine if they need to be closed

Dragan: possible filter out by name and look through

William: can we have an expiration?

Benjamin: consider closing Graham’s PRs if not utility or not desired feature

Ralph: can close and reopen new dependency and plugin updates by EDemerzel · Pull Request #132 · vivo-project/Vitro (github.com)

Georgy: one committer comment that needs to be closed and second committer confirming and closing

Dragan: yes

Dragan: same for merging small PRs one comment and one merge

Dragan: should we discourage large PRs

William: yes, also express in PR template

Dragan: Change one label in initialTBoxAnnotations_fr_CA.nt by michel-heon · Pull Request #99 · vivo-project/VIVO-languages (github.com) how to handle?

  • VIVO 2.0 architecture
    • Presentation of VIVO 2.0 to Leadership group is expected
      • at high level of abstraction

Draft notes on Google Drive

Actions 

  • Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.1 release
  • Dragan Ivanovic to update PR template to discourage large PRs or at least to ask contributor for reason why it is necessary to have large PR

Previous actions 

  • No labels

All content on the LYRASIS Wiki is licensed under the CC BY (Attribution) license, unless otherwise noted.