2020-02-27 DSpace 7 Working Group Meeting

Date

27 Feb 2020 from 15:00-16:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (25 mins) General Discussion Topics
  
  1. Wrapping up Beta1 release (if needed)
  2. (If further discussion is needed) Revisiting Scripts & Processes endpoint PR#2648: Tim has concerns about usage of Bitstreams for temporary files (like uploaded CSVs, SAF Zips, AIPs, etc)
     1. See also last week's discussion notes
  3. (Please add a topic)
• (20 mins) Planning for next week
  
  • Claim tasks for next week from DSpace 7 Release Plan spreadsheet
  • Assigning PRs for Review

Attendees

• Art Lowel (Atmire) 

• Andrea Bollini (4Science)  

• Tim Donohue

• Lieven Droogmans 

• Mark H. Wood
• Giuseppe Digilio (4Science) 
• Ben Bosman
• Chris Wilper
• Paulo Graça 

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

• DSpace 7 Release Goals : overview of goals/timelines & beta release process
• DSpace 7 Release Plan spreadsheet:  our planning spreadsheet which details which features are scheduled for each Beta release.

Current Work

Claim a Ticket!

If you do not have access in JIRA or GitHub to officially claim the ticket you wish to work on, contact Tim Donohue

• Available Angular UI Tickets
  • Open issues in 7.0beta1 milestone (highest priority)
  • Open issues in 7.0beta2 milestone (second highest priority)
  • Open issues flagged as "Difficulty: low".  These may be a good starting point for newer developers.
• Available REST API Tickets
  • Unassigned tickets scheduled for 7.0beta1 (highest priority)
  • Unassigned tickets scheduled for 7.0beta2 (second highest priority)
  • General REST API tickets flagged as "low hanging fruit".  These may be a good starting point for newer developers.
  • General REST API unassigned bug tickets.  Again, might be a good starting point for newer developers.

PRs Needing Review

1. (REST) (beta2) Select specific embeds (depends on PR#2625): https://github.com/DSpace/DSpace/pull/2670 (Tim Donohue, Ben Bosman)
2. (REST) (beta 2 but dependencies) Workflow step definitions https://github.com/DSpace/DSpace/pull/2646  (Ben Bosman - REREVIEW BY FEB 27, Tim Donohue - REREVIEW BY FEB 27, Andrea Bollini (4Science) - REREVIEW BY FEB 27)
3. (REST) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - REVIEW BY FEB 20, Tim Donohue - REVIEW Comments, Mark H. Wood  )
4. (REST) Shibboleth authentication https://github.com/DSpace/DSpace/pull/2651 (Paulo Graça - REREVIEW, Ben Bosman  - REREVIEW)
5. (REST) Edit Item - Manage Bitstreams https://github.com/DSpace/DSpace/pull/2666 1 APPROVAL (Tim Donohue)
6. (REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 (Tim Donohue - questions added, request for JavaDocs) (Possibly one approval)
7. (REST) Initial implementation of the authorizations endpoints https://github.com/DSpace/DSpace/pull/2663 (Ben Bosman - REVIEW by FEB 27 (if possible), Tim Donohue - REVIEW by FEB 27)
8.  (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673 1 APPROVAL( Tim Donohue, Andrea Bollini (4Science) - feedback added)
9. (REST) Read only versioning endpoints https://github.com/DSpace/DSpace/pull/2680 1 APPROVAL (Tim Donohue)
10. (REST) Workflow step definitions: action validation (depends on #2646 above) https://github.com/DSpace/DSpace/pull/2685 (Tim Donohue, Ben Bosman, Andrea Bollini (4Science))
11. (Angular) Shibboleth authentication (merge with REST PR #2651) https://github.com/DSpace/dspace-angular/pull/568 (Paulo Graça, Ben Bosman)
12. (Angular) (beta 2) Edit Item Bitstreams Tab (depends on #578 below) https://github.com/DSpace/dspace-angular/pull/577 (Tim Donohue, Giuseppe Digilio (4Science))
13.   (Angular) (beta 1) Only resolve links when needed (Performance improvement work) https://github.com/DSpace/dspace-angular/pull/578 (Tim Donohue - REREVIEW ASAP, Giuseppe Digilio (4Science) - REVIEW ASAP, Paulo Graça - REVIEW ASAP )
14.   (Angular) (beta 1) Angular 8 Upgrade https://github.com/DSpace/dspace-angular/pull/579 (Tim Donohue , Giuseppe Digilio (4Science) - REVIEW ASAP, Paulo Graça - REVIEW ASAP)
15. (Backend) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 (NEEDS REVIEWERS)

PRs Coming Soon

1. (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously ETA feb 21  Unable to locate Jira server for this macro. It may be due to Application Link configuration.  - 1 APPROVAL (Tim Donohue, Ben Bosman if needed)
2. Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously ETA feb 21  Unable to locate Jira server for this macro. It may be due to Application Link configuration.  - 1 APPROVAL (Tim Donohue, Ben Bosman if needed)
3. Submitters can edit all metadata ETA feb 24  Unable to locate Jira server for this macro. It may be due to Application Link configuration.  - (Tim Donohue, Ben Bosman)
4. (REST) (beta 2 - has upcoming dependencies) Manage Groups - ETA Feb 21 - DS-4026 (Tim Donohue, Andrea Bollini (4Science) if needed)
5. (Angular) (beta 2) Specify embeds - ETA feb 21 - 1 APPROVAL(Tim Donohue)
6. (Angular) (beta 2) List versions - ETA feb 21 - (Tim Donohue, NEEDS SECOND REVIEWER)
7.  (Angular) (beta 1) Breadcrumbs - ETA feb 26 - (Tim Donohue, Giuseppe Digilio (4Science))

PRs Merged this week!

1.  (REST Contract) Update Projections contract to align with impl: https://github.com/DSpace/Rest7Contract/pull/94
2.  (REST Contract) Fix REST contracts to report 400 response for param exceptions (related to REST PR#2668 below): https://github.com/DSpace/Rest7Contract/pull/102
3.  (REST) DS-4428 missing parameter exception https://github.com/DSpace/DSpace/pull/2668 1 APPROVAL 
4.  (Angular) Fix angulartics router bug https://github.com/DSpace/dspace-angular/pull/580
5.  (Backend) DS-4434: Fix Context.commit() / isValid() and add Tests https://github.com/DSpace/DSpace/pull/2674
6.  (Backend) Fix errorprone test warnings after Java 11 upgrade: https://github.com/DSpace/DSpace/pull/2669 1 APPROVAL 

Blocked

1. (Blocked PRs go here)

Delayed / Needs Discussion

1. Managing Authorization info in Angular UI: How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
   1. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
   2. Work is ongoing, but has been started in these areas:
      1. Summary of ideas: REST Authorization 
      2. Contract for Authorization Endpoints: https://github.com/DSpace/Rest7Contract/pull/92
      3. Contract for ResourcePolicies: https://github.com/DSpace/Rest7Contract/pull/87
2. REST API Projections:  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
   1. Work begun in https://github.com/DSpace/DSpace/pull/2547 (by Chris Wilper)
      1. Based on detail discussions in our Oct 17 meeting. 
   2. (Outdated) Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
   3. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
3. Initial Performance Testing from Chris.
   1. https://cwilper.github.io/dspace-perftest/
4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
5.  (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
6. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
   1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
   2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
   3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes