Page tree
Skip to end of metadata
Go to start of metadata

Developers Meeting on Weds, August 29, 2018

 

Today's Meeting Times

Our IRC logging bot has been blocked from Freenode (as of July 27).

Discussion logs are no longer available at http://irclogs.duraspace.org/. As our current IRC log bot (based on PircBot) is unmaintained and doesn't align with Freenode policies (around requiring SASL authentication), Tim has reached out to https://botbot.me/ to see if they could log our #duraspace IRC channel. In the meantime, full logs of meeting discussions will be copied into the Wiki notes below.

Agenda

Quick Reminders

Friendly reminders of upcoming meetings, discussions etc

Discussion Topics

If you have a topic you'd like to have added to the agenda, please just add it.

  1. (Ongoing Topic) DSpace 7 Status Updates for this week. 

    1. DSpace 7 Working Group is where the work is taking place
    2. DSpace 7 Dev Status spreadsheet: https://docs.google.com/spreadsheets/d/18brPF7cZy_UKyj97Ta44UJg5Z8OwJGi7PLoPJVz-g3g/edit#gid=0
  2. (Ongoing Topic) DSpace 6.x Status Updates for this week

    1. 6.4 will surely happen at some point, but no definitive plan or schedule at this time.  Please continue to help move forward / merge PRs into the dspace-6.x branch, and we can continue to monitor when a 6.4 release makes sense.
  3. Brainstorming ideas for future DSpace Developer Show and Tell Meetings
  4. [Follow-up] How to encourage / credit folks who do Code Reviews? (Tim Donohue)
    1. We have a lot of open PRs.  As we know, the process for reviewing is very ad-hoc, sometimes encounters delays.  If we can find ways to encourage/empower folks (even non-Committers if they know Java / Angular well) to do code reviews & be credited publicly...maybe we can speed up this process?
    2. UPDATE: Tagging is complete. Feedback on the labels is welcome:  https://github.com/DSpace/DSpace/labels
  5. Brainstorms / ideas (Any quick updates to report?)
    1. Bulk Operations Support Enhancements (from Mark H. Wood)
    2. Curation System Needs (from Terrence W Brady )
  6. Tickets, Pull Requests or Email threads/discussions requiring more attention? (Please feel free to add any you wish to discuss under this topic)
    1. Quick Win PRs: https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+review%3Aapproved+label%3A%22quick+win%22

Tabled Topics

These topics are ones we've touched on in the past and likely need to revisit (with other interested parties). If a topic below is of interest to you, say something and we'll promote it to an agenda topic!

  1. Management of database connections for DSpace going forward (7.0 and beyond). What behavior is ideal? Also see notes at DSpace Database Access
    1. In DSpace 5, each "Context" established a new DB connection. Context then committed or aborted the connection after it was done (based on results of that request).  Context could also be shared between methods if a single transaction needed to perform actions across multiple methods.
    2. In DSpace 6, Hibernate manages the DB connection pool.  Each thread grabs a Connection from the pool. This means two Context objects could use the same Connection (if they are in the same thread). In other words, code can no longer assume each new Context() is treated as a new database transaction.
      1. Should we be making use of SessionFactory.openSession() for READ-ONLY Contexts (or any change of Context state) to ensure we are creating a new Connection (and not simply modifying the state of an existing one)?  Currently we always use SessionFactory.getCurrentSession() in HibernateDBConnection, which doesn't guarantee a new connection: https://github.com/DSpace/DSpace/blob/dspace-6_x/dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java


Ticket Summaries

  1. Help us test / code review! These are tickets needing code review/testing and flagged for a future release (ordered by release & priority)

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P Status Fix Version/s
    Loading...
    Refresh

  2. Newly created tickets this week:

     Click here to expand...

    Key Summary T Created Assignee Reporter P Status
    Loading...
    Refresh

  3. Old, unresolved tickets with activity this week:

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P Status
    Loading...
    Refresh

  4. Tickets resolved this week:

     Click here to expand...

    Key Summary T Created Assignee Reporter P Status Resolution
    Loading...
    Refresh

  5. Tickets requiring review. This is the JIRA Backlog of "Received" tickets: 

     Click here to expand...

    Key Summary T Created Updated Assignee Reporter P
    Loading...
    Refresh

Meeting Notes

Meeting Transcript (IRC Bot is not working)

Log from #dev-mtg Slack (All times are CDT)
Tim Donohue [2:47 PM]
@here: Reminder that our weekly DSpace DevMtg starts at the top of the hour (~13mins) here .  The agenda is a bit light today, so additional topics welcome: https://wiki.duraspace.org/display/DSPACE/DevMtg+2018-08-29

Tim Donohue [3:00 PM]
@here: It's DSpace DevMtg time.  The agenda is listed above (most of it is quick updates / checkins, so we likely will have time for further topics
First off, let's do a quick roll call to see who is joining us today

James Creel [3:01 PM]
I'm here

Pablo Prieto [3:01 PM]
Hi :spock-hand:

Mark Wood [3:02 PM]
Hi.

Tim Donohue [3:02 PM]
Hi, James, Pablo & Mark. I know Terry said he'd be joining in a bit as well
So, we'll go ahead and get things started here

Terry Brady [3:02 PM]
I'm here for 10 min

Tim Donohue [3:03 PM]
So, quick updates.... DSpace 7 doesn't have much to report right now. PRs are coming in, getting reviewed/merged  (and we can always use more reviewers)
The DSpace 7 Entities Working Group is starting up soon though. If you want to be in the first meeting, this is the last chance to fill out the Doodle poll: https://doodle.com/poll/nvaykbdevwnfc5fd
And, speaking of DSpace 7 Entities WG, one of the first roles of this group will be to review/assess the viability of an early prototype of Configurable Entities.  That prototype now has docs...they are at..
https://docs.google.com/document/d/1wEmHirFzrY3qgGtRr2YBQwGOvH1IuTVGmxDIdnqvwxM/edit
To be clear, you don't have to be on this Working Group to help with the assessment of this prototype. So, if you care to simply help with assessment, that Google Doc is publicly open for comments.  Or you can writeup any assessment (on wiki, etc) and send my way.
I think that's it for DSpace 7 updates.
Any questions/comments on that?
Ok, moving on... I have no updates on DSpace 6.x / 6.4 myself.  We still have 6.x PRs coming in, but no specific plans on the 6.4 release schedule yet
So, we'll move along from that..
Topic #3... I know @terrywbrady (who has to leave shortly) wanted to brainstorm ideas for future Dev Show & Tell meetings
@terrywbrady I realize you likely won't be able to stick around for this brainstorm, but is there anything you'd like to say briefly, before you leave?

Terry Brady [3:09 PM]
The meetings have gone well and the recordings have been useful.
Attendance has tapered off in the last couple sessions.
I do not know if less frequency is needed or if we need to rethink how to run the sessions.
My hope was to create a virtual conference type experience for the developer community.
What thoughts do you all have?
If we have agenda items, I will be happy to coordinate future sessions.

Tim Donohue [3:11 PM]
I've found the sessions quite interesting myself -- but I know a lot of the ideas thus far have relied heavily on you, @terrywbrady.
And yes, attendance has dropped a bit, but it's hard to say if that's cause more people are watching the video, or cause of summer vacations, etc. etc.

Terry Brady [3:12 PM]
Whether you have attended in the past or not, what subjects would be most interesting to you?

Tim Donohue [3:13 PM]
anyone @here have thoughts on subjects/topics of interest for Dev Show & Tell? :point_up:
I've enjoyed learning about Docker. I admit, I haven't had much chance to try it out locally.   I suspect that sessions on DSpace 7 will be useful (as that gets closer to "beta"), but we still may be too early for that.

Mark Wood [3:15 PM]
The organization of the XMLUI rendering pipeline is always a bit of a mystery, especially the tangle of transforms in the themes.

Tim Donohue [3:16 PM]
@mwood: I wish I knew that "by heart" myself.
Maybe there's an opportunity here to put out another "call for ideas" to dspace-devel (and/or dspace-tech) to see if folks (not in this meeting) have other thoughts to share?
We also could consider taking a brief hiatus...or potentially even having a session to simply discuss feedback on the "Configurable Entities" early prototype (mentioned above). Though, that's less of a "show & tell" and more a developer discussion

Terry Brady [3:18 PM]
Thanks.  I will catch you all later

Tim Donohue [3:18 PM]
Thanks @terrywbrady.  We can catch up later
Any other final thoughts / brainstorms to share with regards to Dev Show & Tell?  (If not, I'll move along shortly)
Ok, hearing none
Moving along... a brief update on "Encouraging Code Reviews"...
As mentioned on #dev a few days ago, I've finished up tagging of *all* PRs.  So, we have a bunch of shiny new labels/categories: https://github.com/DSpace/DSpace/labels
These labels are by no means "final" (and they only really represent things we have PRs for)
But, I feel they do provide us a way to more easily find related PRs, and to help folks better "concentrate" on reviewing PRs of interest to them (based on features, components, etc)
Nonetheless, I do welcome feedback / ideas on all this.  As of now, I plan to label/tag all new PRs coming in the door in this manner
I also did want to mention, as of this morning, I've been playing a bit more with the GitHub GraphQL API: https://developer.github.com/v4/explorer/.
Specifically, I'm investigating whether we can create "canned" queries that can promote/credit individuals who are contributing significantly to DSpace (via GitHub)
So far, I don't have those queries built, but I have some good starting work.  I'm looking at whether I can create ongoing lists of "Top PR creators / commenters / reviewers per month"
Right now, I *think* it'd be possible, but I'm still working on verifying.
In any case, this API is very powerful in terms of what you can query...so, I plan to see if we can start with a few promotional lists, and build from it as we go
Any comments/thoughts/questions on any of those brief updates?

Pablo Prieto [3:27 PM]
I think it's ok. I guess once we have a look at the result we could consider a change, if any is needed.
Is there any way to see the current graphs?

Tim Donohue [3:28 PM]
Yes, I'm really just looking for a starting point :slightly_smiling_face:    Unfortunately, the "graphs" themselves don't seem to be shareable. You have to login via GitHub to run queries.
I do have a few "in progress" queries, but I'm still working on tweaking them... the queries are shareable, obviously (and I'll share them as soon as I get them working right)

Pablo Prieto [3:30 PM]
ok

Tim Donohue [3:30 PM]
My hope is we can use the query results (returned in JSON) to generate some sort of "report" (maybe in HTML).  But, I admit, I literally just started playing with it today, so I don't have anything to share yet.

Pablo Prieto [3:30 PM]
The API is public?

Tim Donohue [3:30 PM]
Yes, the GitHub API is publicly queryable at: https://developer.github.com/v4/explorer/

Pablo Prieto [3:31 PM]
For example, those JSONs you mention. Could those be called from outside github? Maybe dev could pop some graphs of their contributions on their website / portfolio
That would make it attractive

Tim Donohue [3:32 PM]
Yes, the API is public, but you need to authenticate with Github (so you need a login to GitHub).  Once authenticated, you can run queries via `curl` or similar. The results get returned in JSON, so you'd have to parse them from there to put into a website or similar

Pablo Prieto [3:33 PM]
Oh, ok.

Tim Donohue [3:33 PM]
I've figured out how to run basic queries via `curl` and started trying to manipulate the JSON returned. But, I don't have anything public to show for it yet.  I definitely will share it once it's "something".  Right now it's random notes/queries I'm testing out to figure out how it works

Mark Wood [3:34 PM]
If one could get back XML, then a transform could turn the data into SVG for graphing....

Tim Donohue [3:35 PM]
I think it only speaks JSON...but I could be wrong.  The docs are at https://developer.github.com/v4/ though

Pablo Prieto [3:35 PM]
Json + angular / jscharts could work
https://www.chartjs.org/
chartjs.org
Chart.js | Open source HTML5 Charts for your website
Simple, clean and engaging HTML5 based JavaScript charts. Chart.js is an easy way to include animated, interactive graphs on your website for free.

Tim Donohue [3:36 PM]
Nice, I'll have to look into how that works. I haven't tried it yet, but it would be cool to display results in a chart/diagram, if possible.
In any case, as I dig more, I'll report back.  I'm hoping to minimally get to a point (soon) where I can manually run these queries and report on them.  But, the end, it'd be nice to automate this to run once a month (or some similar timeline)
That's all I had to report at this time.  Likely I should have more to show next week
So, moving along to topic #5 (which is a few ongoing ideas/brainstorms).  Any updates/further thoughtson topics linked under there?
Sounds like none.

Mark Wood [3:41 PM]
Nothing yet.

Tim Donohue [3:41 PM]
Are there any other topics that anyone @here would like to bring up for discussion today?  Any questions/thoughts/brainstorms?

James Creel [3:41 PM]
I was supposed to give a run-down of the recent DSpace User Group meeting here in Texas

Tim Donohue [3:41 PM]
Oh, yes, please do, @jcreel256.  I'm interested to hear how it went

James Creel [3:43 PM]
Basically, Ed Warga of TAMU Corpus Christi MC'd and we had introductions and planned out where to go from here
There were a number of librarians and administrators from around the state

Mark Wood [3:43 PM]
So this was meeting #1.

James Creel [3:43 PM]
#1 of a reboot - I think the group existed awhile back, but this was the first time I attended
In meetings to come, people are wanting to get help and consultation with:  Accessibilitiy, Metrics/Statistics, Outreach, Embaroges, , etc...
Texas Digital Library (TDL) is busy migrating lots of folks here from DSpace 5 to DSpace 6, so 7 is not yet on their radar really
But I will keep them apprised

Tim Donohue [3:46 PM]
Sounds good.  Those sound like similar topics of interest to others these days -- I've heard plenty of talk about the first two  (Accessibility and Metrics/Statistics) on mailing lists, at other meetings, etc.
So, it'll be interesting to see how this group moves forward on these topics, and if there's any materials/training docs that could be created out of some of this

James Creel [3:47 PM]
Yes, it's kind of interesting to me as well how information and software get disseminated throughout the ecosystem and various users and stakeholders of varying levels of involvement, sometimes slowly :slightly_smiling_face:
There should be some educational documents coming out of the process, and I'll encourage folks to make those public
Here are the minutes of the meeting: https://docs.google.com/document/d/1AZz5rMTK3TJnYBKseWZk9H-tT-y7-yx5R0NqkYiUPNg/edit

Tim Donohue [3:50 PM]
Sounds good. Yes, I think the more we can encourage these meetings to create public documentation, the better. I think there's a lot of common topics across these regional meetings, and it'd be useful to get a good sense of what best practices should "bubble up" and be shared at a higher level
Thanks for reporting back, @jcreel256.
Are there any other final topics/thoughts for today?  We have about 9 minutes left
OK, not hearing any.  As we only have a handful of minutes left, I'd say let's wrap up for today.  If there are any topics you'd like to see added next week, please let me know.  I'm always glad to add topics to this meeting
Thanks all, and have a good rest of your week (if I don't talk to you in another meeting)!

Mark Wood [3:53 PM]
Thanks, all!

Pablo Prieto [3:54 PM]
Thanks!