...

• Questions/Issues/Pull requests/Announcements
  
  1. euroCRIS strategic membership meeting
     1. Initiatives for making VIVO platform more interoperable
        1. Mapping between CERIF and VIVO ontology
        2. Integration of VIVO platform and DSpace repository
        3. Building a REST endpoint for getting and ingesting data from/into VIVO graph
  2. VIVO leadership group meeting
  3. AWS Neptune
     1. issue - https://github.com/vivo-project/VIVO/issues/3767 
     2. PRs
        1. https://github.com/vivo-project/VIVO/pull/3789
        2. https://github.com/vivo-project/Vitro/pull/342
        3. https://github.com/vivo-project/VIVO-languages/pull/118
• Java code formatting convention
  • spaces vs tabs
  • full reformatting PR
• The i18n redesign sprint
  
  1. Ontology
     1. https://github.com/michel-heon/vivo-i18n-onto-lang/blob/main/target/VIVO-languages/en_US/home/src/main/resources/rdf/i18n/en_US/display/firsttime/vivo_UiLabel_en_US.ttl
  2. Generator
     
     1. https://github.com/michel-heon/vivo-i18n-onto-lang
  3. Getting rid of localized ftl files
     1. About QR codes
        1. https://github.com/vivo-project/VIVO/pull/3777
        2. https://github.com/vivo-project/VIVO-languages/pull/113
        3. One committer's review is missing (Benjamin Gross)
     2. Map of science
        1. https://github.com/vivo-project/VIVO/pull/3778
        2. https://github.com/vivo-project/VIVO-languages/pull/114
        3. One review is missing (Veljko Maksimovic)
     3. Lib home page
        1. https://github.com/vivo-project/VIVO/pull/3780
        2. https://github.com/vivo-project/VIVO-languages/pull/115
        3. One committer's review is missing (Benjamin Gross)
     4. fr_CA lang files
        1. https://github.com/vivo-project/VIVO/pull/3783
        2. https://github.com/vivo-project/VIVO-languages/pull/116
        3. https://github.com/vivo-project/Vitro/pull/336
        4. https://github.com/vivo-project/Vitro-languages/pull/63
        5. One committer's review is missing (Benjamin Gross)
     5. imported fixes from fr_CA theme and individual templates
        1. https://github.com/vivo-project/VIVO/pull/3785
        2. https://github.com/vivo-project/VIVO-languages/pull/117
        3. https://github.com/vivo-project/Vitro-languages/pull/65
        4. One committer's review is missing (Brian Lowe)
           
           1. Done and merged
     6. Removing term of use
        1. https://github.com/vivo-project/Vitro/pull/335
        2. https://github.com/vivo-project/Vitro-languages/pull/62
        3. One committer's review is missing (William Welling)
           1. Done and merged
     7. Decoupling email templates and translations
        1. https://github.com/vivo-project/Vitro/pull/334
        2. https://github.com/vivo-project/Vitro-languages/pull/61
        3. One committer's review is missing (Brian Lowe)
           1. Reviewed, not yet merged
     8. Search help page
        1. https://github.com/vivo-project/Vitro/pull/333
        2. https://github.com/vivo-project/Vitro-languages/pull/60
        3. One review is missing (Benjamin Kampe)
  4. Improving the language / making ftl files universal for all languages
     1. New individual
        1. https://github.com/vivo-project/VIVO/pull/3776
        2. https://github.com/vivo-project/Vitro-languages/pull/59
        3. https://github.com/vivo-project/Vitro/pull/332
        4. One committer's review is missing (William Welling)
           1. Done and merged
     2. personHasAdviseeRelationship.ftl
        1. https://github.com/vivo-project/VIVO/pull/3779
           1. Closed
     3. addPublicationToPerson.ftl
        1. https://github.com/vivo-project/VIVO/pull/3781
           1. Closed
     4. personHasAdvisorRelationship.ftl
        1. https://github.com/vivo-project/VIVO/pull/3782
           1. Closed
     5. Language-neutral help text in autocomplete forms
        1. https://github.com/vivo-project/VIVO/pull/3784
        2. https://github.com/vivo-project/Vitro/pull/338
        3. https://github.com/vivo-project/Vitro-languages/pull/64
        4. One committer's review is missing (William Welling)
           1. Done and merged
  5. LanguageTag private-use subtag
     1. fr_FR_x_uqam
     2. https://github.com/vivo-project/Vitro/pull/330
     3. One committer's review is missing (Brian Lowe)
  6. Loading of translations from triple store
     1. https://github.com/vivo-project/Vitro/pull/340
     2. + Georgy proposal
        1. https://github.com/vivo-project/VIVO/pull/3788
        2. https://github.com/vivo-project/Vitro/pull/341
  7. Organization of ttl files
     1. Re-organization of files 
     2. https://github.com/vivo-project/Vitro/pull/331
     3. https://github.com/vivo-project/VIVO/pull/3769
     4. draft
  8. Other
     1. Removed check for "Other" special case
        1. https://github.com/vivo-project/VIVO/pull/3750
        2. https://github.com/vivo-project/Vitro/pull/328
        3. https://github.com/vivo-project/VIVO-languages/pull/112
        4. One committer's review is missing (Benjamin Gross)
     2. Small fix for non closed tag
        1. https://github.com/vivo-project/VIVO/pull/3775
        2. One review is missing (Mark Vanin)
• Dynamic API
  • Resource Generator
    • https://github.com/vivo-project/Vitro/pull/337
    • Reviewers: Dragan Ivanovic + William Welling
  • SPARQL select and construct query
    • https://github.com/vivo-project/Vitro/pull/327
    • Reviewers: Dragan Ivanovic + Benjamin Gross
  • SHACL validator
    • https://github.com/vivo-project/Vitro/pull/297
    • Reviewers: Georgy Litvinov + Brian Lowe 

Notes

Dragan: euroCRIS membership meeting announcement. It takes place two times a year. It is going on the last days of November and the first days of December. I am not sure online participation is possible. Some REST endpoints to get and ingest data could be discussed.
Subjects related to privacy pages are going to be discussed on next LG meetings.

Dragan: Michel created a PR to resolve issue related to Neptune.
I also noticed that William already provided some feedback for the request. I will try to do the same.
Michel: I don’t have special things to say. I do the correction, it works with Neptune. Before correction I checked if the bug was inside Fuseki, it doesn’t affect usage of Fuseki.
I extended it to capability map, so on one page I didn’t do the test as I don’t know if the page is fired. I added a comment in PR about that. For the third PR it is an old PR, which has some syntax for French ontology mistakes.
Dragan: I think it might need to be rebased?
Georgy: There shouldn’t be any conflicts.
Dragan: Formatting. William suggested full reformatting of codebase: spaces or tabs.
Michel: Style across files is not consistent.

Dragan: First we should decide what we use and then use standard formatting.

Michel: In DSPACE they give instructions how to change Eclipse configuration how to change indentation to spaces.
If you typing tab in Eclipse it could change tab to spaces in Eclipse if it uses spaces for indentation.
Dragan: Brian you wrote that you used 4 spaces.

Brian: Yes, in the early dev team we used 4 spaces. Using spaces over tabs is nicer.

Having a consistent standard would certainly be nice.
Dragan: I agree. It is important for us to have some instructions on how to set it up. I will look at how to document that, reformat the code base, but it should be done after we merge dynamic api and translation sprint in the next few months.

Dragan: I will try to report briefly where we are now.
There are some PRs for non-committers, it would be nice if you find some time to review that.

Brian: I will go ahead and merge email templates.
Dragan: I also noticed that Brian reviewed my PR, but I would ask him to review another PR.
And now we have two PRs for this. One PR still uses a resource bundle reader.
In Georgy’s approach all property files loaded from properties at startup of VIVO and convert properties into semantic translations.

Dragan: What PRs should we review? PR Vitro 341 or PR 340.
I can be the first reviewer of Georgy’s proposal. Let’s see who could be another one.
We should finish PR to get rid of freemarker files and then move translation from languages repos.
Once we complete review of loading translations we should create PR to move ttl data generated from Michel’s generator. After that we will be able to get rid of language repos.
Brian: PR 61 there was a request to review it once again, Michel will review that and then it will be merged.
Dragan: please test that.
Michel: I didn’t check if it works.
Dragan: I checked that it is working. The only problem could be some mistakes in translations.
Dragan: For dynamic API I started reviewing the second one and it is a really big one PR.

Georgy: We can reuse ResourceGenerator in other Vitro and VIVO code.
Dragan: I will try to review this PR as well.

Draft notes in Google Docs

...