Date

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

To join the online meeting:

  • https://lyrasis.zoom.us/j/84378615572?pwd=bGUxSjlyRTdjOGl5U1B6L0Yva3RQdz09

    Meeting ID: 843 7861 5572
    Passcode: 556561
    One tap mobile
    +16699006833,,84378615572#,,,,*556561# US (San Jose)
    +19292056099,,84378615572#,,,,*556561# US (New York)

    Dial by your location
            +1 669 900 6833 US (San Jose)
            +1 929 205 6099 US (New York)
            +1 253 215 8782 US (Tacoma)
            +1 301 715 8592 US (Washington DC)
            +1 312 626 6799 US (Chicago)
            +1 346 248 7799 US (Houston)
            877 853 5257 US Toll-free
            888 475 4499 US Toll-free
    Meeting ID: 843 7861 5572
    Passcode: 556561
    Find your local number: https://lyrasis.zoom.us/u/kerqtGDrJ4

Slack

Attendees

(star)  Indicating note-taker

  1. Dragan Ivanovic 
  2. Georgy Litvinov (star)
  3. Brian Lowe 
  4. Michel Héon 
  5. Mark Vanin  
  6. Huda Khan
  7. Andreas Czerniak
  8. Benjamin Gross 
  9. Veljko Maksimovic     
  10.  Christian Hauschke    

Agenda

Notes

Dragan: euroCRIS membership meeting announcement. It takes place two times a year. It is going on the last days of November and the first days of December. I am not sure online participation is possible. Some REST endpoints to get and ingest data could be discussed.
Subjects related to privacy pages are going to be discussed on next LG meetings.

Dragan: Michel created a PR to resolve issue related to Neptune.
I also noticed that William already provided some feedback for the request. I will try to do the same.
Michel: I don’t have special things to say. I do the correction, it works with Neptune. Before correction I checked if the bug was inside Fuseki, it doesn’t affect usage of Fuseki.
I extended it to capability map, so on one page I didn’t do the test as I don’t know if the page is fired. I added a comment in PR about that. For the third PR it is an old PR, which has some syntax for French ontology mistakes.
Dragan: I think it might need to be rebased?
Georgy: There shouldn’t be any conflicts.
Dragan: Formatting. William suggested full reformatting of codebase: spaces or tabs.
Michel: Style across files is not consistent.

Dragan: First we should decide what we use and then use standard formatting.

Michel: In DSPACE they give instructions how to change Eclipse configuration how to change indentation to spaces.
If you typing tab in Eclipse it could change tab to spaces in Eclipse if it uses spaces for indentation.
Dragan: Brian you wrote that you used 4 spaces.

Brian: Yes, in the early dev team we used 4 spaces. Using spaces over tabs is nicer.

Having a consistent standard would certainly be nice.
Dragan: I agree. It is important for us to have some instructions on how to set it up. I will look at how to document that, reformat the code base, but it should be done after we merge dynamic api and translation sprint in the next few months.

Dragan: I will try to report briefly where we are now.
There are some PRs for non-committers, it would be nice if you find some time to review that.

Brian: I will go ahead and merge email templates.
Dragan: I also noticed that Brian reviewed my PR, but I would ask him to review another PR.
And now we have two PRs for this. One PR still uses a resource bundle reader.
In Georgy’s approach all property files loaded from properties at startup of VIVO and convert properties into semantic translations.

Dragan: What PRs should we review? PR Vitro 341 or PR 340.
I can be the first reviewer of Georgy’s proposal. Let’s see who could be another one.
We should finish PR to get rid of freemarker files and then move translation from languages repos.
Once we complete review of loading translations we should create PR to move ttl data generated from Michel’s generator. After that we will be able to get rid of language repos.
Brian: PR 61 there was a request to review it once again, Michel will review that and then it will be merged.
Dragan: please test that.
Michel: I didn’t check if it works.
Dragan: I checked that it is working. The only problem could be some mistakes in translations.
Dragan: For dynamic API I started reviewing the second one and it is a really big one PR.

Georgy: We can reuse ResourceGenerator in other Vitro and VIVO code.
Dragan: I will try to review this PR as well.

Draft notes in Google Docs

Task List

  • All to review PRs assigned to them

Previous Tasks 

  • No labels

All content on the LYRASIS Wiki is licensed under the CC BY (Attribution) license, unless otherwise noted.