Versions Compared

Old Version 2

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Ben Bosman

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

 at 16:00 UTC (11:00am EDT)

Location:

Join from PC, Mac, Linux, iOS or Android: https://lyrasis.zoom.us/my/dspace  (Meeting ID: 502 527 3040)

Attendees

Actual attendee list will be updated after meeting.


Warning

As of Dec 17, 2019, the DSpace 7 Entities Working Group (2018-19) is on hiatus and has merged with the DSpace 7 Working Group (2016-2023).  This page represents the 178881628 of the final meeting.  The "178881628" and "178881628" sections below will be kept up-to-date to allow volunteers to continue reviewing/testing any remaining Entities or OpenAIREv4 PRs.  For ongoing DSpace 7.0 development efforts, please see the DSpace Release 7.0 Status and DSpace 7 Working Group (2016-2023).

Location:

Join from PC, Mac, Linux, iOS or Android: https://lyrasis.zoom.us/my/dspace  (Meeting ID: 502 527 3040)

Attendees

Actual attendee list will be updated after meeting.

Agenda

#TimeItemInformationWho
15minsQuick Reminder

Final DSpace 7 Entities WG meeting :  With holidays the next two weeks (24th and 31st), this will be the final DSpace 7 Entities Working Group meeting of 2019. As of Jan 1, this Working Group will disband & work as part of the larger DSpace 7 Working Group (2016-2023).

  • For any still open PRs, PR reviews can continue to happen.  As of Jan 1, Entities PRs will be lower priority (unless they fix a major bug). But, they can still be reviewed by volunteers and/or Tim (after high priority PRs are reviewed, obviously).

25mins

Agenda

Any additional topics to today's agenda?

All
315minsUpdates on OpenAIREv4

Any updates to discuss this week?

Work based on:

All
415minsWrap-up and Assigning tasks
  • Assign tasks / PRs to review (as needed)
  • No more meetings on the schedule for the DSpace 7 Entities Working Group.  This Working Group will be on hiatus until other major Entities work becomes a higher priority. That said, volunteers are welcome to continue with reviewing, etc and coordinate via the existing #entities-wg channel in Slack.

...

Panel
titleLegend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others). These are tasks with lots of dependencies

(error) = review done, changes were requested or bugs found.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

Status
colourBlue
title1 approval
 = pull request only requires a single approval to merge.  This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.  

Tickets to Resolve

PRs Needing Review

  1. (REST Contract) Entity type small changes ) Entities Configure search configurations matching name https://github.com/DSpace/Rest7ContractDSpace/pull/952667 (Tim Donohue,(tick) Paulo Graça, NEEDS SECOND REVIEWER)
  2. (REST) Creating a workspace item from an external source NEW) (REST) Metadata PATCH when mixing plain text and relationship https://github.com/DSpace/DSpace/pull/26142691 (Tim Donohue, Paulo Graça - (warning))
  3. (NEW) (REST) Get entity type performance improvement  Removed the RelationshipTypeId from Relationship endpoints https://github.com/DSpace/DSpace/pull/26152745 (NEEDS REVIEWERS)
  4. (NEW) (REST) Entities related to Entities of the same type  StatuscolourBluetitle1 approval (Tim Donohue (tick), NEEDS SECOND REVIEWER)(REST) DS-4401 Enforce relational place ordering when place direction is known https://github.com/DSpace/DSpace/pull/26172746  StatuscolourBluetitle1 approval (Ben Bosman(tick), NEEDS SECOND REVIEWER)(NEEDS REVIEWERS)
  5. (Angular) Combining relationships and metadata during submission (REST) Entities submission config https://github.com/DSpace/DSpacedspace-angular/pull/2618541 (Tim Donohue, Paulo GraçaPaulo Graça , NEEDS SECOND REVIEWER) (12 hours)
  6. (Angular) Keep virtual metadata on relationship delete NEW)(Angular) Create relationships as an admin in edit item [WIP] https://github.com/DSpace/dspace-angular/pull/530545  (Paulo Graça - feedback added, Tim Donohue - feedback added)(Angular) Create relationships during the submission NEEDS REVIEWERS ONCE DEPENDENCIES ARE MERGED) (16 hours left - week of Jan 6)
    1. Dependent on #530 (merged)
  7. (COMING SOON) (OpenAIRE4) OpenAIRE API import of entities/metadata (In progress development by Dimitris Pierrakos)

PRs Merged

  1. (tick) (REST Contract) Entity type small changes httpshttps://github.com/DSpace/dspace-angularRest7Contract/pull/53195
  2. (tick) (Paulo Graça - it's Ok, but REST) DS-4401 Enforce relational place ordering when place direction is known https://github.com/DSpace/DSpace/pull/2617
  3. (tick) (REST) Get entity type performance improvement  still is WIP, Tim Donohue - early review, one bug reported)(Angular) Item page entities improvements https://github.com/DSpace/dspace-angularDSpace/pull/532 (Paulo Graça - feedback added, (tick)Tim Donohue)
    1. sample screenshots: pr-532.pdf
    (Angular) Virtual metadata on item delete 2615
  4. (tick) (REST) Creating a workspace item from an external source https://github.com/DSpace/DSpace/pull/2614
  5. (tick) (REST) Entities submission config https://github.com/DSpace/dspace-angularDSpace/pull/533 ( Paulo Graça - feedback added , Tim Donohue )
    1. sample screenshots:  pr-533.pdf
    2. Dependent on #530 (see above)
    (Angular) Reordering related entities in the submission 2618
  6. (tick) (REST) Default Entities relationship types used for the demos https://github.com/DSpace/dspace-angularDSpace/pull/5342622
  7. (tick) (Paulo Graça, Tim Donohue)REST) EntityType by label endpoint and integration tests https://github.com/DSpace/DSpace/pull/2628
  8. (tick) (REST) relationship type rest controller bug fix 
    1. Dependent on #531 (see above)
    (Angular) Lookup relations - Search external sources https://github.com/DSpace/dspace-angularDSpace/pull/539 (Tim Donohue, Paulo Graça)
    1. Dependent on #531 (see above)
    2641
  9. (tick) (Angular) Item page entities improvements (Angular) Convert external source to entity https://github.com/DSpace/dspace-angular/pull/540532
  10. (tick) (NEEDS REVIEWERS ONCE READY)
    1. Dependent on #539 (see above)
    (Angular) Combining relationships and metadata during submission OpenAIRE4) OpenAIRE 4 submission forms and virtual metadata https://github.com/DSpace/dspace-angular/DSpace/pull/541 (NEEDS REVIEWERS ONCE READY)
    1. Dependent on #534 (see above)
    (OpenAIRE4) OpenAIRE 4 submission forms and 2608
  11. (tick)  virtual metadata (OpenAIRE4) OpenAIRE4 adding missing field person.identifier https://github.com/DSpace/DSpace/pull/26082621
  12. (tick) (Dimitris Pierrakos, Ben Bosman, Tim Donohue - feedback added)(OpenAIRE4) OpenAIRE4 oai_openaire metadata format support [WIP]funding agency missing translation https://github.com/DSpace/DSpacedspace-angular/pull/2592 (Dimitris Pierrakos, Tim Donohue, Ben Bosman)

PRs Merged this week!

  1. (tick) First PR merged goes here

Task List

This task list has been updated as of our meeting on Oct 22, 2019.  The tasks are numbered for easy reference, but are not necessarily listed in priority order.  During this meeting we worked to re-summarize current work status so that we can align this task list with the DSpace 7 Estimation Process (and as such, estimate any we feel should be considered for 7.0 release).  NOTE: Keep in mind, just because a task is listed here does NOT guarantee it will be completed for DSpace 7.  Some of these tasks may need to be delayed for a future release.

Panel
titleLegend for status icons

(tick) = task considered "completed" (unless bugs or issues are later found)

(warning) = task is incomplete or has further work to be done.

(question) = task that may be delayed or postponed for after 7.0.

  1. 542
  2. (tick) (blue star) (Angular) Create relationships during the submission https://github.com/DSpace/dspace-angular/pull/531
  3. (tick) (blue star) (OpenAIRE4) OpenAIRE4 oai_openaire metadata format support https://github.com/DSpace/DSpace/pull/2592
  4. (tick) (Angular) Lookup relations - Search external sources https://github.com/DSpace/dspace-angular/pull/539
  5. (tick) (Angular) Reordering related entities in the submission https://github.com/DSpace/dspace-angular/pull/534
  6. (tick) (Angular) Convert external source to entity https://github.com/DSpace/dspace-angular/pull/540
  7. (tick) (Angular) Keep virtual metadata on relationship delete https://github.com/DSpace/dspace-angular/pull/530 
  8. (tick) (Angular) Virtual metadata on item delete (tick) Metadata schemas for Entity types (DS-4223). REST: https://github.com/DSpace/DSpace/pull/2443 , Angular: https://github.com/DSpace/dspace-angular/pull/420
  9. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.wjaqg235p53r
    10. 533

Task List

This task list has been updated as of our meeting TODAY.  The tasks are numbered for easy reference, but are not necessarily listed in priority order.  During this meeting we worked to re-summarize current work status so that we can align this task list with the DSpace 7 Estimation Process (and as such, estimate any we feel should be considered for 7.0 release).  NOTE: Keep in mind, just because a task is listed here does NOT guarantee it will be completed for DSpace 7.  Some of these tasks may need to be delayed for a future release.

Panel
titleLegend for status icons

(tick) = task considered "completed" (unless bugs or issues are later found)

(warning) = task is incomplete or has further work to be done.

(question) = task that may be delayed or postponed for after 7.0.

  1. (tick) Metadata schemas for Entity types (DS-4223). 
    1. REST: 
  2. (warning) (Minor refactor) Decide which metadata field should be used to store Entity Type (DS-4184).  Currently, it is stored in "relationship.type". (DEEMED LOWER PRIORITY, but "nice to have" for 7.0 if possible?)
  3. (tick) Creating Relations (between Entities) with CSV Batch Import 
    1. REST: https://github.com/DSpace/DSpace/pull/2269 and https://github.com/DSpace/DSpace/pull/2471 and 2443 , Angular: https://github.com/DSpace/DSpacedspace-angular/pull/2522420
    2. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.df1z7jh9mcc
  4. (tick) Permissions on Relations (between Entities)
    1. Discussed on Aug 6 
    2. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.y6qarjnylexl
    1. wjaqg235p53r
  6. (warning) (Minor refactor) Decide which metadata field should be used to store Entity Type (DS-4184).  Currently, it is stored in "relationship.type". (DEEMED LOWER PRIORITY, but "nice to have" for 7.0 if possible?)
  7. (tick) Creating Relations (between Entities) with CSV Batch Import 
    1. REST:
    Deleting Entities that have existing relations
    1. (tick) Deletion action itself:REST Contract: https://github.com/DSpace/DSpace/Rest7Contract/blob/master/relationships.md#deleting-a-relationship , REST: pull/2269 and https://github.com/DSpace/DSpace/pull/2471 and https://github.com/DSpace/DSpace/pull/2332 , Angular/2522
    2. Early Docs / Notes: https://githubdocs.google.com/DSpacedocument/dspace-angular/pull/402d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.df1z7jh9mcc
  8. (tick) Permissions on Relations (between Entities)
    1. Discussed on Aug 6 
    2. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.c62y8iqnvlury6qarjnylexl
  9. (tick) Deleting Entities that have existing relations
    1. (tick) Deletion action itself:
      1. REST
      (warning) Copy virtual metadata from deleted entity to related entity
      1. (tick) REST Contract: https://github.com/DSpace/Rest7Contract/blob/pull/78(tick) REST implmaster/relationships.md#deleting-a-relationship , REST: https://github.com/DSpace/DSpace/pull/2577(warning) Angular Impl (under review)2332 , Angular: https://github.com/DSpace/dspace-angular/pull/530 and https://github.com/DSpace/dspace-angular/pull/533
    (tick) Dynamic display of Relations
      1. 402
      1. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.
      pm34t6u1djdf
    3. (warning) (DELAYED) Completed, but may require usability improvements (NEEDS DISCUSSION - may be delayed for v7.1)
    Submission Integration Tasks
      1. c62y8iqnvlur
    2. Copy virtual metadata from deleted entity to related entity
      1. (tick) REST Contract: https://github.com/DSpace/Rest7Contract/pull/78
      2. (tick) REST impl
    3. (tick) Creating new Entities using Submission Forms
      1. REST: https://github.com/DSpace/DSpace/pull/2443Early Docs / Notes: 2577
      2. (tick)Angular Impl : https://docsgithub.google.com/documentDSpace/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.9aixusqzgcnp
      (warning) Creating relations between two Entities during Submission process
      1. (tick) REST Contract: dspace-angular/pull/530 and https://github.com/DSpace/Rest7Contractdspace-angular/pull/64 ,533
  10. (tick) Dynamic display of Relations
    1. Early Docs / Notes:  REST Impl: https://githubdocs.google.com/DSpacedocument/DSpaced/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.pm34t6u1djdf
    2. (tick) Completedpull/2472(warning) Angular Impl (under review): https://github.com/DSpace/dspace-angular/pull/517
  11. (tick) Submission Integration Tasks
    1. (tick) Creating new Entities using Submission Forms
      1. REST: 531 and https://github.com/DSpace/dspace-angularDSpace/pull/5342443
      2. Early Docs / Notes: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.9aixusqzgcnp
    2. (tick) Creating relations between two Entities during Submission process(warning) Search External Sources (includes ORCID integration with Entities)
      1. (tick) REST Contract: https://github.com/DSpace/Rest7Contract/pull/7464 ,
      2. (tick) REST Impl:  https://github.com/DSpace/DSpace/pull/25602472(warning)
      3. (tick) Angular Impl (under review): https://github.com/DSpace/dspace-angular/pull/539 (NOTE: This PR is smaller than it seems, as it includes all the code in the larger PR#531)
      (warning) Convert External Sources to an Entity
      1. If an Admin:(tick) REST Contract: 531 and https://github.com/DSpace/Rest7Contractdspace-angular/pull/82(tick) REST Impl534
      2. Early Docs / Notes: https://githubdocs.google.com/DSpacedocument/DSpaced/pull/25901X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.9aixusqzgcnp
    3. (tick) Search External Sources (includes ORCID integration with Entities)
      1. (tick) REST Contract: (warning) Angular Impl (under review): https://github.com/DSpace/dspace-angularRest7Contract/pull/540 (NOTE: This PR is smaller than it seems, as it includes all the code in the larger  PR#531)74 
      2. (tick) REST Impl: https://If a Submitter (Feature is NOT specific to Entities, as this is simply porting the "Live Import" framework of DSpace 6.x)(tick) REST Contract under review: https://github.com/DSpace/Rest7ContractDSpace/pull/832560
      3. (warning) REST Impl (under review)(tick) Angular Impl: https://github.com/DSpace/DSpacedspace-angular/pull/2614
    Name Variants
      1. 539
    2. (tick)Convert External Sources to an Entity
    3. (warning) Create name variants in submission
      1. If an Admin:
        1. (tick) REST
        Impl
        1. Contract: https://github.com/DSpace/
        DSpace
        1. Rest7Contract/pull/
        2561
        1. 82
        (warning) Angular Impl (under review) - this is included as part of 
        1. (tick) REST Impl: https://github.com/DSpace/
        dspace-angular
        1. DSpace/pull/
        531
    4. (tick) Display name variants on Item pages (Angular)
    (warning) OpenAIRE v4 support (using Entities)
        1. 2590
        2. (tick) Angular Impl
    2. (tick) Configuration of Entities needed for OpenAIRE v4
        1. : https://github.com/DSpace/
      DSpace
        1. dspace-angular/pull/
      2575(tick) Configuration of Metadata fields/schemas needed for OpenAIRE v4
        1. 540
      2. If a Submitter (Feature is NOT specific to Entities, as this is simply porting the "Live Import" framework of DSpace 6.x)
        1. (tick) REST Contract: https://github.com/DSpace/
      DSpace
        1. Rest7Contract/pull/
      2576(warning) Configuration of Submission Input Forms for OpenAIRE v4 (under review)
        1. 83
        2. (tick) REST Impl: https://github.com/DSpace/DSpace/pull/
      2608(warning) Configuration of OAI-PMH for OpenAIRE v4 (under review): 
        1. 2614
        2. (tick) Angular Impl: https://github.com/DSpace/dspace-angular/pull/540
  12. (tick) Name Variants
    1. (tick) Create name variants in submission
      1. (tick) REST Impl: https://github.com/DSpace/DSpace/pull/
      2592
  13. (warning) How to display related items on an Item page if that related item is still in workflow approval
    1. Simply display the related item as plain text metadata (until workflow approval completes).
      1. 2561
      2. (tick) Angular Impl - this is included as part of https://github.com/DSpace/dspace-angular/pull/531
    2. (tick) Display name variants on Item pages (Angular)
  15. OpenAIRE v4 support (using Entities)
    1. (tick) Configuration of Entities needed for OpenAIRE v4
    (warning) Edit Item page integration
    1. How to display relationships on "edit metadata" tab in UI.  How to add relationships on "relationships" tab in UI.
    2. Angular UI Mockups discussed/approved on Nov 5 and Nov 12.
    3. (tick) Angular relationships tab: https://github.com/DSpace/dspace-angularDSpace/pull/517
    (question) (DELAYED) Relations in AIP Backup & Restore
    1. 2575
    2. (tick) Configuration of Metadata fields/schemas needed for OpenAIRE v4
    3. Discussed on Oct 15
    4. Proposal: https://docsgithub.google.com/documentDSpace/dDSpace/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.qi8bp6kog7yi
    (question) (DELAYED) Creating Relations in SAF Import (might be postponed for a future release)
    1. pull/2576
    2. (tick) Configuration of Submission Input Forms for OpenAIRE v4: https://github.com/DSpace/DSpace/pull/2608
    3. (tick) Configuration of OAI-PMH for OpenAIRE v4
    4. Requires AIP Backup & Restore
    5. Proposal: https://docs.googlegithub.com/documentDSpace/dDSpace/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.n8ktliibe7kj
  16. (question) (DELAYED) SWORD integration (might be postponed for a future release)
    1. Requires AIP Backup & Restore, as SWORD uses the same crosswalks / format as AIP.
    2. Proposal: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.xufwyy1ep8h2
  17. (question) (DELAYED) Best Practices around Entities in Collections (NOT: this may just be early documentation).  We've suggested in the Preview Release to structure Collections based on Entity Type (Person Collection, Projects Collection, etc).  We should better document and formalize these best practices. 
    1. Should we eventually consider hiding these Collections which only serve to store Entity Types?

...

    1. pull/2592
    2. (warning) Import entities/metadata from OpenAIRE API (using Live Import feature): https://github.com/DSpace/DSpace/pull/2655
  2. (tick) How to display related items on an Item page if that related item is still in workflow approval
    1. (tick) Simply display the related item as plain text metadata (until workflow approval completes).
  3. Edit Item page integration
    1. How to display relationships on "edit metadata" tab in UI.  How to add relationships on "relationships" tab in UI.
    2. Angular UI Mockups discussed/approved on Nov 5 and Nov 12.
    3. (tick) Angular relationships tab: https://github.com/DSpace/dspace-angular/pull/517
    4. (warning) Create relationships as an admin in edit item (under review): https://github.com/DSpace/dspace-angular/pull/545
  4. (question) (DELAYED for 7.1 or later) Relations in AIP Backup & Restore
    1. Discussed on Oct 15
    2. Proposal: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.qi8bp6kog7yi
  5. (question) (DELAYED for 7.1 or later) Creating Relations in SAF Import (might be postponed for a future release)
    1. Requires AIP Backup & Restore
    2. Proposal: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.n8ktliibe7kj
  6. (question) (DELAYED for 7.1 or later) SWORD integration (might be postponed for a future release)
    1. Requires AIP Backup & Restore, as SWORD uses the same crosswalks / format as AIP.
    2. Proposal: https://docs.google.com/document/d/1X0XsppZYOtPtbmq7yXwmu7FbMAfLxxOCONbw0_rl7jY/edit#heading=h.xufwyy1ep8h2
  7. (question) (DELAYED for 7.1 or later) Best Practices around Entities in Collections (NOT: this may just be early documentation).  We've suggested in the Preview Release to structure Collections based on Entity Type (Person Collection, Projects Collection, etc).  We should better document and formalize these best practices. 
    1. Should we eventually consider hiding these Collections which only serve to store Entity Types?

Notes

  • Last meeting of the DSpace 7 Entities Working Group (2018-19) (on indefinite hiatus).  Our working group is considered disbanded unless we find a reason to meet later in the year (if any remaining Entities effort is needed later in 2020)
    • REST API effort (contract & implementation) for Entities is COMPLETE!
    • There are still some outstanding Angular and OpenAIREv4 PRs (see list of "178881628" above), but NO MORE FEATURE PRs are expected
      • One exception we realized is that Dimitris from OpenAIRE is working on a PR to import metadata from the OpenAIRE API (using the existing "Live Import" framework in DSpace 7).  This PR is currently listed as "COMING SOON" above, and should be created by the end of 2019. It can be reviewed by volunteers in 2020.
  • Next Steps for still open PRs
    • These are considered low priority to review/test in 2020.  The main DSpace 7 Working Group (2016-2023) will be working in organized sprints to finalize the DSpace 7.0 release, so their priorities will be on general DSpace 7.0 features.
      • That said, volunteer developers can continue to review Entities PRs as they see fit.  Tim will also review & test them when his time allows (but only after any high priority DSpace 7 PRs are reviewed/tested first)
    • As Working Group is no longer meeting, any Entities PR discussion should move to #entities-wg in Slack or GitHub. 
    • If a small group wants to talk in more detail about a specific PR, the DSpace Meeting Room is always available for an ad hoc PR meeting.  These can be organized or requested via Slack or Github.
  • As the Working Group is not meeting any further, the "178881628" list & "178881628" sections above should be kept updated to let volunteers know the current status of any remaining Entities PRs.
  • Thanks again to all who participated in the DSpace 7 Entities Working Group (2018-19) !  It's been wonderful seeing the passion & energy for both Entities & OpenAIREv4 in DSpace 7.  Please consider joining our DSpace 7 Working Group (2016-2023) in 2020 (if you have not already) to help us complete the 7.0 release!