Date

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

Attendees

(star)  Indicating note-taker

  1. Georgy Litvinov 
  2. Dragan Ivanovic 
  3. William Welling 
  4. Benjamin Gross 

Agenda

  1. Publishing the VIVO 1.13.0 release 
    1. Publishing a release candidate 2
      1. done
    2. Testing the release candidate
      1. Wiki page - Release Testing - 1.13.0 
        1. deployment of VIVO and Vitro
          1. mvn clean install
        2. GoogleForms
          1. Standard tests - https://forms.gle/cqk3oK7UmJpDWGYt8
          2. Special focus on the new features - https://docs.google.com/forms/d/19FMslvvSzg_FK-Wmxg4t7EOP2UDft4FVdQvM4-2IO50/edit?usp=sharing
          3. Advanced tests - https://forms.gle/ZZLeVdBuDFMEMTGM
        3. https://vivo.tib.eu/vivo113rc
    3. VIVO 1.13.0 Technical Documentation
      1. Wiki space - VIVO 1.13.x Documentation
      2. Adding of technical documentation for:
        1. Deletion of individuals 
        2. Installing VIVO
      3.  Release Notes
        1. done
    4. Publishing VIVO 1.13.0 
  2. Improvement of GitHub code management 
    1. bug report template
      1. VIVO
      2. DSpace
    2. feature request template
      1. VIVO
      2. DSpace
    3. task definition template
      1. for upgrading dependencies, mitigation of security vulnerability
      2. is that a good practice?
        1. https://github.com/golang/go/issues/new/choose
        2. https://github.com/microsoft/repo-templates/blob/main/shared/SECURITY.md
        3. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
        4. https://github.com/DSpace/DSpace/issues/new/choose
    4. pull request template
      1. VIVO
      2. DSpace
    5. GitHub actions
      1. list of actions
        1. VIVO
        2. DSpace
      2. build.yml
        1. VIVO
        2. DSpace
          1. codecov
            1. alternatives - codeclimate, etc.
          2. separation of unit and integration tests
      3. docker.yml
        1. VIVO
        2. DSpace
      4. label merge conflicts yml
        1. DSpace
      5. adding new issue to project board yml
        1. DSpace
          1. Issues should be added for instance in a dedicated VIVO backlogs project board for triage (similarly as DSpace Backlogs - https://github.com/orgs/DSpace/projects)
      6. codeQL analysis
        1. VIVO
        2. continues security analysis - LGTM
          1. https://lgtm.com/projects/g/vivo-project/Vitro/?mode=list
    6. labels
      1. list of labels
        1. VIVO
        2. DSpace
      2. assignment of labels to issues
        1. VIVO
        2. DSpace
  3. Decoupling build and installation process 
    1. https://github.com/vivo-project/VIVO/issues/3034

Notes

  • Proxy editing: Issue with assigning profiles to account for editing, but account can edit everything
    • Brian: Check role for username.  Since it’s “editor”, that means that account can edit everything.  Set to “self-editor” to turn off overall editing privileges and then check proxy editing
    • Works as intended
  • Dragan: Besides that, didn’t notice any issues.  Performance also looks ok.
  • Situation for being able to edit relationships to others
    • Instead of being set to root, appropriate to set that at editor/self-editor level
    • Update level: usually editor or self-editor instead of root
    • Publish level: should be public as usual
    • Dragan: Will try to make a pull request
  • Benjamin (from chat):
  • Language search issue discussed in dev call earlier
    • Brian: Issue is with dynamically adding language with the necessary analyzers
      • For different project, had three different document modifiers - processing for each language.  Populate fields other than the default used for sorting - three different fields for languages.  Then piped in the field based on locale.  
      • Appears to be an important issue prior to release.  So good with intermediate solution with dynamic fields.  Maybe language specific analyzers in next release. 

Draft notes on Google Drive

Actions

  • Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
  • Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
  • Georgy Litvinov will investigate the problem of searching instances with multilingual properties

Previous actions 

  • No labels

All content on the LYRASIS Wiki is licensed under the CC BY (Attribution) license, unless otherwise noted.