Skip to end of metadata
Go to start of metadata

Date

Call-in Information

Time: 11:00 am, Eastern Time (New York, GMT-04:00)

To join the online meeting:

Slack

Attendees

(star)  Indicating note-taker

  1. Rachid Belkouch
  2. William Welling 
  3. Brian Lowe (star)
  4. Andrew Woods
  5. Don Elsborg
  6. Alexander (Sacha) Jerabek
  7. Huda Khan

Agenda

  1. 2020-08 - i18n Editing Sprint - working towards a merge to 'master'
    1. Decoupling dependencies on VitroRequest
      1. VIVO-1837 - Getting issue details... STATUS
    2. Need a close review of all files that have been touched in both 'master' and the 'sprint-i18n' branches
      1. VIVO-1907 - Getting issue details... STATUS
    3. Needs debugging
      1. VIVO-1863 - Getting issue details... STATUS
    4. Three unassigned bugs
    5. Two unassigned documentation tickets
  2. VIVO 1.12.0 release timeframe

Future topics

  1. Vitro JMS messaging approaches - redux
    1. Which architectural pattern should we take?
    2. What should the body of the messages be?
  2. Renaming of 'master' branch? (ZDNet, BBC)
    1. Guidance from GitHub 
    2. DSpace has done it
    3. Fedora has done it
    4. Samvera is doing it
  3. Incremental development initiatives
    1. VIVO-1688 - Getting issue details... STATUS
    2. VIVO-1751 - Getting issue details... STATUS
    3. Integration test opportunities with the switch to TDB - requires startup/shutdown of external Solr ..via Maven
      1. VIVO-1752 - Getting issue details... STATUS

Tickets

  1. Status of In-Review tickets

    T Key Summary Assignee Reporter P Status Resolution Created Updated Due
    Loading...
    Refresh

Notes 

Attendees

  1. Andrew Woods
  2. William Welling
  3. Rachid Belkouch
  4. Sacha Jerabek
  5. Don Elsborg
  6. Huda Khan
  7. Brian Lowe

Notes


  1. i18n sprint
  • Three unassigned bugs need to get looked at.
  • 1a. VIVO-1837: looks like there is a clear path forward
    • Andrew wonders whether there is specific functionality (such as frontend decoupling) that will help surface and address some of these issues.
    • William thinks a new dependency injection approach is required first in order to avoid perpetuating bad patterns on both sides of the decoupling.
    • Huda has a good sense of where the cleavage points are for surfacing data to the API.
    • Raises issues of setters/getters where things are not always set and you don’t know when to expect null.
    • Brian will create an issue to review the newly-added RDFService.get/setVitroRequest() methods and ideally eliminate them.
    • Other longer-term issues to address similar problems with tight coupling / undesirable references to other objects elsewhere in the codebase:
  • 1b. Need to examine files that have been touched by both the sprint branch and recent core development to make sure that core changes have not been lost/reverted.
  • 1c. Might be a matter of making sure that the initial RDF file loader recognizes the .nt (N-Triples) file extension and doesn’t try to parse as RDF/XML.
  • Sacha: need to figure out how to address backlog of documentation tasks.


Git process (William)

  • Propose two sprint branches: base branch (unchanging) plus staging branch.  Features are developed off of the base branch. Conflicts get resolved in staging.
    • Most important benefit is feature isolation. Conflicts should be resolved at the end of the feature instead of all throughout feature development.
    • Also avoids race to get into staging.
  • Current sprint-i18n branch is effectively staging, but we don’t all start developing new features from the same point.  Makes it hard to build pull requests and test them in isolation because there isn’t an agreed-upon base branch.
  • Something for next sprint, not to try to change now.
  • If conflict occurs when merging to staging, create new feature-merge branch to resolve the conflicts without polluting the feature branch.
  • Integrating of all features / conflict resolution occurs at end of sprint.
  • Major refactoring happens just prior to sprint so that the base branch includes the refactoring.
  • Cleanup happens at end as well.


Spring post-meeting 11 AM EDT Monday 24 Aug.

Draft notes in Google-Doc 

Actions

  •  



  • No labels