Date
Call-in Information
Time: 11:00 am, Eastern Time (New York, GMT-04:00)
To join the online meeting:
- Go to: https://duraspace.zoom.us/j/823948749
- Or iPhone one-tap :
- US: +14086380968,,823948749# or +16468769923,,823948749#
- Or Telephone:
- Dial(for higher quality, dial a number based on your current location):
- US: +1 408 638 0968 or +1 646 876 9923 or +1 669 900 6833
- Meeting ID: 823 948 749
- International numbers available: https://duraspace.zoom.us/zoomconference?m=Qy8de-kt6W4fMMDQCAV_3qfH1W-lxAo5
Slack
- https://vivo-project.slack.com
- Self-register at: https://goo.gl/forms/JxQFkut4TYj4Ehww1
- Self-register at: https://goo.gl/forms/JxQFkut4TYj4Ehww1
Development Process
Attendees
Indicating note-taker
Agenda
Update on Advanced Role Management 3-day fiesta
Done?
In-Review
1.10
bugs (1.10.1?)
Plans for a 1.10.1 patch release
- In Limbo
- Update from Ontology group? - Add Handle Support in VIVO?
- Ontology group has a proposal regarding identifiers. See document
- Discuss pull request https://github.com/vivo-project/VIVO/pull/94 to create weblinks for data properties that have a range of type URL.
Notes
Is the documentation task assigned to Brian Lowe done? Mike: Need to review the ticket
Lots of open tickets/under review. Q: Which of these issues can we realistically move forward/ideally in shorter term? Which issues need help?
Ralph: Want to merge last of Solr/ElasticSearch updates into sprint branch so we can get that into develop
Ralph: RedHat was bought by IBM, that will have some impact at some point on something.
Travis/CI: only does Ubuntu/Linux (do on other OSes but don’t do other versions of Linux). Can now also do this on Windows
Andrew: What was the nature of the Travis/CI conversation?
Ralph: Discussing older versions of linux no longer supporting cglib which lead to travis/CI discussion
Mike: Speaking with Julia. Leadership group meeting November 9th, with a suggestion for a sprint in December. Mike suggesting a training grant for new people. Potential participants: Italy, Duke University. Possibly not a 2 week sprint (more likely 1).
Ralph: looking for supervising effort/work with new people? Usually less busy in December and will see if can help
Mike: Short sprint to orient new people and knocking off simpler issues
Andrew: Great idea for different reasons. Participants from institutions represented on leadership group so useful to get their participation into process
Mike: Dec 3 probably better than week of 10th, but depends on availability
Andrew: Ralph’s local customizations to templates and making VIVO responsive - seemed like there was some work that could show up as a pull request that could be merged in.
Ralph: Posted initial version to community, and have another version to be pushed out to community. Want to get some more feedback and then tie it back to pull request.
Currently taking out UAB-specific portions and putting in placeholders to make it more generally useful
Have ticket but will create pull request
Andrew: There was a fiesta recently (advanced role management)
Quite a large change: multiple files
Some specific code review comments in the Vitro and VIVO pull requests and some higher level functionality comments
Many comments have had responses but others await review/further comments
Mike: Functionality improving VIVO?
Jim: Graham has been working to move the advanced role management forward and much of that works but certain components do not work as intended while some functionality has been broken
Public permissions issues: behaves as expected but generating additional triples that are then disregarded.
Also some functionality that was silently broken in 1.10 but then was fixed by this pull request (e.g. don’t show these fields for certain roles/public but those fields would be displayed anyway)
Relates to testing: Selenium, etc. and then some of this functionality does not have unit tests
Andrew: TIB has been using this code/work
Jim: Don’t think it was this particular pull request (but don’t know for certain)
Mike: Suggest we accept this work into its own branch
Andrew: Will create VIVO and Vitro branches for this work
Andrew: Externalizing search functionality tickets
4 tickets
Some have been merged into sprint branch and some have not
Ralph: Wants to merge into sprint branch and test.
Andrew: Agreed
Andrew: Elasticsearch vs Solr
Inclination: small steps are good. Externalizing Solr helps us move in the direction we want to go
Sprint branch has mix of Solr and Elasticsearch. Will need to cherry pick functionality out if don’t plan on integrating Elasticsearch
Benjamin would like Elastic Search functionality to be in there so reviewing/continuing to review that would help
From chat “change I had to make to Elastic, needed to remove line 166 in Query Converter which was causing only ALLTEXT being searched, so labels weren't searchable for example. https://github.com/vivo-project/Vitro/blob/sprint-search/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/elasticsearch/QueryConverter.java#L166”
VIVO-1617: bug that was identified and pull request seems to fix it.
Good to get it reviewed and merged
3 functional files and 1 test file
Relates to internationalization.
Kitio: will help review
Andrew: Need one more person to review - that would help
Andrew: any other tickets that are not moving forward?
HTML tagging pull request would remove HTML WYSIWYG for any data property until a second pull request with the annotation/property that needs to be defined on a property to turn on WYSIWYG.
Graham mentions this seems to go against internationalization concerns
Suggestion: Declare value as language string so they can have language tags, ontology wouldn’t define it is a language/string. Annotation property would enable associating editor with data property. Can we do that already or is that a new idea?
Jim: Display is a matter of how the application handles it and not one for the ontology
Mike: Add annotation to properties, and then template could would make a decision based on the annotation. How would template have access to that property?
Probably updating the JAVA Property template model classes responsible for data property info being passed to the front-end (i.e Freemarker)
Change to the vitro annotations (adding property that can now be used)
Updating the actual freemarker templates that would then use this information
Mike will look at it - perhaps when he is at the beach (because - and I paraphrase partially - JIRA tickets are better than reading books)
From chat (Benjamin) , “Would be great if someone could confirm the LDF server issue with TDB in that it doesn't work”
Actions
- Kitio Fofackto review
- Ralph O'Flinn to review/merge Solr/Elasticsearch PRs into sprint-search branch
Previous Actions
- Mike Conlon and Brian Lowe to review:
- Don Elsborg - add jira tickets for abox/tbox use cases - one ticket for each use case
- Brian Lowe - check with ontology group on handles
- Alex Viggio will bring news of Elasticsearch instead of Solr up with Product Evolution. Might there be consequences for the September sprint.
- Benjamin Gross to create new Jira issue for additional errors thrown startup.
