Page tree
Skip to end of metadata
Go to start of metadata

Date

 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Beta 4 Sprint : Ongoing

Agenda

  • (BEFORE MEETING IN #dev-sprint) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (30 mins) General Discussion Topics
    1. (20 mins) Submission form conceptual design: Originally designed to only touch WorkspaceItem and WorkflowItem, the recent changes in PR#541 now touch the Item object (and cause issues for other PRs).  Giuseppe Digilio (4Science)added a ticket to describe the problem & provide a proposed solution: https://github.com/DSpace/dspace-angular/issues/818
      1. Do we agree that the submission forms should ONLY touch WorkspaceItem and WorkflowItem?  (NOTE: This is similar to behaviors in DSpace v6, where submission forms never interacted with the Item directly, but always worked through these "wrapper" objects)
      2. Any additional ideas/concepts we need to clarify in Submission process design? (This is an opportunity to document our assumptions/design for this Submission process, so that we can work from a common idea.)
    2. (10 mins)Security issues in Processes REST endpoint: Some CLI flags should never be usable via the REST API (e.g. `--eperson`). We should find a way to either disable these flags automatically via the REST API, or perhaps a way to configure (per script) which flags are "CLI-only".
      1. This same issue has already appeared in multiple scripts (see links below) and for multiple CLI flags.  Unfortunately, some CLI flags become a security issue when available on REST, but they are not a security issue via CLI. 
      2. See this initial issue around `metadata-import`: https://github.com/DSpace/DSpace/issues/2822
      3. The Curation Tasks PR has the same security issue, as it also allows the `--eperson` flag: https://github.com/DSpace/DSpace/pull/2820
      4. Another problematic flag is the ability to specify an output file location, e.g. in `metadata-export`: https://github.com/DSpace/DSpace/issues/2821
    3. Additional topics welcome. Please add by Tues, July 28th.
  • (30 mins) Planning for next week

Attendees

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

Current Work

Project Board

DSpace 7.0 Beta 4 Project Board: https://github.com/orgs/DSpace/projects/3

To quickly find PRs assigned to you for review, visit https://github.com/pulls/review-requested  (This is also available in the GitHub header under "Pull Requests → Review Requests"

Delayed / Needs Discussion

  1. Finalize / approve the initial list of all authorization features which we should implement for the /api/authz/features REST endpoint.  This list of features should be limited to only features which are required to enable/disable User Interface functionality. (In other words, we can always add more features in the future.  We just need to approve the list necessary for 7.0)
  2. Initial Performance Testing from Chris.  Needs revisiting / retesting prior to 7.0. 
    1. https://cwilper.github.io/dspace-perftest/
    2. These performance tests were run prior to the work on "projections" (to limit the data returned by the REST API).  Therefore, it is likely performance is much improved, but needs verification testing.
  3. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.

Notes

  • (20 mins) Submission form conceptual design
    • ALL agreed that the Submission process should ONLY use WorkspaceItem and/or WorkflowItem. No features are allowed to bypass those objects and use the Item object (or endpoint).
      • WorkspaceItem & WorkflowItem are changes in DSpace 7 as they are now more than a "wrapper" object.
      • They also help us to enforce the "rules" defined in the submission process. For example, if we allowed bypassing the WorkspaceItem, then Submitters could edit any metadata (bypassing the validation or rules defined in the submission form configuration)...this is something we already fixed in  DS-4278 - Getting issue details... STATUS
    • ALL agreed that Giuseppe's general idea/proposal to fix current problems sounds reasonable: https://github.com/DSpace/dspace-angular/issues/818
      • Effort  this will take is the only area of disagreement.
      • Andrea feels the necessary REST fixes are minimal overall.  Maybe just a day or two?
      • Art feels the necessary Angular fixes require a major overall. Mentioned a month of effort
    • NEXT WEEK touching base again
      • Giuseppe has a few other ideas of a possible "quick fix" to minimally get "main" branch working again.  He will try these out today & create a PR.
      • Atmire team can look closer at Giuseppe's suggestions & verify their estimates around effort on Angular (and REST) side.
      • If there is no clear solution by next week, Tim will revert the problematic PR (https://github.com/DSpace/dspace-angular/pull/541) and reschedule it for beta5 for additional work/attention to better align to the (agreed to) Submission process design.  This is a worst case scenario however, as we'd much rather resolve the issues on "main" branch and not have to (temporarily) remove this work.
  • (10 mins)Security issues in Processes REST endpoint