Page tree
Skip to end of metadata
Go to start of metadata

Daylight Saving Time begins on March 8 for parts of USA

Daylight Saving Time (DST) starts in parts of the USA on March 8, but starts in Europe on March 29.  Because DST begins on different days in different parts of the world, this meeting time will change (temporarily) for anyone who experiences DST earlier. 

The meeting will remain at 15:00-16:00 UTC through March, but this will now be one hour later for anywhere under DST.

As of April 2, once everyone is in DST, the meeting time will switch to 14:00-15:00 UTC (one hour earlier), in order to move it back into the normal timeslot for everyone.

Date

 from 15:00-16:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Beta 2 & 3 Sprint : March 2-13

Agenda

  • (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (25 mins) General Discussion Topics
    1. Revisiting Tim's questions about changing types in all REST API responses to "core.item" (and similar) instead of "item". 
      1. See https://github.com/DSpace/DSpace/pull/2663#issuecomment-590453066 and RestAddressableModel.getUniqueType() in that PR
    2. Revisiting Scripts & Processes endpoint PR#2648: concerns about usage of Bitstreams for temporary files (like uploaded CSVs, SAF Zips, AIPs, etc)
      1. See also discussion notes from Feb 6
    3. (Please add a topic)
  • (20 mins) Planning for next week

Attendees

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others).

(error) = review done, changes were requested or bugs found.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

1 APPROVAL = pull request only requires a single approval to merge.  This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.  

Claim a Ticket!

If you do not have access in JIRA or GitHub to officially claim the ticket you wish to work on, contact Tim Donohue

PRs Needing Review

  1. (NEW) (REST Contract) Projections embedding (related to PR 2670 below) https://github.com/DSpace/Rest7Contract/pull/106 (Tim DonohueAndrea Bollini (4Science)?)
  2. (NEW) (REST Contract) (HIGH PRIORITY) Group/EPerson management continued https://github.com/DSpace/Rest7Contract/pull/107 (Tim DonohueAndrea Bollini (4Science)?)
  3. (NEW) (REST Contract) Administer Workflow https://github.com/DSpace/Rest7Contract/pull/108 (Tim DonohueAndrea Bollini (4Science)?)
  4. (REST Contract) related to the scripts & processes PR above (related to PR 2648 below) https://github.com/DSpace/Rest7Contract/pull/99 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue )
  5. (blue star) (REST) Select specific embeds: https://github.com/DSpace/DSpace/pull/2670 (Maybe one approval) (Tim Donohue - added feedback), Ben Bosman)
  6. (REST) (beta4) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue - REVIEW CommentsMark H. Wood  )
  7. (blue star) (REST) Shibboleth authentication https://github.com/DSpace/DSpace/pull/2651 (Paulo Graça - REREVIEW, Ben Bosman   - REREVIEW)
  8. (blue star) (REST) DS-4043 Revisit security layer of submission https://github.com/DSpace/DSpace/pull/2675 (Tim Donohue, Ben Bosman )
  9. (blue star) (REST) Initial implementation of the authorizations endpoints https://github.com/DSpace/DSpace/pull/2663 (Ben Bosman - (error) REVIEWEDTim Donohue - feedback added, bugs found)
  10. (blue star) (REST) Read only versioning endpoints https://github.com/DSpace/DSpace/pull/2680 1 APPROVAL (Tim Donohue, OTHER REVIEWERS WELCOME)
  11. (REST) (beta 3) Workflow step definitions: action validation https://github.com/DSpace/DSpace/pull/2685 (Tim Donohue, (tick) Ben BosmanAndrea Bollini (4Science))
  12. (blue star) (REST) (HIGH PRIORITY) Manage Groups - https://github.com/DSpace/DSpace/pull/2686 - DS-4026 (Tim DonohueAndrea Bollini (4Science) if needed)
  13. (blue star) (REST) DS-4278: Fix bug where submitters can edit all metadata : https://github.com/DSpace/DSpace/pull/2689 (MERGE CONFLICT) 1 APPROVAL(Tim Donohue)
  14. (NEW) (beta 3) Expose the action as an embed on claimedtasks https://github.com/DSpace/DSpace/pull/2701 1 APPROVAL (Tim Donohue )
  15. (blue star) (Angular) Shibboleth authentication (merge with REST PR #2651) https://github.com/DSpace/dspace-angular/pull/568 (Paulo GraçaBen Bosman)
  16. (blue star) (Angular) (beta 2) Edit Item Bitstreams Tab  https://github.com/DSpace/dspace-angular/pull/577 (NEEDS REBASE) (Tim DonohueGiuseppe Digilio (4Science))
  17. (blue star) (Angular) (beta 2) List versions - https://github.com/DSpace/dspace-angular/pull/585 - (Tim Donohue, NEEDS SECOND REVIEWER)
  18. (blue star) (Angular) (beta 2) Specify Embeds (merge with REST PR #2670) - https://github.com/DSpace/dspace-angular/pull/588 - 1 APPROVAL(Tim Donohue)
  19. (blue star) (Angular) (beta 2) Notice regarding the availability of new version on item pages: https://github.com/DSpace/dspace-angular/pull/595 - (Tim DonohueNEEDS SECOND REVIEWER)
  20. (blue star) (NEW) (Angular) (beta 2) Manage EPeople https://github.com/DSpace/dspace-angular/pull/609 (depends on #2686) (Tim DonohueBen Bosman)
  21. (NEW) (beta 3) Ensure workflow members can only perform actions assigned (dependent on PR 2701https://github.com/DSpace/dspace-angular/pull/608 (Giuseppe Digilio (4Science)Tim DonohueArt Lowel (Atmire))
  22. (Backend) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 ( NEEDS REVIEWERS)

PRs Coming Soon

  1. DS-4122 - Getting issue details... STATUS  Create Integration Tests to prove access restricted Communities/Collections cannot be accessed anonymously
  2. (blue star) (Angular) (beta2) Manage Groups ETA March 9th
  3. (Angular) (beta3) Administrative Search ETA March 12th

PRs Merged this week!

  1. (tick) (blue star) (REST) Respect client-provided projections for non-GETS: https://github.com/DSpace/DSpace/pull/2684  1 APPROVAL
  2. (tick) (blue star) (Angular) Submission bug fix: https://github.com/DSpace/dspace-angular/pull/5971 APPROVAL
  3. (tick) (blue star) (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673 1 APPROVAL
  4. (tick) (blue star) (Angular) (beta 1) Breadcrumbs: https://github.com/DSpace/dspace-angular/pull/591 
  5. (tick) (blue star) (Angular) Login name fixes & Submission required fields: https://github.com/DSpace/dspace-angular/pull/602
  6. (tick) (blue star) (Angular) Allow optional HALLinks: https://github.com/DSpace/dspace-angular/pull/607
  7. (tick) (blue star) (Angular) MyDSpace ClaimedTasks link resolving fixes: https://github.com/DSpace/dspace-angular/pull/606
  8. (tick) (REST Contract) Link to workflow steps and actions https://github.com/DSpace/Rest7Contract/pull/104 1 APPROVAL
  9. (tick) (REST Contract) Edit Community/Collection - Assign Roles/Groups https://github.com/DSpace/Rest7Contract/pull/105
  10. (tick) (REST) DS-4123 : (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2687 1 APPROVAL
  11. (tick) (REST) DS-4124 : Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2688 - 1 APPROVAL
  12. (tick) (REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 1 APPROVAL

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. Managing Authorization info in Angular UI How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example:  https://github.com/DSpace/dspace-angular/issues/393
    1. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
    2. Work is ongoing, but has been started in these areas:
      1. Summary of ideas: REST Authorization 
      2. Contract for Authorization Endpoints: https://github.com/DSpace/Rest7Contract/pull/92
      3. Contract for ResourcePolicies: https://github.com/DSpace/Rest7Contract/pull/87
  2. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  3. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  4. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes