Page tree
Skip to end of metadata
Go to start of metadata

Date

 from 15:00-16:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Beta 1 & 2 Sprint : Feb 17-28

  • Finish Beta1 tasks in DSpace 7 Release Plan spreadsheetGoal is to have Beta1 released week of Feb 24.
  • Continuing work on Beta2 tasks (especially those with many dependencies)

Agenda

  • (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (25 mins) General Discussion Topics
    1. (If further discussion is needed) Revisiting Scripts & Processes endpoint PR#2648: Tim has concerns about usage of Bitstreams for temporary files (like uploaded CSVs, SAF Zips, AIPs, etc)
      1. See also last week's discussion notes
    2. (Please add a topic)
  • (20 mins) Planning for next week

Attendees

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others).

(error) = review done, changes were requested or bugs found.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

1 APPROVAL = pull request only requires a single approval to merge.  This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.  

Claim a Ticket!

If you do not have access in JIRA or GitHub to officially claim the ticket you wish to work on, contact Tim Donohue

PRs Needing Review

  1. (REST) (beta2) Select specific embeds (depends on PR#2625): https://github.com/DSpace/DSpace/pull/2670 (Tim DonohueBen Bosman)
  2. (REST) (beta 2 but dependencies) Workflow step definitions https://github.com/DSpace/DSpace/pull/2646  (Ben Bosman - REREVIEW BY FEB 27, Tim Donohue - REREVIEW BY FEB 27, Andrea Bollini (4Science) - REREVIEW BY FEB 27)
  3. (REST) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue - REVIEW Comments, Mark H. Wood  )
  4. (REST Contract) related to the scripts & processes PR above https://github.com/DSpace/Rest7Contract/pull/99 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue )
  5. (REST) Shibboleth authentication https://github.com/DSpace/DSpace/pull/2651 (Paulo Graça - REREVIEW, Ben Bosman  - REREVIEW)
  6. (REST) Edit Item - Manage Bitstreams https://github.com/DSpace/DSpace/pull/2666 1 APPROVAL (Tim Donohue)
  7. (REST) DS-4428 missing parameter exception https://github.com/DSpace/DSpace/pull/2668 1 APPROVAL ((tick) Tim Donohue)
  8. (REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 (Tim Donohue - questions added) (Possibly one approval)
  9. (NEW) (REST) Initial implementation of the authorizations endpoints https://github.com/DSpace/DSpace/pull/2663 (Ben Bosman - REVIEW by FEB 27 (if possible), Tim Donohue - REVIEW by FEB 27)
  10. (blue star) (NEW) (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673 1 APPROVAL((tick) Tim Donohue)
  11. (NEW) (REST) Read only versioning endpoints https://github.com/DSpace/DSpace/pull/2680 1 APPROVAL (Tim Donohue)
  12. (NEW) (REST) Workflow step definitions: action validation (depends on #2646 above) https://github.com/DSpace/DSpace/pull/2685 (Tim DonohueBen BosmanAndrea Bollini (4Science))
  13. (Angular) Shibboleth authentication (merge with REST PR #2651) https://github.com/DSpace/dspace-angular/pull/568 (Paulo GraçaBen Bosman)
  14. (Angular) (beta 2) Edit Item Bitstreams Tab (depends on #578) https://github.com/DSpace/dspace-angular/pull/577 (Tim DonohueGiuseppe Digilio (4Science))
  15.  (blue star) (Angular) (beta 1) Only resolve links when needed (Performance improvement work) https://github.com/DSpace/dspace-angular/pull/578 (Tim Donohue - REREVIEW ASAP, Giuseppe Digilio (4Science) - REVIEW ASAP, Paulo Graça - REVIEW ASAP )
  16.  (blue star) (Angular) (beta 1) Angular 8 Upgrade https://github.com/DSpace/dspace-angular/pull/579 ((tick)Tim Donohue , Giuseppe Digilio (4Science) - REVIEW ASAP, Paulo Graça - REVIEW ASAP)
  17. (NEW) (Angular) Fix angulartics router bug https://github.com/DSpace/dspace-angular/pull/580 1 APPROVAL ((tick)Tim Donohue , (tick) Paulo Graça)
  18. (Backend) Fix errorprone test warnings after Java 11 upgrade: https://github.com/DSpace/DSpace/pull/2669 1 APPROVAL ((tick) Mark H. Wood)
  19. (NEW) (Backend) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 (NEEDS REVIEWERS)
  20. (NEW) (Backend) DS-4434: Fix Context.commit() / isValid() and add Tests https://github.com/DSpace/DSpace/pull/2674 ((tick) Mark H. Wood - MERGE says Andrea)


PRs coming before next meeting (that like to receive reviewers assignment)

  1. (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously ETA feb 21  DS-4123 - Getting issue details... STATUS  - 1 APPROVAL (Tim DonohueBen Bosman if needed)
  2. Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously ETA feb 21  DS-4124 - Getting issue details... STATUS  - 1 APPROVAL (Tim DonohueBen Bosman if needed)
  3. Submitters can edit all metadata ETA feb 24  DS-4278 - Getting issue details... STATUS  - (Tim DonohueBen Bosman)
  4. (REST) (beta 2 - has upcoming dependencies) Manage Groups - ETA Feb 21 - DS-4026 (Tim DonohueAndrea Bollini (4Science) if needed)
  5. (Angular) (beta 2) Specify embeds - ETA feb 21 - 1 APPROVAL(Tim Donohue)
  6. (Angular) (beta 2) List versions - ETA feb 21 - (Tim Donohue, NEEDS SECOND REVIEWER)
  7. (blue star) (Angular) (beta 1) Breadcrumbs - ETA feb 26 - (Tim DonohueGiuseppe Digilio (4Science))

PRs Merged this week!

  1. (tick) (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41
  2. (tick) (REST) DS-4389 improving patch system framework Part 1 https://github.com/DSpace/DSpace/pull/2591
  3. (tick) (blue star) (REST) Projections continued: https://github.com/DSpace/DSpace/pull/2625
  4. (tick) (REST) Collection item template updates https://github.com/DSpace/DSpace/pull/2656 1 APPROVAL
  5. (tick) (blue star) (Backend) Java 11 upgrade and Replace JMockit with Mockito: https://github.com/DSpace/DSpace/pull/2654
  6. (tick) (Backend) URL configuration refactor (new "dspace.server.url" and "dspace.ui.url"): https://github.com/DSpace/DSpace/pull/2657
  7. (tick) (Angular) Minor Docker fixes for JDK11 & URL config changes (required by PR#2654 and PR#2657 after their merger): https://github.com/DSpace/dspace-angular/pull/574

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. Managing Authorization info in Angular UIHow to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
    1. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
    2. Work is ongoing, but has been started in these areas:
      1. Summary of ideas: REST Authorization 
      2. Contract for Authorization Endpoints: https://github.com/DSpace/Rest7Contract/pull/92
      3. Contract for ResourcePolicies: https://github.com/DSpace/Rest7Contract/pull/87
  2. REST API Projections:  DS-3533 - Getting issue details... STATUS
    1. Work begun in https://github.com/DSpace/DSpace/pull/2547 (by Chris Wilper)
      1. Based on detail discussions in our Oct 17 meeting
    2. (Outdated) Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
    3. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
  3. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  5. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  6. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes