This Confluence wiki site, maintained by DuraSpace prior to the recent merger with LYRASIS, will transition from the duraspace.org domain to the lyrasis.org domain on Saturday, Nov 16 beginning at approximately 7pm ET. A period of downtime of 2-3 hours is expected. After the transition, this wiki will be available at https://wiki.lyrasis.org/. All links to duraspace.org wiki pages will be redirected to the correct lyrasis.org URL. If you have questions prior to or following the transition please contact: wikihelp@lyrasis.org.

Page tree
Skip to end of metadata
Go to start of metadata

Date

 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Agenda

Attendees

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others). These are tasks with lots of dependencies

(error) = review done, changes were requested or bugs found.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

1 APPROVAL = pull request only requires a single approval to merge.  This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.  

Tickets / PRs In Progress

  1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
  2. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
  4. (REST) DS-4043: Revisit the security layer of the submission  (work in progress) Andrea Bollini (4Science)
  5. (REST) Pagination bug with withdrawn items: https://github.com/DSpace/DSpace/pull/2406 (Dimitris Pierrakos , Ben Bosman - Feedback provided)

PRs Needing Review

  1. (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Tim Donohue - feedback provided,  Andrea Bollini (4Science) - (warning) feedback provided)
  2. (NEW) (REST Contract) Collection logo https://github.com/DSpace/Rest7Contract/pull/84 1 APPROVAL (Andrea Bollini (4Science)Tim Donohue)
  3. (NEW) (REST Contract) collection item template https://github.com/DSpace/Rest7Contract/pull/85 1 APPROVAL (Andrea Bollini (4Science)Tim Donohue)
  4. (REST) Authority control bugfixes https://github.com/DSpace/DSpace/pull/2528 ((tick)Tim DonohueGiuseppe Digilio (4Science)Andrea Bollini (4Science))
  5. (REST) Scripts and processes endpoint https://github.com/DSpace/DSpace/pull/2529 (Tim DonohueDimitris Pierrakos)
  6. (REST) DS-4337 implement bitstream-bitstreamformat relation endpoints https://github.com/DSpace/DSpace/pull/2503 (Tim Donohue REREVIEW Andrea Bollini (4Science) REREVIEW, Ben Bosman)
  7. (REST) Ds 4317 bundles in rest https://github.com/DSpace/DSpace/pull/2548 (Ben BosmanTim Donohue, Chris Wilper )
  8. (NEW) (REST) REST Projections "proof of concept": https://github.com/DSpace/DSpace/pull/2547 (Early Reviews welcome from all.)
  9. (NEW) (REST) Ds 4358 tests in modules https://github.com/DSpace/DSpace/pull/2553 (Tim Donohue , NEEDS SECOND REVIEWER)
  10. (Angular) Shibboleth integration support: https://github.com/DSpace/dspace-angular/pull/429  (Giuseppe Digilio (4Science) reviewed again fixed error with yarn start, Fernando FCT/FCCN, Paulo Graça - feedback provided)
  11. (Angular) forceBypassCache should be removed from the RequestService: https://github.com/DSpace/dspace-angular/pull/468 ((tick)Art Lowel (Atmire) - approved again,  Giuseppe Digilio (4Science) )
  12. (Angular) Routing by handle and uuid: https://github.com/DSpace/dspace-angular/pull/490 (Art Lowel (Atmire) - provided feedback, Giuseppe Digilio (4Science), Tim Donohue , Andrea Bollini (4Science) - might be able to help with pid endpoint)
  13. (NEW) (Angular) Tracking stats from the UI https://github.com/DSpace/dspace-angular/pull/495 (Tim Donohue , NEEDS SECOND REVIEWER)
  14. (NEW) (Angular) Refactor object lists https://github.com/DSpace/dspace-angular/pull/497 (Giuseppe Digilio (4Science)Tim Donohue)
  15. (NEW) (Angular) Disable e2e tests until docker issue is fixed https://github.com/DSpace/dspace-angular/pull/499 1 APPROVAL  (Andrea Bollini (4Science) will create a fix for main DSpace/DSpace repo)
  16. (Backend) dspace.bat file: https://github.com/DSpace/DSpace/pull/2544 1 APPROVAL (Tim DonohueAlexander Sulfrian

PRs Merged this week!

  1. (tick) (REST) Issue when community has multiple dc.title values https://github.com/DSpace/DSpace/pull/2486
  2. (tick) (REST) Spring security for createAndReturn with parent id https://github.com/DSpace/DSpace/pull/2489
  3. (tick) (REST) DS-4359 add null check to getAllRelationshipTypes https://github.com/DSpace/DSpace/pull/2545 
  4. (tick) (REST) DS-4360 fix searchevents link https://github.com/DSpace/DSpace/pull/2546 
  5. (tick) (REST) (Entities) CSV Import fixes, improvements to entity validation: https://github.com/DSpace/DSpace/pull/2522
  6. (tick) (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348 
  7. (tick) (Angular) Collection pages WIP: https://github.com/DSpace/dspace-angular/pull/472 

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. Managing Authorization info in Angular UIHow to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
    1. Can this be achieved via passed HAL "_links" (e.g. the existence of an "edit" link in REST response means you must have Edit rights)?
    2. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
      1. Also likely to need to store/cache a user's Groups in UI layer, as some areas (e.g. Administrative) require knowledge of user group membership
  2. REST API Projections:  DS-3533 - Getting issue details... STATUS
    1. Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
      1. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
  3. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes

  • Revisiting REST API Projections: https://jira.duraspace.org/browse/DS-3533
    1. Proof of concept PR: https://github.com/DSpace/DSpace/pull/2547
    2. Slides that Chris Wilper presented
    3. Also some early "best practice" notes started at Guide to Resource Linking and Embedding (DRAFT)
  • Overall, team approves of this direction. We decided we might want to rework the proof of concept PR to be based on code already in `master` (currently it is based on the Bundles PR#2548 which is still under review)
    • We might think of doing proof of concept based on Item relationships, or maybe Community - Collection - Item relationships. These are both in master already, and an initial PR against either might be easier to review/approve more immediately than basing it off Bundles
  • All should review the initial PR and provide any other feedback.  Direction is good though.
  • Reviewing & scoping tasks flagged as "NEEDS MORE INFO" in Development Planning Spreadsheet
    • Only made it through first 3 in that spreadsheet
    • Tim will setup a Doodle poll for a separate meeting on this with Andrea, Art & Ben (minimally). Others are welcome too (get in touch).  Hopefully if we all review this spreadsheet we can quickly go through it in one meeting to determine how to scope each (and whether anything in the spreadsheet still requires deeper discussion).