This Confluence wiki site, maintained by DuraSpace prior to the recent merger with LYRASIS, will transition from the duraspace.org domain to the lyrasis.org domain on Saturday, Nov 16 beginning at approximately 7pm ET. A period of downtime of 2-3 hours is expected. After the transition, this wiki will be available at https://wiki.lyrasis.org/. All links to duraspace.org wiki pages will be redirected to the correct lyrasis.org URL. If you have questions prior to or following the transition please contact: wikihelp@lyrasis.org.

Page tree
Skip to end of metadata
Go to start of metadata

Date

 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Agenda

  • (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (30 mins) General Discussion Topics
    1. Changing the collection in the submission doesn't change the item template (Revisiting this topic from last week)
      1. Problem 1: Item Templates are only applied when submission is begun, and currently submissions always begin with the default Collection. 
      2. Problem 2: If you've filled out metadata, and then switch collections, it's possible to lose some metadata you entered (if those fields do not exist in the new Collection's submission forms).  Users are not notified or warned when metadata is lost.
      3. Loosely related performance issue (with loading all Collections into submission form): https://github.com/DSpace/dspace-angular/issues/487
    2. Revisiting REST API Projections (if necessary)? https://jira.duraspace.org/browse/DS-3533 (MOVE TO NEXT WEEK)
    3. Reviewing & scoping tasks flagged as "NEEDS MORE INFO" in Development Planning Spreadsheet
      1. This is necessary to prepare for the next phase of the DSpace 7 Estimation Process
  • (15 mins) Planning for next week

Attendees

Current Work

Legend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others). These are tasks with lots of dependencies

(error) = review done (this week), changes were requested.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

Tickets / PRs In Progress

  1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
  2. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
  4. (REST) DS-4043: Revisit the security layer of the submission  (work in progress) Andrea Bollini (4Science)
  5. (REST) Pagination bug with withdrawn items: https://github.com/DSpace/DSpace/pull/2406 (Dimitris Pierrakos , Ben Bosman - Feedback provided)

PRs Needing Review

  1. (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Tim Donohue - feedback provided,  Andrea Bollini (4Science) - (warning) feedback provided)
  2. (REST) Issue when community has multiple dc.title values https://github.com/DSpace/DSpace/pull/2486 UPDATEDTim Donohue - feedback added, Andrea Bollini (4Science))
  3. (REST) Oai harvesting setup https://github.com/DSpace/DSpace/pull/2491 (Tim Donohue - (warning) Minor improvements requested, (question) Andrea Bollini (4Science) - feedback added , (tick)Paulo Graça )
  4. (REST) Spring security for createAndReturn with parent id https://github.com/DSpace/DSpace/pull/2489 (Tim Donohue - (warning) Minor improvements requested, (tick) Chris Wilper
  5. (REST) Authority control bugfixes https://github.com/DSpace/DSpace/pull/2528 (Tim DonohueGiuseppe Digilio (4Science)Andrea Bollini (4Science))
  6. (REST) (Entities) CSV Import fixes, improvements to entity validation: https://github.com/DSpace/DSpace/pull/2522 (Ben BosmanPaulo Graça - feedback provided) 
  7. (NEW) (REST) Scripts and processes endpoint https://github.com/DSpace/DSpace/pull/2529 (Tim DonohueDimitris Pierrakos)
  8. (NEW) (REST) DS-4337 implement bitstream-bitstreamformat relation endpoints https://github.com/DSpace/DSpace/pull/2503 (Tim DonohueBen Bosman)
  9. (NEW) (REST) Fixing exception error when using UUID on Harvesting process  https://github.com/DSpace/DSpace/pull/2536 (Chris WilperTim Donohue)
  10. (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348 ( Tim Donohue - (warning) REREVIEWArt Lowel (Atmire) - provided feedback)
  11. (Angular) Shibboleth integration support: https://github.com/DSpace/dspace-angular/pull/429  (Giuseppe Digilio (4Science) reviewed again fixed error with yarn start, Fernando FCT/FCCN, Paulo Graça)
  12. (Angular) forceBypassCache should be removed from the RequestService: https://github.com/DSpace/dspace-angular/pull/468 ((tick)Art Lowel (Atmire)(error) Giuseppe Digilio (4Science) issue found)
  13. (Angular) Collection pages WIP: https://github.com/DSpace/dspace-angular/pull/472 (Art Lowel (Atmire) - feedback provided, Tim Donohue)
  14. (NEW) (Angular) Routing by handle and uuid: https://github.com/DSpace/dspace-angular/pull/490 (Art Lowel (Atmire)Giuseppe Digilio (4Science))

PRs Merged this week!

  1. (tick) (REST Contract) CRUD on Collection & Community logo https://github.com/DSpace/Rest7Contract/pull/79
  2. (tick) (REST Contract) CRUD on Collection Item template https://github.com/DSpace/Rest7Contract/pull/80
  3. (tick) (Angular) Submission Miscellaneous fixes: https://github.com/DSpace/dspace-angular/pull/432

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. Managing Authorization info in Angular UIHow to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example: https://github.com/DSpace/dspace-angular/issues/393
    1. Can this be achieved via passed HAL "_links" (e.g. the existence of an "edit" link in REST response means you must have Edit rights)?
    2. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
      1. Also likely to need to store/cache a user's Groups in UI layer, as some areas (e.g. Administrative) require knowledge of user group membership
  2. REST API Projections:  DS-3533 - Getting issue details... STATUS
    1. Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
      1. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
  3. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  4. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes

  • Changing the collection in the submission doesn't change the item template (Revisiting this topic from last week)
    • Problem 1: Item Templates are only applied when submission is begun, and currently submissions always begin with the default Collection. 
      • Might be solved by asking the user to select the collection first.  However, we'd want to find a clean solution for when a submission is begun via dragging & dropping a file – do they select a collection next to the drag & drop area? Or maybe some sort of "select a collection" prompt after dragging & dropping
    • Problem 2: If you've filled out metadata, and then switch collections, it's possible to lose some metadata you entered (if those fields do not exist in the new Collection's submission forms).  Users are not notified or warned when metadata is lost.
      • Option discussed last week was at least providing a warning to the user that certain fields may be removed
      • Andrea notes another approach could be to move any "to be removed" metadata fields to a new submission panel (called "trash" or "to be removed"). The user then can visually see which fields are no longer applicable, and can then choose to move that info to a new field, or let it be deleted.
      • This new panel approach has not yet been estimated though.  Andrea will describe in more detail and give a rough estimate of what this might look like.   Who would implement is unclear as well (not a high priority for 4Science at this time)
      • Andrea notes that we could also reapply the Item Template after selecting a different collection.  So, some process could be built to merge in the Item Template of the new Collection.  This also needs better defining though & a rough estimate
    • Loosely related performance issue (with loading all Collections into submission form): https://github.com/DSpace/dspace-angular/issues/487
      • This performance issue may not be impacted by REST API Projections.  It's an issue because there's no single endpoint to grab the list of Collections you have access too.  Instead, the UI has to grab Communities, and then query each Community for Collections you have access too – this results in a large amount of effort in the UI, and also a large number of requests to the REST API.
    • Another Option:  We also have the options of choosing to remove the ability to change Collections in the Submission UI.  All on our team agree this is a great feature.  But, the problems that have arisen here may not be easily solvable.  Is this high priority enough to put the effort into DSpace 7 to solve all the issues?  Or do we consider removing the feature and pushing this to DSpace 8?    Lieven noted that Atmire can do a more thorough analysis of the effort it'd take to remove this feature.
  •  Oai harvesting setup https://github.com/DSpace/DSpace/pull/2491
    • Discussed Andrea's notes here: https://github.com/DSpace/DSpace/pull/2491#pullrequestreview-294253151
    • Tim notes he sees Andrea's point, but at the same time, this endpoint may be "good enough" as is.
    • Andrea notes his feedback here is obviously late.  He wants to be sure we all understand the reasons for this feedback though.  Also notes that he's OK with current approach (but cannot give it a +1 in his opinion). He will log a ticket for how to refactor this in a future PR (either in DSpace 7 or 8).
    • We realize that our initial REST API (in DSpace 7) may not end up being 100% perfect, no matter how hard we strive for it.  So, if there's areas that need refactoring / rework to better align with Spring Data REST, we can also create tickets for that work and list them on the DSpace 8 page DSpace Release 8.0 Status
  • Ran out of time to discuss Development Planning Spreadsheet.
  • Next meeting is Oct 10, same time same place.