2018-03-15 DSpace 7 Working Group Meeting notes

Date

15 Mar 2018

Discussion (combined Angular UI & REST meeting)

Attendees

• Art Lowel (Atmire)
• Tim Donohue
• Giuseppe Digilio (4Science)
• Tom Desair
• Terrence W Brady
• Mark H. Wood
• Lieven Droogmans

Location: DSpace Meeting Room

Notes

• General Updates
  
  • Planning Spreadsheet: https://docs.google.com/spreadsheets/d/18brPF7cZy_UKyj97Ta44UJg5Z8OwJGi7PLoPJVz-g3g/edit?usp=sharing
    • Latest status is still there
  • Meeting time: Should we keep at 15:00UTC (which is now an hour later for anyone who moved into daylight savings time), or move forward to 14:00UTC.
    • Consensus: 14:00UTC seems fine. During daylight savings / summer hours, we'll meet then.
• Angular UI Team updates (via Art)
  • Merged PRs:
    
    • https://github.com/DSpace/dspace-angular/pull/236
    • This PR broke master temporarily, but fixed in: https://github.com/DSpace/dspace-angular/pull/237
  • Discussions of Pagination issues for Collections in Communities
    • "page" param appears at different levels in the request, depending on whether you are looking at paginated embedded objects versus the top-level objects returned in the request
    • Relevant areas of REST Code (from Tom)
      • Spring framework pagination: https://github.com/spring-projects/spring-hateoas/blob/master/src/main/java/org/springframework/hateoas/hal/Jackson2HalModule.java#L344
      • DSpace RestResourceController: https://github.com/DSpace/DSpace/blob/master/dspace-spring-rest/src/main/java/org/dspace/app/rest/RestResourceController.java#L767
      • DSpace Embedded Page: https://github.com/DSpace/DSpace/blob/master/dspace-spring-rest/src/main/java/org/dspace/app/rest/model/hateoas/EmbeddedPage.java#L33
      • DSpace HALResource: https://github.com/DSpace/DSpace/blob/master/dspace-spring-rest/src/main/java/org/dspace/app/rest/model/hateoas/HALResource.java#L36
    • Tim created a ticket at: https://github.com/DSpace/dspace-angular/issues/238
  • Lotte's working on search backend PR:
    • https://github.com/DSpace/dspace-angular/pull/235
  • Christophe from Atmire will be joining development on Angular side in near future.
  • Giuseppe notes that MyDSpace work is in progress. Almost finished
  • Giuseppe notes he reopened an old ticket about Base Path issues (still exists on master): https://github.com/DSpace/dspace-angular/issues/145
    • Still investigating a fix.

• REST API Updates
  
  • PRs in need of review
    
    • https://github.com/DSpace/DSpace/pull/1974
    • https://github.com/DSpace/DSpace/pull/1976
  • Some PRs need fixing according to Code Style
    • E.g. https://github.com/DSpace/DSpace/pull/1964
    • Tim will export IDEA IntelliJ settings for easier cleanup of this PR
      • These settings also documented at Code Style Guide#IntelliJIDEA
  • Discussion of how to get Community Sprints started (Lieven). General idea is...
    
    • Draft of a framework at DSpace 7 Community Sprints
    • Looking good overall, a few comments
      • Regarding proposed dates, later is probably better. Want time to advertise and get on calendars
      • Documentation on getting up-to-speed needs more details about getting up to speed on REST API
        • e.g. is this up to date? DSpace 7 REST: Coding DSpace Objects
    • Question: Do we need to implement Browse Alphabetically prior to the Sprint? It seems to be required by "Browse Withdrawn Items" & Browse Private Items
    • Could we have coaches available for those new to sprint?
      • Goal is to get new developers signed up for the sprint. They will likely need a fair amount of early help / support. Having a coach to contact would be useful
      • Seems like a good idea
    • ACTION: Art and Andrea should start to estimate effort of tasks listed for Community Sprint.
• Next Meeting will be Thurs, March 22 at 14:00UTC in DSpace Meeting Room