Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
from 14:00-15:00 UTC
Location: DSpace Meeting Room
Agenda
General development / planning updates (Tim)
- Sprint Planning: DSpace 7 Community Sprints
- DSpace 7 Entities Working Group (2018-19)
- Quick updates on Angular UI tickets and/or PRs (Art)
- Quick updates on REST API tickets and/or PRs (Andrea)
- [Last 10 mins] Development planning/updates in Development Planning Spreadsheet.
Attendees
Notes
- General Updates (Tim)
- DSpace 7 Entities Working Group (2018-19) coming soon.
- Angular Team Updates
- Merged PRs:
- In Progress tickets / PRs:
- Tickets / PRs requiring review:
- Kristoff's Browse By Title / Metadata Pull Request: https://github.com/DSpace/dspace-angular/pull/283
- Needs tests/reviews. Tim will add to list
- Lotte's final Search PR now ready: https://github.com/DSpace/dspace-angular/pull/280 (However PR now fails tests. Tim notified Lotte via a comment)
- Being blocked https://github.com/DSpace/DSpace/pull/2125
- Giuseppe's PR : https://github.com/DSpace/dspace-angular/pull/279
- Art has not had a chance to review. Will get to this next week.
- Tim gave it a test (see comments on PR). The /submit path seems to work well. But, workspace/workflow items cannot be easily tested, as there's no UI to list them.
- Kristoff's Browse By Title / Metadata Pull Request: https://github.com/DSpace/dspace-angular/pull/283
- Next up:
- Kristoff will update old RxJS operators to pipeable to prepare for Angular 6: https://github.com/DSpace/dspace-angular/issues/201
- Also looking to work on Edit Collection & Community pages
- Lotte to use resolvers to fetch database object while page is loading (to increase performance). This was introduced for Angular 5? Ticket: https://github.com/DSpace/dspace-angular/issues/284
- Will be looking at Angular 6 upgrade, but that upgrade won't be merged to after Submission is merged.
- Kristoff will update old RxJS operators to pipeable to prepare for Angular 6: https://github.com/DSpace/dspace-angular/issues/201
- Discussion of https://github.com/DSpace/DSpace/pull/2125 (UUID endpoint)
- Andrea would rather not refactor the Identifier classes for this functionality. Thinks a simple endpoint could suffice
- RE: performance concerns, Pablo asks why don't we do this query via Solr? Is it possible to do there, if the DB query could be complex?
- Others agree that Solr might be a better option
- Andrea will look to reimplement via a Solr Query (ideally by Monday). Pablo also noted he can look at this in the coming days. Both of them will touch base via Slack.
- REST Team Updates
- Merged PRs:
- In Progress tickets / PRs:
- Pablo recently claimed https://jira.duraspace.org/browse/DS-3904
- Tickets / PRs requiring review:
- https://github.com/DSpace/DSpace/pull/2120
- Has new feedback from Andrea. Tim to review
- https://github.com/DSpace/DSpace/pull/2165
- Tim to review
- Mark's latest PR is almost ready to go: https://github.com/DSpace/DSpace/pull/2129
- Just a comment to replace "Inject" annotations with "Autowired" (which is the best practice for Spring). We just want to remain consistent in our code (even though these annotations are identical in functionality).
- https://github.com/DSpace/DSpace/pull/2126
- Merge soon. Tim will review & merge
- Pablo's latest PR is almost ready to go. Just needs integration tests: https://github.com/DSpace/DSpace/pull/2173
- Andrea has been reviewing & gave advice on creating a small integration test of just 3 items, and "jumping to" the 2nd item.
- https://github.com/DSpace/DSpace/pull/2120
- Discussion
- New automation script to deploy the REST demo site. Currently pulls from 4Science master branch (not the main DSpace/DSpace branch).
- Will move to DSpace/DSpace, in a new branch "rest-demo". This way any Committers can update the REST Demo site just by updating the "rest-demo" branch in GitHub.
- Exception handling in Spring - How can we do this better / what are best practices? We are currently wrapping many errors in RuntimeException – is this really the best way to do things?
- Delayed this discussion for next week. Andrea had to leave early, and we also wanted to see if Tom Desairis available for this discussion (as he may have knowledge of Exception handling in Spring
- This topic came up on Slack and in this PR: https://github.com/DSpace/DSpace/pull/2126#pullrequestreview-143324207
- New automation script to deploy the REST demo site. Currently pulls from 4Science master branch (not the main DSpace/DSpace branch).
- Development Planning Spreadsheet
- Skipped this for today, as several folks had to leave early. Need to get back to this next week.
- Next week, continue from Submission section
- The Next Meeting will be on Thursday, Aug 23 at 14:00UTC (10:00am EDT) in DSpace Meeting Room
- Main Agenda Items
- Quick updates (as usual)
- Discussion of Exception Handling in Spring. We need to establish best practices on how to do this in REST API
- Revisiting/reviewing Development Planning Spreadsheet.
- Travel / Holidays
- Terrence W Bradyis out until week of Aug 20
- Giuseppe Digilio (4Science)will be out until early September
- Main Agenda Items
Overview
Content Tools