Art has not had a chance to review. Will get to this next week.
Tim gave it a test (see comments on PR). The /submit path seems to work well. But, workspace/workflow items cannot be easily tested, as there's no UI to list them.
Andrea would rather not refactor the Identifier classes for this functionality. Thinks a simple endpoint could suffice
RE: performance concerns, Pablo asks why don't we do this query via Solr? Is it possible to do there, if the DB query could be complex?
Others agree that Solr might be a better option
Andrea will look to reimplement via a Solr Query (ideally by Monday). Pablo also noted he can look at this in the coming days. Both of them will touch base via Slack.
Just a comment to replace "Inject" annotations with "Autowired" (which is the best practice for Spring). We just want to remain consistent in our code (even though these annotations are identical in functionality).
Andrea has been reviewing & gave advice on creating a small integration test of just 3 items, and "jumping to" the 2nd item.
Discussion
New automation script to deploy the REST demo site. Currently pulls from 4Science master branch (not the main DSpace/DSpace branch).
Will move to DSpace/DSpace, in a new branch "rest-demo". This way any Committers can update the REST Demo site just by updating the "rest-demo" branch in GitHub.
Exception handling in Spring - How can we do this better / what are best practices? We are currently wrapping many errors in RuntimeException – is this really the best way to do things?
Delayed this discussion for next week. Andrea had to leave early, and we also wanted to see if Tom Desairis available for this discussion (as he may have knowledge of Exception handling in Spring