To quickly find PRs assigned to you for review, visit https://github.com/pulls/review-requested (This is also available in the GitHub header under "Pull Requests → Review Requests")
Deadline is TBD for 9.2, 8.3 and7.6.5. Bug fix releases do not have fixed/scheduled deadlines.Instead, the developer team will determine when to create a release based on the significance of the issues to solve. (e.g. If major issues are fixed, then a bug fix release will occur more rapidly. If minor issues are found, then a bug fix release may be delayed until sufficient fixes have been made to warrant a release)
Bug/security fixes only. These minor releases will not include any new features.
New "themeable components" (for dspace-angular) are allowed in bug fix releases, provided that they don't significantly modify component behavior or similar.
Accessibility fixes are also allowed in bug fix releases, provided they don't significantly modify component behavior or similar.
Bug fix PRsshould be created against "main" branch where possible. The "main" branch has the most strict code style rules. (i.e. PRs created against dspace-7_x are becoming more difficult to port forward.)
Per our support policy, bug fixes are only guaranteed to be ported back to 9.x. That said, where possible, we'll try to backport bug fixes (especially significant ones) to 8. x and 7.6.x.
Try "Pull Request Trading" for a quicker review
Do you have a PR stuck in "under review" that you really want to see move forward? Or maybe it's someone else's PR but you want to get it more attention?
This past Tuesday was the webinar. A lot of updates shared then. The slides and video from the webinar will be shared on mailing lists soon (as soon as the video is ready)
No other major updates to share. Final decision is still not made, but both groups are getting closer to wrapping up their work
You may have seen the announcements to dspace-community & dspace-tech regarding removing this X.509 Certificate Authentication feature asking if anyone is using this feature
It appears to be entirely unmaintained since it was added in DSpace 1.5
Tim tried to get it running in DSpace 9 last week, but was unable to get it working. The documentation is also very vague and missing details, which make it even more difficult
We've had zero responses from the outreach to mailing lists & Slack and in this meeting. No one appears to be using this feature.
Tim proposes we remove the feature immediately from DSpace 7.x, 8.x and 9.x as it appears to be unused. Several other Committers agree.
Tim will create a PR to remove it. It's just two files (a Java class and a config file). If anyone still needs them, they can easily restore the files as needed
Dynamic forms / future of forms in dspace-angular: any more updates or thoughts?
Art shares his update. He worked on this previously (old branch: https://github.com/atmire/ng18-submission-poc). But, he set it aside for now because it doesn't seem possible to do in parallel with potential DSpace-CRIS merger tasks. He's waiting on DSpace-CRIS merger to be decided, so that we can revisit this.
Overall though, Art notes that he feels it may be a better approach to build our own form components in DSpace (removing dependency on any external library). There are no libraries that match up well with what we need. The one we are using (ng-dynamic-forms) also is not always kept up to date (often slow to update to latest Angular)
Giuseppe also notes: "new angular signal forms are experimental for angular 21 but i think when we'll be ready they will be stable"
ACTION: We should revisit this topic in the future once a decision is made on DSpace-CRIS merger & we have time to revisit these forms.
We need to upgrade Angular in DSpace 10.0. Angular 18 is already leaving security support soon. Angular 19 will leave security support mid-year next year. We should upgrade to Angular 20.
Art says Atmire can claim this for DSpace 10.0. Ticket is assigned to Art.
Art was able to create the same structure in Angular Ng Workspaces. It works similar to Nx overall, with modules in separate directories which can build separately.
Art notes though that Angular Ng Workspaces does not include the caching benefits of Nx. So, the build in Angular Ng Workspaces takes a similar amount of time to our current build process. The main benefit of Angular Ng Workspaces though is that our code is better modularized.
Art has a few more tests he'd like to run in this environment. Including a test to see if it's trivial to migrate from Angular Ng Workspaces to Nx (he suspect it may be).
ACTION: Next step. On Thursday, October 23rd (in three weeks), we'll revisit this topic and try to make a final decision on the best approach for DSpace 10.
Art noted that he as a few suggestions for cleanup of that PR which he found while trying to use it in Angular Ng Workspaces. He'll add his feedback to the PR as a comment
No updates to share at this time. We'd still love feedback on what works for everyone, but it's unclear if there's any major improvements we can make in the DSpace code. It may instead need to be documentation of recommendations, once we have better established recommendations to share.
How to move this forward? Can we decide on where to redirect people if they encounter this scenario?
You shouldn't be sent back to the registration page if you login from that page. We agree that it should instead be: either you are shown a 404 page (with link to homepage) or you should just be redirected to the homepage. No strong opinions on which is better
This bug also impacts the "forgot password" page. If you login from that page, you should not be sent back to it.
Francesco has claimed and will create a solution PR
One example of how it was reproduced is listed. However, it's difficult to reliably reproduce, only happens occasionally. May be related to the "auto save" feature.
Sounds similar to some other bugs in the submission form in the past...where the form state in the frontend & backend can get out of sync. We've fixed many of these, but this sounds like another one.
We need to see if we can find a way to reliably reproduce this bug to narrow it down. If anyone finds a way, please document it in the ticket.