To quickly find PRs assigned to you for review, visit https://github.com/pulls/review-requested (This is also available in the GitHub header under "Pull Requests → Review Requests")
Deadline is TBD for 9.2, 8.3 and7.6.5. Bug fix releases do not have fixed/scheduled deadlines.Instead, the developer team will determine when to create a release based on the significance of the issues to solve. (e.g. If major issues are fixed, then a bug fix release will occur more rapidly. If minor issues are found, then a bug fix release may be delayed until sufficient fixes have been made to warrant a release)
Bug/security fixes only. These minor releases will not include any new features.
New "themeable components" (for dspace-angular) are allowed in bug fix releases, provided that they don't significantly modify component behavior or similar.
Accessibility fixes are also allowed in bug fix releases, provided they don't significantly modify component behavior or similar.
Bug fix PRsshould be created against "main" branch where possible. The "main" branch has the most strict code style rules. (i.e. PRs created against dspace-7_x are becoming more difficult to port forward.)
Per our support policy, bug fixes are only guaranteed to be ported back to 9.x. That said, where possible, we'll try to backport bug fixes (especially significant ones) to 8. x and 7.6.x.
Try "Pull Request Trading" for a quicker review
Do you have a PR stuck in "under review" that you really want to see move forward? Or maybe it's someone else's PR but you want to get it more attention?
When the list of collections is very large, this endpoint slows things down significantly
Paulo has created a PR that removes the endpoint to test whether this improves performance
Improvements seem significant; load times went down from ca. 1 minute to ca. 200ms
If anyone wants to help look at this problem or if anyone knows why we embedded this in the submission definition in the first place, please reach out
Giuseppe thinks this is connected to switching from one collection to another in the submission form
Need to double check if this is the place where it is used
Instead of removing the endpoint, could we stop the embed by default and make it optional?
First need to see how it behaves with hundreds of collections; better to have the form load quickly and load the collections in a different call?
Another option is to just follow the link when the site is loaded – why do we need to have all the definition objects load in the workflow process? This is currently unclear
Kim will help take a look at this; Paulo, Giuseppe also added as assignees on the ticket
Upcoming Topics
Migration to NX
First PR that is coming soon is just restructuring things, second PR will be NX migration
Once first PR is ready to go, assign to Tim, he can review that quickly; if anyone interested in testing, please let Tim or Giuseppe know; we aim at discussing this next week
2nd PR: 4Science will open two PRs for NX; one standalone application and a different PR with monolithic approach (allows for multiple applications in same project)
We can then decide which approaches works better for us