2018-02-01 DSpace 7 Working Group Meeting notes

Date

01 Feb 2018

Discussion (combined Angular UI & REST meeting)

Attendees

• Andrea Bollini (4Science)
• Art Lowel (Atmire)
• Giuseppe Digilio (4Science)
• Patrick Trottier
• Tim Donohue
• Mark H. Wood
• Nelson Torres

Location: DSpace Meeting Room

Notes

• DSpace 7 Planning discussion
  
  • Planning Spreadsheet status checks: https://docs.google.com/spreadsheets/d/18brPF7cZy_UKyj97Ta44UJg5Z8OwJGi7PLoPJVz-g3g/edit?usp=sharing
    • Tim wants to share with Steering Group at next week's meeting (Weds, Feb 7)
    • Art says the Angular side is looking good.
    • ACTION (Andrea): Andrea will review on Fri or over weekend. Will also update Angular work on Submission & Workflow sections
• Angular UI Team updates (via Art)

  • Angular 5 upgrade: https://github.com/DSpace/dspace-angular/pull/214  Reviewed & approved by William Welling.

    • ACTION (Tim and Patrick): Test code so we can get this merged

  • Angular 5's Transfer State API: https://github.com/DSpace/dspace-angular/pull/220  Also reviewed/approved by William
    • ACTION (Anyone): Quick code review and then merge
  • Art also updated the Angular 5 Rxjs ticket with more examples: https://github.com/DSpace/dspace-angular/issues/201
  • Giuseppe described the issues he was seeing in two tickets (See also last week's meeting notes).  Art is looking at both
    • Possible fix for first issue: https://github.com/DSpace/dspace-angular/pull/219
    • Art is still investigating the other (PR in near future): https://github.com/DSpace/dspace-angular/issues/217
  • Art will be working on hooking the Search UI up to the Search REST Endpoint
    • • Andrea is waiting on this work, as it will be useful for the UI of the MyDSpace page (which will be search oriented)
      • Andrea also looking for feedback on the Search REST contract. Are there any updates needed?
      • Art notes he feels he'll have an early PR in next few weeks. Not sure if ready by next week though
      • ACTION (Tim): Tim to add this to next week's agenda as a reminder to touch back in.
      • ACTION (Art): Art will work on this in coming weeks and report back if he discovers changes in contract are necessary.
  • Lotte is still working on search page truncation. Currently writing tests to ensure coverage doesn't drop.  PR should be coming soon.
  • Giuseppe is working on UI level authentication by password.  Just beginning

• REST API Updates (from Andrea)
  • Large number of pull requests open now. https://github.com/DSpace/DSpace/pulls?q=is%3Apr+label%3A%22REST+API+v7%22+is%3Aopen
    • ACTION (Anyone): Could use help reviewing and moving these along.
  • Submission PR is ready to merge: https://github.com/DSpace/DSpace/pull/1929
  • After that, these three PRs are smaller, and seem to be mergeable quickly:
    • https://github.com/DSpace/DSpace/pull/1936
    • https://github.com/DSpace/DSpace/pull/1931
    • https://github.com/DSpace/DSpace/pull/1898
  • Shibboleth work from Terry is WIP (Tom providing feedback)
    • https://github.com/DSpace/DSpace/pull/1927
  • Exposing Configuration values in REST API (early discussion PR from Terry)
    • https://github.com/DSpace/DSpace/pull/1928
    • Terry updated the ticket at  Unable to locate Jira server for this macro. It may be due to Application Link configuration.  (per last week's discussion)
    • Andrea updated the PR to note it's still a WIP, based on last week's feedback
    • May also have a small dependency on the Spring Security work
  • Citation Page support for REST API: https://github.com/DSpace/DSpace/pull/1939
    • Andrea glanced at. Looks good overall, though not sure about modifying the default bitstream endpoint
    • Andrea notes that even with Citation Pages turned "on", an Administrator should be able to access the original PDF (e.g. from Admin UI), just like currently
    • This implies we'd need either two endpoints, or a parameter, or similar
  • Getting Legacy REST app working again: https://github.com/DSpace/DSpace/pull/1930
    • Unsure of the priority of this. Do we need to even apply the work around now, or just note that the legacy REST app won't be fixed until we fix the SolrLoggerUsageEventListener.
    • ACTION: Talk to Terrence W Brady about this. If it's a high priority, we can just merge 1930. Otherwise, we should find someone to dig in a bit more and just fix the issues with SolrLoggerUsageEventListener.
  • Spring REST docs: https://github.com/DSpace/DSpace/pull/1915
    • PR seems to be stalled
    • Andrea would really like to see an early version of this get into the codebase "soon", even if it's not perfect.
    • ACTION (Art): will ping Tom Desair on this to get current status.
  • Spring Security work: https://github.com/DSpace/DSpace/pull/1916
    • Same thing, seems stalled
    • Again, an early version of this would be great to get into the codebase soon.  Other features will surely want to use Spring Security, if we can get this even minimally working. (e.g. the Configuration endpoint work in https://github.com/DSpace/DSpace/pull/1928 would likely benefit heavily from Spring Security)
    • ACTION (Art): will ping Tom Desair on this to get current status.
  • Quick updates from others
    
    • Mark has nothing to report. Has been doing good work though on fixing dependency issues on master, see e.g. https://github.com/DSpace/DSpace/pull/1940 and https://github.com/DSpace/DSpace/pull/1936
    • Patrick is still looking at getting environment setup. Will report back on progress. Has been pulled onto other high priority work locally, and will let us know when he has time again.
    • Nelson has nothing to report right now
• Next Meeting will be Thurs, Feb 8 at 15:00UTC in DSpace Meeting Room