Previous i18n Sprints

Sprint - i18n Editing

What

The primary objectives of this sprint are:

  • finalize VIVO's i18n implementation, and
  • prepare for the upcoming 1.12 release candidate

When

Who

  1. Andrew Woods
  2. Michel Héon
  3. Alexander (Sacha) Jerabek
  4. Sandra Mierz
  5. Benjamin Kampe
  6. Brian Lowe
  7. Ralph O'Flinn
  8. Nicolas Dickner
  9. Benjamin Gross
  10. Dominik Feldschnieders
  11. Matthias Lühr

Resources

Stand-up Reports

2021-01-29 (Friday)

Michel Héon  5:04 AM
[VIVO i18n Standup]
Finished yesterday: 
     - Finishing the work of https://jira.lyrasis.org/browse/VIVO-1863
Working on today:
    - Making PR for integration of the new regreg-test for https://jira.lyrasis.org/browse/VIVO-1863
    - Starting work on https://jira.lyrasis.org/browse/VIVO-1898 with the new vivo-regression-test after PR-11 + new integration of VIVO-1863 are made
    - Work on https://jira.lyrasis.org/browse/VIVO-1954 
Blockers:
    - Merging VIVO-1863 vivo-regression-test to master PR-11


Brian Lowe  5:54 AM
[VIVO i18n Standup]
Finished yesterday: 
     - Got non-destructive multilingual editing and filtering working with display model (part of VIVO-1947)
Working on today:
    - Looking at a few bugs that surface on some ontology editor forms when you use the request's WebappDaoFactory.  Then rest of final testing / PR for VIVO-1947.


Sandra Mierz  5:57 AM

[VIVO i18n Standup]
Finished yesterday:
- skipped
Working on today:
- [1928] asking the general channel again for portuguese proofreading
- [1928] changed the spanish translations based on Anas proofreading (Thanks Ana!)
Blockers:
- portuguese proofreading

Nicolas Dickner  8:43 AM
[VIVO i18n Standup]
Finished yesterday:
-
Working on today:
- https://jira.lyrasis.org/browse/VIVO-1877
- https://jira.lyrasis.org/browse/VIVO-1822
- https://jira.lyrasis.org/browse/VIVO-1814
Blockers:
- Have to figure why js_string method just won't work in VIVO-1814

Ralph O'Flinn  8:50 AM
[VIVO i18n Standup]
Finished yesterday:
PR11 Conflict Resolving and Merge
Working on today:
Now back to:
https://jira.lyrasis.org/browse/VIVO-1762
Working through the great info in Michel's page.
Breaking out the common dev setup from internationalization
Removing external references
Adding back standard VIVO terms and paths
Blockers:
Life in general!

William Welling  8:51 AM
[VIVO i18n Standup]
Finished yesterday:
- Addressed concerns with VIVO-1443: Decouple VIVO build from installation
1. third-tier build, overlay VIVO home directory
i. https://github.com/awoods/vivo-custom-webapp/pull/2
Working on today:
- VIVO-1929: Site Admin users cannot create new individuals via the GUI
- Marshalling along VIVO-1443 if necessary
Blockers:
Permission issue for Site Admin while evaluating action through EditRequestDispatchController.

Benjamin Kampe  9:13 AM
[VIVO i18n Standup]
Finished yesterday:
- cleaned up some git things
- finally got VIVO-1852 finished
- created follow-up on VIVO-1936
Working on today:
-
Blockers:
- dayli business and homeschooling

awoods  9:32 AM
[VIVO i18n Standup]
Finished yesterday:
  - Some reviews / merges
Working on today:
  - Finalizing all In-Review tickets
Blockers:
  - None

2021-01-28 (Thursday)

Benjamin Kampe  3:45 AM

[VIVO i18n Standup]
Finished yesterday: 
- created some wierd git stuff
- nearly completed VIVO-1852, but somehow added a wrong branch
- fixed my mail forwarding (didn't get the github mails before)
Working on today:
  - try to clean up the git things
Blockers:
  None

Ralph O'Flinn  3:57 AM
[VIVO i18n Standup]
Finished yesterday:
https://jira.lyrasis.org/browse/VIVO-1762
Working on today:
https://jira.lyrasis.org/browse/VIVO-1762
Working through the great info in Michel's page.
Breaking out the common dev setup from internationalization
Removing external references
Adding back standard VIVO terms and paths
Blockers:
None.


Sandra Mierz  4:01 AM
[VIVO i18n Standup]
Finished yesterday: 
- [VIVO-1948] i18n - create German version of sample-data
Working on today:
  - skipping today for PIDapalooza
Blockers:
  Waiting for spanish & portuguese proofreading for [VIVO-1928] offered in general channel


Dominik  4:08 AM

[VIVO i18n Standup]
Finished yesterday: 
- reproduced and found the problem with VIVO-1879
Working on today:
  - VIVO-1879 - i18n Autocomplete not taking linguistic context into account
Blockers:
  - not sprint related stuff


Michel Héon  4:30 AM
[VIVO i18n Standup]
Finished yesterday:
- VIVO-1863 vivo-regression-test
- VIVO-1984 PR-6 Merging new i18n sample-ontologies to sample-data/i18n repository
Working on today:
- Start the work of https://jira.lyrasis.org/browse/VIVO-1863 and https://jira.lyrasis.org/browse/VIVO-1898 with the new vivo-regression-test
Blockers:
- Merging VIVO-1863 PR-11 vivo-regression-test to master


Brian Lowe  5:52 AM
[VIVO i18n Standup]
Finished yesterday:
Nothing concrete, unfortunately: attention too divided.
Working on today:
Focusing on getting VIVO-1947 ready for testing (preventing labels in other languages from being deleted when you edit); testing update to pull request on VIVO-1443 (decoupling build)
Blockers:
None.

Nicolas Dickner  8:01 AM
[VIVO i18n Standup]
Finished yesterday:
https://jira.lyrasis.org/browse/VIVO-1842
https://jira.lyrasis.org/browse/VIVO-1809
lost some time on issue already fixed by wwelling (VIVO-1853)
Working on today:
https://jira.lyrasis.org/browse/VIVO-1877
Possibly fr_CA rdf files (duplicate triplets / files, etc)
Blockers:
Tricky lowercasing in freemarker file
Located bugs in https://jira.lyrasis.org/browse/VIVO-1792 and https://jira.lyrasis.org/browse/VIVO-1808 (see comments) but had to leave it to someone with java skills.

awoods  9:22 AM
[VIVO i18n Standup]
Finished yesterday:
- Some reviews / merges
Working on today:
- Moving tickets forward
Blockers:
- 3 hours of meeting from 10am - 1pm ET

Matthias Lühr  11:01 AM

[VIVO i18n Standup]
Finished yesterday:
  - improved PR VIVO-1816
Working on today:
  - musing over VIVO-1921
Blockers:
  - None

Benjamin Gross  11:04 AM
[VIVO i18n Standup]
Finished yesterday:
- [VIVO-1805] - Further i18n for BasicValidationVTwo.java
Working on today:
- VIVO-1950 - basic solution works, trying to tease out all references to Google viz library
Blockers:
- None

2021-01-27 (Wednesday)


Brian Lowe  3:44 AM

[VIVO i18n Standup]
Finished yesterday:
Investigated generalization of problem described in VIVO-1947 (adding label in one language deletes labels in all other languages) to any other properties editable through N3 editing forms. Have what appears to be a working general solution.
Working on today:
Continuing with VIVO-1947 and related refactoring, unit tests, packaging.
Blockers:
None.

Sandra Mierz  4:01 AM
[VIVO i18n Standup]
Finished yesterday:
- Portuguese part
Working on today:
- VIVO-1928-Spanish and Portuguese language files missing translation of ORCID related messages
- proofreading & testing
Blockers:
- None

Dominik  4:03 AM
[VIVO i18n Standup]
Finished yesterday:
- VIVO-1924 - @en i18n properties are not loaded during first site startup.
Working on today:
- VIVO-1879 - i18n Autocomplete not taking linguistic context into account
Blockers:
- None

Michel Héon  6:27 AM
[VIVO i18n Standup]
Finished yesterday:
- Merging of various vivo-regression-test PRs
- Fixed bugs and added processing of de_DE and fr_FR in vivo-regression-test
Working on today:
- Do a new vivo-regression-test PR to merge corrections to master branch
- Start the work of https://jira.lyrasis.org/browse/VIVO-1863 and https://jira.lyrasis.org/browse/VIVO-1898 with the new vivo-regression-test
- Merging new ontologies to sample-data/i18n repository
Blockers:
N/A

Nicolas Dickner  7:34 AM

[VIVO i18n Standup]
Finished yesterday:
    https://jira.lyrasis.org/browse/VIVO-1818
    https://jira.lyrasis.org/browse/VIVO-1796
    https://jira.lyrasis.org/browse/VIVO-1875Working on today:
https://jira.lyrasis.org/browse/VIVO-1822
https://jira.lyrasis.org/browse/VIVO-1809
...
Blockers:
None

Benjamin Kampe  8:23 AM
[VIVO i18n Standup]
Finished yesterday: 
-
Working on today:
  - VIVO-1852 - Minor changes to the translation in the entry page "Research"
Blockers:
  None

William Welling  8:59 AM
[VIVO i18n Standup]
Finished yesterday:
- Nada
Working on today:
- VIVO-1443: Decouple VIVO build from installation
Blockers:
- FOLIO
- motivation

Benjamin Gross  9:19 AM
[VIVO i18n Standup]
Finished yesterday:
- [VIVO-1798] - Internationalize first and last name validation
[VIVO-1825] - Remove outdated addAssociatedConcept file
[VIVO-1805] - Further i18n for BasicValidationVTwo.java
Working on today:
- VIVO-1950
Blockers:
- Need feedback on German and French strings for 1798 and 1805 prior to merging

awoods  9:21 AM
[VIVO i18n Standup]
Finished yesterday:
- Some reviews / merges
- Resolved: i18n - Parameterize regression-test configuration elements
- https://jira.lyrasis.org/browse/VIVO-1951
Working on today:
- Continuing with next regression-test PR to test/review/merge
- Moving tickets forward
Blockers:
- None

Ralph O'Flinn  9:58 AM
[VIVO i18n Standup]
Finished yesterday:
https://jira.lyrasis.org/browse/VIVO-1762
Working on today:
https://jira.lyrasis.org/browse/VIVO-1762
Blockers:
So far so good

Matthias Lühr  11:22 AM

[VIVO i18n Standup]
Finished yesterday:
  - VIVO-1816
Working on today:
    - small corrections on PR for VIVO-1816
    - continuing work on VIVO-1921
    - having a look at VIVO-1802
Blockers:
  - None

2021-01-26 (Tuesday)

Sandra Mierz  4:03 AM

[VIVO i18n Standup]
Finished yesterday:
- Spanish part
Working on today:
- VIVO-1928-Spanish and Portuguese language files missing translation of ORCID related messages
- Portuguese part
Blockers:
- None

Brian Lowe  4:04 AM

[VIVO i18n Standup]
Finished yesterday: 
  1. Have fix for main cause of bug in VIVO-1947

(editing labels in one language deletes labels in all other languages, in certain cases e.g. ontology editor).  Also looked at VIVO-1924 (some i18n properties not loaded until i18n cache is forcibly cleared): added comments to issue.
Working on today:
  1. Continuing (with luck, maybe finishing) VIVO-1947. Adding unit tests now and checking for similar bugs in other areas so that we can hopefully take care of them all on one ticket.

Blockers:
None

Dominik  4:23 AM
[VIVO i18n Standup]
Finished yesterday:
- N/A
Working on today:
- VIVO-1924 - @en i18n properties are not loaded during first site startup. (implement brian's suggestion)
- grab a new ticket
Blockers:
- could not reproduce VIVO-1924, but the community is always happy to help :)

Benjamin Kampe  5:00 AM
[VIVO i18n Standup]
Finished yesterday: 
- Some more setup of i18n Dev-Environment
- VIVO-1936 - i18n: Remove language flag images
Working on today:
  - VIVO-1852 - Minor changes to the translation in the entry page "Research"
Blockers:
  None

Michel Héon  5:50 AM
[VIVO i18n Standup]
Finished yesterday:
Adaptation of the Selenium test bench in order to process https://jira.lyrasis.org/browse/VIVO-1863 (Menus are presented in French Canadian in the en_CA context)
Working on today:
- Available to support the resolution of https://jira.lyrasis.org/browse/VIVO-1885 and https://jira.lyrasis.org/browse/VIVO-1894
- Apply the Selenium test for the resolution of https://jira.lyrasis.org/browse/VIVO-1863
Blockers:
@awoods Yes I need help for managing the PR5 conflict.

awoods  9:11 AM
Finished yesterday:
  - Reviewed and commented on several tickets
  - Unable to reproduce vivo-1924 (@en i18n properties are not loaded during first site startup.)
  - Created JIRA: i18n - create German version of sample-data
    - https://jira.lyrasis.org/browse/VIVO-1948
  - Reviewed: https://github.com/vivo-community/vivo-regression-tests/pull/5
Working on today:
  - Helping with merge conflict in: regression-test pull-request
    - https://github.com/vivo-community/vivo-regression-tests/pull/5
  - Potentially helping @Matthias Lühr with: i18n: tabs on profile page unclickable after deleting an entry
    - https://jira.lyrasis.org/browse/VIVO-1816
  - Exploring simplification of setting up / running regression tests
Blockers:
  - None, but
    - @Nicolas Dickner: can you re-verify and provide details on: https://jira.lyrasis.org/browse/VIVO-1829
    - @Matthias Lühr: Are you interested in surfacing the deeper root cause of:
      - https://jira.lyrasis.org/browse/VIVO-1816


William Welling  9:13 AM
[VIVO i18n Standup]
Finished yesterday:
- VIVO-1857: Minor changes to the translation in the edition page "Articles"
I believe this resolves VIVO-1853 and all its subtasks?!
https://github.com/vivo-project/Vitro-languages/pull/35
https://github.com/vivo-project/VIVO-languages/pull/81
https://github.com/vivo-project/Vitro/pull/198
Working on today:
- VIVO-1813: i18n: 'Failed to parse query' error on Service > add 'outreach and community service activities'
Blockers:
distraction

Alexander Sacha Jerabek  9:20 AM
[VIVO i18n Standup]
Finished yesterday:
N/A
Working on today:
- review Admin area
Blockers:
N/A

Ralph O'Flinn  9:28 AM
[VIVO i18n Standup]
Finished yesterday:
N/A (Wife had back surgery. Limited Wi-Fi at hospital.)
Working on today:
https://jira.lyrasis.org/browse/VIVO-1762
Blockers:
None.


Nicolas Dickner 9:30 AM
[VIVO i18n Standup]
Finished yesterday:
 - https://jira.lyrasis.org/browse/VIVO-1797
Working on today:
- https://jira.lyrasis.org/browse/VIVO-1796
- https://jira.lyrasis.org/browse/VIVO-1818
- https://jira.lyrasis.org/browse/VIVO-1875
- https://jira.lyrasis.org/browse/VIVO-1853
- Might give https://jira.lyrasis.org/browse/VIVO-1879 a try

Blockers:
N/A

Benjamin Gross  10:45 AM
[VIVO i18n Standup]
Finished yesterday:
[VIVO-1831] - Remove duplicate text from dropdown menus
[VIVO-1949] - Fix external AGROVOC and LCSH service URLs
Fix for RDF error introduced in 60933a5
Reviewed and closed VIVO-1829
Working on today:
https://jira.lyrasis.org/browse/VIVO-1798
Maybe VIVO-1856
Blockers:
None.

2021-01-25 (Monday)

Brian Lowe  3:45 PM
[VIVO i18n Standup]
Finished yesterday: 
N/A
Working on today:
VIVO-1947
i18n: Editing labels deletes all other labels in certain cases. Backend editing forms include calls to ModelAccess.on(context) which defaults to English, when they should be using ModelAccess.on(request).  DAOs used by backend include calls to Jena's setLabel(string, language), which (per Javadoc) deletes the labels in the other languages.  Will need to be replaced.
Blockers:
None. (edited) 


Ralph O'Flinn  9:32 PM
[VIVO i18n Standup]
Finished yesterday:
    N/A
Working on today:
    Setup of Dev Enviro for i18n complete! :)
Blockers:
    None.


Benjamin Kampe  3:39 AM
[VIVO i18n Standup]
Finished yesterday: 
        Completed setup of i18n Dev-Environment
Working on today:
        VIVO-1936 - i18n: Remove language flag images
        Warm-up ticket - The flag images can now be removed
Blockers:
        None (edited) 



Dominik  3:50 AM
[VIVO i18n Standup]
Finished yesterday:
    N/A
Working on today:
    Complete setup of i18n Dev-Environment
        Unable to locate Jira server for this macro. It may be due to Application Link configuration. - @en i18n properties are not loaded during first site startup.
Blockers:
    None


Michel Héon  6:24 AM
[VIVO i18n Standup]
Finished yesterday: 
    Implementation of the Sillenium test environment in UQAM-DEV in preparation of the sillenium tickets to be resolved
Working on today:
    - Available to support the resolution of https://jira.lyrasis.org/browse/VIVO-1885 and https://jira.lyrasis.org/browse/VIVO-1894
    - Begin execution of Sillenium tests on the i18n code segment integrated into VIVO.  https://jira.lyrasis.org/browse/VIVO-1898 see also https://wiki.lyrasis.org/display/VIVO/i18n+Update+list+to+be+merged+to+master
    - Apply the Sellenium test for the resolution of https://jira.lyrasis.org/browse/VIVO-1863
Blockers:
   N/A


William Welling  9:09 AM
[VIVO i18n Standup]
Finished yesterday: 
  N/A
Working on today:
  - Attend VIVO spring kickoff meeting
  - VIVO-1857 Minor changes to the translation in the edition page "Articles"
  - Playing softball for a bit with other trivial issues
Blockers:
  N/A


[VIVO i18n Standup]
Finished yesterday: 
  - Laundry
Working on today:
  - Setting up regression-test framework. Related to: 
    - https://jira.lyrasis.org/browse/VIVO-1801 (Selenium regression test)
    - https://jira.lyrasis.org/browse/VIVO-1894 (i18n: Selenium test Vivo-i18n_en_US equal Vivo_orig)
  - Helping establish a plan for use of regression-test as project infrastructure
  - Reviewing completed tickets / Providing feedback
  - Investigating
  - Will take on of the 'Major' bugs based on this morning's kickoff meeting
Blockers:
  - None


Nicolas Dickner

Finished yesterday: 

  N/A

Working on today:

    https://jira.lyrasis.org/browse/VIVO-1796
  https://jira.lyrasis.org/browse/VIVO-1797
  https://jira.lyrasis.org/browse/VIVO-1818

Blockers:

  N/A


Matthias Lühr  11:00 AM
[VIVO i18n Standup]
Finished yesterday:
  - Sunday
Working on today:
    - updated repos
    - got development environment up and running
    - investigating on VIVO-1816
Blockers:
  - None

  • No labels