2019-06-20 DSpace 7 Working Group Meeting

Date

20 Jun 2019 from 14:00-15:00 UTC

Location: https://duraspace.zoom.us/my/dspace (Meeting ID: 502 527 3040).

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  
  1. OR2019 - How did it all go?  Any feedback or updates to bring back to the team?
  2. Updates from DSpace 7 Entities Working Group (2018-19)
     1. All Entities PRs will now go against the "master" branch and appear in this group's list of PRs (see below).  However, detailed Entities design discussion will take place in Entities Working Group meetings.  So, if you want to take part in the design or have questions, please join us in our working group meetings (now weekly, every Tues at 15UTC). 
     2. FYI, looking to enhance the "submission-forms.xml" structure to support two types of "fields".
        1. <metadata-field> - A simple rename of the existing <field> tag to clarify that this is a metadata entry field, e.g. https://github.com/DSpace/DSpace/blob/master/dspace/config/submission-forms.xml#L52-L61
        2. <relation-field> - A new type of field that will define a relationship between two Entities.  This field type may also optionally capture metadata, if the form field supports either defining a relationship or capturing a plain text value (e.g. an Author field would support linking to Person Entities or capturing plain text author names)
        3. While we are at it, we may also want to change <dc-schema> to just <schema> and <dc-element> to just <element>, etc.
  3. Improved Estimation Strategy for Beta release. (Estimates should include time for discussion / code reviews, also should be done by multiple developers)
     1. Development Planning Spreadsheet needs to be updated, so that we can determine what (outstanding) tasks need estimation.
     2. Will be using Wideband Delphi estimation technique
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • Next tasks from Development Planning Spreadsheet

Attendees

• Art Lowel (Atmire) 

• Andrea Bollini (4Science) 

• Tim Donohue

• Heather Greer Klein

• Lieven Droogmans

• Mark H. Wood
• Giuseppe Digilio (4Science)
• Ben Bosman
• Pascal-Nicolas Becker
• Chris Wilper
• Terrence W Brady
• Pablo Prieto
• Paulo Graça 
• Bill Tantzen

Current Work

Tickets / PRs In Progress

1. (Angular) Adding Accessibility via Travis CI  https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
2.  (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
3. (REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman  - has outstanding questions/comments) (Lower priority)
4. (REST) DS-4043: Revisit the security layer of the submission  (work in progress) Andrea Bollini (4Science)
5.  (REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Waiting on updates fromBen Bosman )
6.  (REST) Pagination issues on Items findAll - https://github.com/DSpace/DSpace/pull/2406 (Waiting for confirmation of proposed approach by Andrea Bollini (4Science) from  Kevin Van de Velde (Atmire)  and any other interested/available )
7. (Backend) DS-4257: Renaming "dspace-spring-rest" to "dspace-server" (Tim Donohue).  (Timeline: Not likely to be completed until after OR2019)

8. (NEW) (REST) DS-4269 Incorrect hal pagination links in the browses endpoint https://github.com/DSpace/DSpace/pull/2444 (Tim Donohue  , Terrence W Brady )
   

9. (NEW) (Angular) Shibboleth Login https://github.com/DSpace/dspace-angular/pull/417 (there are TravisCI errors)

10. (Angular) Transfer to .po message format - Initial PR: https://github.com/DSpace/dspace-angular/pull/366 (Paulo Graça ,   Tim Donohue , Art Lowel (Atmire) )

PRs Needing Review

1. (REST Contract) (Entities) PUT contract in relationships: https://github.com/DSpace/Rest7Contract/pull/60 (Tim Donohue , Paulo Graça  )

2. (NEW) (REST Contract) upload bitstream to archived item - https://github.com/DSpace/Rest7Contract/pull/61 (Andrea Bollini (4Science), Tim Donohue)

3. (NEW) (REST Contract) Updating submissionforms sample output with actual data - https://github.com/DSpace/Rest7Contract/pull/62  (Andrea Bollini (4Science), Tim Donohue)
4. (NEW) (REST Contract) Collecting statistics - https://github.com/DSpace/Rest7Contract/pull/63 (Dimitris Pierrakos, Andrea Bollini (4Science))
5. (REST) Refactor PatchBadRequestException to DSpaceBadRequestException and fix improper 500 response errors: https://github.com/DSpace/DSpace/pull/2403 (Paulo Graça , Andrea Bollini (4Science) )
6. (UPDATED) (REST) DS-4210 Deposit on collection without workflow seems to fail (405 but succeed) (work in progress - Needs support on identify failure on the test env will be appreciated): https://github.com/DSpace/DSpace/pull/2429 (Chris Wilper , Tim Donohue )
7. (REST) Updating Owning Collections (Moving Items between collections): https://github.com/DSpace/DSpace/pull/2283 (Tim Donohue , Ben Bosman )
8. (REST) Item Mapper functionality: https://github.com/DSpace/DSpace/pull/2282  (Tim Donohue , Ben Bosman )
9. (REST) (Entities) PUT contract in relationships: https://github.com/DSpace/DSpace/pull/2440 (related to Contract PR#60) (Paulo Graça , Tim Donohue )
10. (NEW) (REST) (Entities) DS-4223 Metadata Schemas for configurable entities https://github.com/DSpace/DSpace/pull/2443 (Paulo Graça, Mark H. Wood )
    
11. (NEW) (Higher priority) (REST) [DS-4266] bitstream format registry https://github.com/DSpace/DSpace/pull/2442 (Ben Bosman, Andrea Bollini (4Science))
12. (NEW) (REST) (Entities) DS-4244 Add configurable entities unit tests https://github.com/DSpace/DSpace/pull/2446
13. (NEW) (REST) (Entities) Relationship search by label: https://github.com/DSpace/DSpace/pull/245 (Tim Donohue)
14. (Angular) (Entities) Deleting relationships: https://github.com/DSpace/dspace-angular/pull/402 (Paulo Graça - changes requested, Tim Donohue )
15. (Angular) Switch to using HAL links for entity relationships https://github.com/DSpace/dspace-angular/pull/408 (Dependent on PR#401) (Paulo Graça , Tim Donohue )
16. (Angular) Selectable Themes. https://github.com/DSpace/dspace-angular/pull/419 (Paulo Graça , Tim Donohue)
17. (NEW) (Angular) (Entities) DS-4223 Metadata Schemas for configurable entities https://github.com/DSpace/dspace-angular/pull/420 (Paulo Graça)
18. (NEW) (Angular) Configurable browse-by https://github.com/DSpace/dspace-angular/pull/421 (closes #361) (Tim Donohue , Paulo Graça ,Giuseppe Digilio (4Science))
19. (NEW) (Angular) Revert erroneous change https://github.com/DSpace/dspace-angular/pull/425 (Giuseppe Digilio (4Science), Tim Donohue)
20. (Unblocked) (Angular) Move Item Component: https://github.com/DSpace/dspace-angular/pull/335
    1. Was blocked by DSpace PR#2283
21. (Unblocked) (Angular) Item-Collection Mapper:  https://github.com/DSpace/dspace-angular/pull/348
    
    1. Was blocked by DSpace PR#2282
22. (Backend) Upgrading to Handle Server v9: https://github.com/DSpace/DSpace/pull/2394 (Mark H. Wood, Ben Bosman )
23. (Backend) Our extensive EHCache configuration is ignored: https://github.com/DSpace/DSpace/pull/2397 (Terrence W Brady ,  Tim Donohue, Chris Wilper ) 
24. (Backend) Minor dependency updates to "master": https://github.com/DSpace/DSpace/pull/2425 ( Mark H. Wood , Chris Wilper )
25. (Backend) Update email templates to use Velocity (for richer, powerful templates): https://github.com/DSpace/DSpace/pull/1992 (Chris Wilper , NEEDS SECOND REVIEWER)

PRs Merged this week!

1. (Angular) HIGH PRIORITY. https://github.com/DSpace/dspace-angular/pull/418 (Art Lowel (Atmire) - merged)

Blocked

1. (Blocked PRs go here)

Delayed

1. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
2. (REST) Scripts & Processes endpoint: https://github.com/DSpace/Rest7Contract/pull/17
3. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
   1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
   2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
   3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Priorities for Preview Release

As discussed in previous DSpace 7 meetings, our DSpace 7 Preview release is aimed for early May, followed by a Preview #2 in May (before OR2019).  The top priorities for the Preview Release are (in this order):

1. Submission & Workflow UI / backend 
2. Configurable Entities (from DSpace 7 Entities Working Group (2018-19))
3. Upgrading Solr Server for DSpace (not required for Preview, as there's no user facing features. However, the earlier we feel comfortable merging this effort the better)

Priorities for OR2019 revolve around features or needs that we want to show off in Workshops/Presentations. These include

1. Finalizing theming/branding strategy for new UI
2. DSpace Backend as One Webapp
3. Finalizing (as much as reasonable) the upgrade process (including Solr, Handle Server, etc)

Notes

• Initial Performance Testing from Chris
  • https://cwilper.github.io/dspace-perftest/

• Travis CI + Docker Compose for testing of Angular

  • Docs: https://docs.travis-ci.com/user/docker/#using-docker-compose
  • Blogpost on how to do it: http://elliot.land/post/using-docker-compose-on-travis-ci
  • An example travis.yml file: https://github.com/Ortus-Solutions/docker-buildfiles/blob/master/.travis.example.yml