Page History

...

• Should we attempt to move the "Content Reports" feature forward as a disabled-by-default, beta feature in 8.0? Or do we delay till 9.0?
  1. PRs: https://github.com/DSpace/DSpace/pull/8598 and https://github.com/DSpace/dspace-angular/pull/2163
  2. Strategy towards a "beta" feature:
     1. A configurable setting must be added so that the Reports feature can be enabled/disabled.
        1. (NEW) Ideally this would also include disabling the backend REST endpoints if this feature is disabled.  This could be optional, but may not be difficult to add. 
           1. An example of this is here: https://github.com/DSpace/DSpace/blob/main/dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ResearcherProfileRestRepository.java#L49
           2. That code will disable the Researcher Profile endpoints whenever the configuration "researcher-profile.entity-type" is unspecified or false.  See also other examples in the codebase of where @ConditionalOnProperty is used.
     2. Warnings must be added for DSpace users that want to enable the reports.
     3. All unit test errors from both PRs must be resolved. (Please note that, especially for the Angular layer, it may result in temporarily disabling a few failing tests.)
     4. The merge conflict of the backend PR must be resolved.
     5. Some feedback may not be addressable. Any non-addressable feedback will be turned into issue tickets.
     6. Feedback which will be resolved:
        1. NGRX : https://github.com/DSpace/dspace-angular/pull/2163/files#r1452584973
        2. Convert POST to GET: https://github.com/DSpace/dspace-angular/pull/2163/files#r1452562348
           1. (NEW)This move from POST to GET was also requested in the REST Contract feedback. So, it should be applied to the backend as a whole.
        3. CSS/bootstrap : https://github.com/DSpace/dspace-angular/pull/2163/files#r1452587904 and https://github.com/DSpace/dspace-angular/pull/2163/files#r1452569360
        4. (NEW) Andrea noted that we need to address the changes to ItemRest made by the backend PR: https://github.com/DSpace/DSpace/pull/8598/files#r1186856115
           1. These changes should not be added into DSpace as they bypass the usage of embedded content via Projections.  The normal way of obtaining the owning Collection via the Item endpoint would be to do something like this:  /server/api/core/items/<:uuid>?embed=owningCollection     That request would return the Item information with owning Collection information embedded.
     7. Feedback which will NOT be addressed in 8.0:
        1. Performance load issue cause of large page sizes: https://github.com/DSpace/dspace-angular/pull/2163/files#r1452576823 and minor one: https://github.com/DSpace/dspace-angular/pull/2163/files#r1452578972
        2. Move part of the code to a full-featured DataService: https://github.com/DSpace/dspace-angular/pull/2163/files#r1452562348
        3. CSV export of reports: https://github.com/DSpace/DSpace/pull/8598#issuecomment-156721566
        4. Using Solr instead of database for queries: https://github.com/DSpace/DSpace/pull/8598#pullrequestreview-1415912001
  3. Final VOTE: 
     1. Five +1 votes in favor of adding this to 8.0 as beta feature
     2. One -1 vote opposed. Prefer adding to 9.0
     3. One 0 vote.
     4. Vote passes.  This feature can be included in 8.0 as a "beta" feature provided the steps noted above are all resolved/addressed (except where noted that something will not be addressed)

...