Page History

...

• (BEFORE MEETING IN #dev-sprint) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 25 mins) General Discussion Topics
  
  • (10 mins) Establishing a Code Review guide (to train others on code reviews & good coding practices)
    • Making the PR Templates the definitive reference for reviewers (and developers)
      • Backend: https://github.com/DSpace/DSpace/blob/master/.github/pull_request_template.md#checklist
      • Frontend: https://github.com/DSpace/dspace-angular/blob/master/.github/pull_request_template.md#checklist
    • New Code Testing Guide to document how to write good tests (and therefore how to review for good tests)
  • Tabled Topics (will not be discussed this week, but possible for next week)(15 mins) Asking all developers to record estimated  PR "completion date" (PR deadline) for all beta 3 work in DSpace 7 Release Plan spreadsheet
    • Goal is to better track internal prioritization/resourcing & estimated progress on current beta release.
    • Also looking to potentially re-scope beta3 into what can be done by end of June.  Other tasks will move to beta4, as beta3 has gotten too large.
    • PR deadline should ideally be on a Tuesday (beginning of week).  This allows us to anticipate which weeks which PRs will be done, and attempt to assign code reviewers prior to the Thursday meeting.
  • Tabled Topics (will not be discussed this week, but possible for next week)
    Finalizing first two steps of BTE transition to Live Import
    
    • 7.0beta3: 

      Jira
      server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4514

       - Tim has documented a simplified initial implementation based on last week's discussion.
    7.0beta3: 

    Jira
    server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4515

     - Large areas of agreement documented in Tim's comment.  Andrea's estimates Angular UI: 1 day, REST API: 3-4 days
    • Finalize / approve the initial list of all authorization features which we should implement for the /api/authz/features REST endpoint.  This list of features should be limited to only features which are required to enable/disable User Interface functionality. (In other words, we can always add more features in the future.  We just need to approve the list necessary for 7.0)
      1. Review current spreadsheet (from Andrea Bollini (4Science) ) : https://docs.google.com/spreadsheets/d/1182LcD_WqIZRbUGWpLtBw0aOMR9jhbOVB7GZqtTpR9A/edit?usp=sharing 
         1. Art Lowel (Atmire) : I don't see any immediate issues with the current set of features, but I would prefer a consistent naming scheme. I'd use canDoSomething for everything
         2. Tim Donohue added possible renames of these features based on Art's idea (see cell comments in spreadsheet).  I like the "can[DoSomething]" naming scheme as well.
    • Proposal from Art Lowel (Atmire)on enhancing object cache in Angular UI.
• (35 (30 mins) Planning for next week
  
  • Assigning PRs for Review
  • (As necessary) claim tasks for next week from DSpace 7 Release Plan spreadsheet

...

• Art Lowel (Atmire) 

• Andrea Bollini (4Science)  

• Tim Donohue

• Lieven Droogmans 

• Giuseppe Digilio (4Science) 
• Ben Bosman
• Paulo Graça 
• Heather Greer Klein  

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

...

PRs Needing Review

1. (REST Contract) (beta 3) related to the scripts & processes PR above (related to PR 2648 below) Authorization for Downloads of restricted Bitstreams https://github.com/DSpace/Rest7Contract/pull/126 (Andrea Bollini (4Science)99  ( Tim Donohue -  minor question/feedback to address, Tim Donohue -  feedback) (Once contact is updated Tim Donohue will rereview and merge)
2. (NEW) (REST Contract) (beta 3) Refactoring Authority support  / value-pairs / controlled vocabularies: https://github.com/DSpace/Rest7Contract/pull/128 (Tim Donohue, SECOND REVIEWER WELCOME will rereview, Ben Bosman )
3. (REST Contract) Minor Logout changes to support Logout Page https://github.com/DSpace/Rest7Contract/pull/124 (Andrea Bollini (4Science) just a typo to fix) READY TO MERGE AFTER MEETING
4. (NEW) (REST) (beta3) Pre authorize annotations for subresources https://github.com/DSpace/DSpace/pull/2778 ( Craig Rosenbeck , Andrea Bollini (4Science) )
5. (REST) (beta3) New user registration & forgot password https://github.com/DSpace/DSpace/pull/2763 (Tim Donohue -  Needs major code cleanup, especially in ITsREREVIEW, Andrea Bollini (4Science) waiting for a better status before review REREVIEW)
6. (REST) (beta3) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - REREVIEW, Tim Donohue -  Needs to address feedback in original REST Contract, other minor feedback added REREVIEW after contract and merge)
7. (REST) (beta3) DS-4042: Fix implementation and add IT for wrong PATCH request in submission: https://github.com/DSpace/DSpace/pull/2760 (Tim Donohue -  minor feedback, ,  Ben Bosman REREVIEW)
8. (REST) (beta 3) CC License support: https://github.com/DSpace/DSpace/pull/2764 (Tim Donohue - REREVIEW , Craig Rosenbeck)(REST) (beta 4) Configuration property retrieval Rest endpoint/Google Analytics support: https://github.com/DSpace/DSpace/pull/2762 StatuscolourBluetitle1 approval (Tim Donohue - , Craig RosenbeckPER KEVIN'S QUESTION)
9. (REST) (beta 3) Performance issues with finding Collections a user can submit to  https://github.com/DSpace/DSpace/pull/2771 (Kevin Van de Velde (Atmire), -  minor feedback  Tim Donohue -  minor feedback - look at 4122 and make sure it has Kevin's details)
10. (NEW) (REST) (beta 3) DS-4486 Add support/tests for Collection/Community role-based groups for Community/Collection Admins https://github.com/DSpace/DSpace/pull/2774 (Kevin Van de Velde (Atmire) REREVIEW, Tim Donohue )
11. (Angular) (beta3) Scripts & Processes Admin UI https://github.com/DSpace/dspace-angular/pull/636 (Tim Donohue, Giuseppe Digilio (4Science), Craig Rosenbeck)
    1. Depends on REST PR #2648 (see above) 
12. (Angular) Add multi-field sorting https://github.com/DSpace/dspace-angular/pull/634 

    Status
    colour Blue title 1 approval

      (Giuseppe Digilio (4Science) feedback added, Tim Donohue -  questions on how to review/test. No specs in PR)(Angular) Fix issue with polyfill order in safari and firefox https://github.com/DSpace/dspace-angular/pull/689  StatuscolourBluetitle1 approval  (Paulo Graça, Tim Donohue )
13. (Angular) New User Registration https://github.com/DSpace/dspace-angular/pull/687 (Art Lowel (Atmire)  added feedback with a few UX suggestions that can move to a ticket, Giuseppe Digilio (4Science) better to test once REST PR is merged)
    1. Depends on REST PR #2763 (see above)
14. (NEW) (Angular) (beta3) Refactor registry service https://github.com/DSpace/dspace-angular/pull/697 (Tim Donohue will give quick second review, Giuseppe Digilio (4Science) REREVIEW)
15. (NEW) (Angular) (beta4) Fix context sensitive menus https://github.com/DSpace/dspace-angular/pull/700 (Giuseppe Digilio (4Science) , Tim Donohue will give second review)
16. (NEW) (Angular) (beta3) Fix issues with edit collection and community pages  Use external lib for file-size-pipe https://github.com/DSpace/dspace-angular/pullissues/698701 (

    Status
    colour Blue title 1 approval

     after build fix, Giuseppe Digilio (4Science) )
17. (Tim Donohue -  Minor update needed)NEW) (Angular) (beta3) CC License support https://github.com/DSpace/dspace-angular/pull/703 (Giuseppe Digilio (4Science) , Tim Donohue )
    1. depends on REST PR #2764
18. (Backend) (low priority) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 (Craig Rosenbeck, Tim Donohue - REREVIEW, others can take a look)
    
19. (Backend) (low priority) (tentative 7.2) DS-4440 GDPR - Anonymize Statistics Feature: https://github.com/DSpace/DSpace/pull/2692 (Andrea Bollini (4Science), Ben Bosman, Tim Donohue)  --nice to clear this one
20. (Backend) (low priority)  [DS-4149] porting XOAI additional indexer https://github.com/DSpace/DSpace/pull/2756 (Paulo Graça  feedback added, Andrea Bollini (4Science) )
21. (NEW) (Backend) [DS-3940] SHERPA v2 API (master port): https://github.com/DSpace/DSpace/pull/2773 (Andrea Bollini (4Science) feedback added, Kevin Van de Velde (Atmire)  feedback added)

PRs Needing Updates  / On Hold

1. (REST Contract) (beta 3) related to the scripts & processes PR above (related to PR 2648 below) (NEW) (Angular) BUG FIX https://github.com/DSpace/Rest7Contractdspace-angular/pull/99 (NEEDS UPDATES FROM Kevin Van de Velde (Atmire) ) (Andrea Bollini (4Science) -  REVIEWED, Tim Donohue )702

   Status
   colour Blue title 1 approval

    (Art Lowel (Atmire)) Tim Donohue to MERGE after meeting

PRs Needing Updates  / On Hold

1. (REST Contract) Language support on the backend (possible new cookie for Angular?) https://github.com/DSpace/Rest7Contract/pull/122 ( NEEDS UPDATES FROM Andrea Bollini (4Science) ) (Tim Donohue, Ben Bosman, Art Lowel (Atmire) )
2. (REST) (WAITING ON DISCUSSION, SEE 2020-05-18 DSpace 7 Transition BTE to Live Import Mtg) (tentative 7.1) [DS-4281]: Metadata suggestions in the live import https://github.com/DSpace/DSpace/pull/2712  (Tim Donohue , Andrea Bollini (4Science))
3. (REST) (WAITING ON DISCUSSION, SEE Controlled Vocabularies and Authority Control in DSpace 7) (beta 3) Controlled vocabularyMykhaylo Boychuk https://github.com/DSpace/DSpace/pull/2743 (REST Contract #120) (Tim Donohue, Kevin Van de Velde (Atmire) )
4. (Angular) (WAITING ON PROPOSAL FROM Art Lowel (Atmire) FOR RESOLVING CACHING MISBEHAVIOR IN SUBMISSION UI) Alternative links https://github.com/DSpace/dspace-angular/pull/652 (Giuseppe Digilio (4Science)  feedback added, Tim Donohue -  feedback added)

...

PRs Merged this week!

1.  (REST Contract) (beta 3) Authorization for Downloads of restricted Bitstreams https://github.com/DSpace/Rest7Contract/pull/126 
2.  (REST) Update JQuery and Toastr used in HAL Browser: https://github.com/DSpace/DSpace/pull/2769 

   Status
   colour Blue title 1 approval

3.  (REST) (beta 3)DS-4495 Restricted endpoints are sometimes the only HAL link path to public endpoints REST API v7 https://github.com/DSpace/DSpace/pull/2766 (Tim Donohue -  feedback added, Art Lowel (Atmire)  on the condition that Tim's comment is addressed) 
4.  (REST) (beta 4) Configuration property retrieval Rest endpoint/Google Analytics support: https://github.com/DSpace/DSpace/pull/2762

   Status
   colour Blue title 1 approval

    
5.  (Angular) Use external lib for file-size-pipe https://github.com/DSpace/dspace-angular/pull/698 

   Status
   colour Blue title 1 approval

6.  (Angular) Fix issue with polyfill order in safari and firefox https://github.com/DSpace/dspace-angular/pull/689 

   Status
   colour Blue title 1 approval

Blocked

1. (Blocked PRs go here)

...

1. Initial Performance Testing from Chris.  Needs revisiting / retesting prior to 7.0. 
   1. https://cwilper.github.io/dspace-perftest/
   2. These performance tests were run prior to the work on "projections" (to limit the data returned by the REST API).  Therefore, it is likely performance is much improved, but needs verification testing.
2. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.

Notes

• We will try the Tuesday PR deadline and see if it is helpful
• Greater focus on time for PR discussion was appreciated
• Agreed to add to DSpace 7 Release Plan spreadsheet the following:
  1. claiming unclaimed Beta 3 tickets (unclaimed could be moved to Beta 4);
  2. adding TUESDAY deadlines for PRs, so reviewers might be pre-assigned before the Thursday meeting
  3. adding estimates where they are missing (less important if there is a PR deadline added)