Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Trading PRs is also very beneficial to DSpace in general!  The more developers we have helping to test or review PRs, the more quickly those PRs can be merged into the codebase (once approved).  It also ensures that bugs may be found more quickly as different people test things in different ways.  

Do I need to be a Committer or "expert" developer?

No. Any developer can take part in Pull Request Trading.  Even if you are new to DSpace and just submitted your first PR, you are welcome to offer to trade reviews/testing with another developer.  PR trading can be used as a way to get more familiar with DSpace development & review processes in general.

How do I trade PRs with another developer?

...

  • If you review or test any two similar-sized PRs (of your choice), Tim will promise to review one PR of your choice as soon as possible. (Your chosen PR will go to the top of his "to do" list.)
    • PRs you review or test can be any PR on one of our active boards (currently 7.6.1 Board or 8.0 Board), provided the PR is of similar-size to your PR.
    • PRs you review or test must be from a developer at a different institution from your own.
    • Again, you must submit useful feedback on the PR you've reviewed/tested (via a comment on the PR or similar).  It can be positive or negative feedback (So, if you test it and it doesn't work for you, that still counts).
  • Once your reviews/testing is complete, message Tim via Slack or email (private messages are fine). Let him know which PRs you tested/reviewed & which PR you want him to review in exchange!  That PR will go to the top of his "to do" list.

...