Versions Compared

Old Version 4

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Holger Lenz

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

...

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

Housekeeping

  • Meeting time will remain at 15:00UTC until all countries have entered Daylight Savings Time
  • No meeting next week:  it's imperative that developers and reviewers keep on top of things

DSpace & DSpace-CRIS Merger

  • No updates at this point; the planning groups have started their work

9.0 Release

  • Deadline tomorrow: Feature PR and test deadline; this is a deadline for reviewers; please do at least a basic review/basic test until tomorrow, so that developers have enough time to incorporate feedback
  • PRs that haven't gotten a review yet need to get a review before end of day tomorrow (Friday)
  • We have a 9.0 wiki space
    • Feel free to draft up documentation to get things ready for Testathon
    • Right now, a copy of the 8.0 docs are in that space
  • High Priority Dependency / Feature PRs 
    • Top three have been merged, which has created merge conflict; thank you for cleaning those up
    • Remaining is
      • Refactor menu resolvers PR
        • Are trying to get this in; Giuseppe has already started to test this, should be ready to go soon
      • Migration to NX & refactor into libraries
        • Tim is leaning to wait until right after 9.0 until all the other features are taking care of; this affects a lot of code, we need to make sure we understand this well enough

Other topics

  • consider backporting of https://github.com/DSpace/dspace-angular/pull/3506 and https://github.com/DSpace/dspace-angular/pull/3997 to Dspace 8.x
    • Question: Why would we want this in DSpace 8? 
      • Because these changes will affect all the backporting we have to do in future releases; automatic backports will fail
    • Concern: these are going to be difficult, complex upgrades for sites with customization, as they touch a lot of code
    • Several committers expressed hesitancy to backport this to DSpace 8; might better to think of ways to make the backport easier for us, since main branch has converged quite a bit from DSpace 8
      • Could start development on 8 and forward port it to main
    • If you have any ideas how to improve porting between the two branches, please let Tim know

Board Review

  •  PRs in "needs reviewer assigned" column will most likely get dropped - no one has volunteered to review or developer has not responded to reviews
  • #10129
    • Needs a reviewer, has merge conflicts
  • #4038
    • Already has a reviewer, is in wrong column
    • Pierre has tested this, needs code review; Tim added as secondary, but would be good to get another reviewer
  • #3078
    • Waiting on refactoring to use PATCH add
    • Up to developer to get it cleaned up
  • #9610
    • Related to #3078
  • #3076
    • Has conflicts on frontend; might need to delay based on CRIS merger discussions
    • Tim added and will take a look at the code
    • There were also architectural questions and concerns
    • Steering has asked to avoid adding features that could complicate the merger 
  • #2892
    • has unrelated integration test that failed
    • paused for the moment to see what's going on 
  • #3164
    • Has had a merge conflict for some time, waiting on developer to fix the PR
    • Not sure if this will get in
  • #3165
    • In pretty good state, has had reviews and testing from Tim, needs to get cleaned up 
    • Tim will review a second time
  • #9793 and #3286
    • Waiting on developer
  • #9844
    • Waiting on dev to address rest of feedback
    • Looking good so far
  • #3355 and #9849
    • Ready to be tested and reviewed again
    • Frontend: There is a dependencies error that needs to get cleaned up
    • Backend: Waiting on dev to get updated, then retest
  • #9866 and #3369
    • Has merge conflicts
    • Kim has given positive review; Yuri found some problems on the front end
    • If dev can get it cleaned up, we can get it moved forward
  • #9915
    • Mark has done cleanup today; waiting on additional reviews and testing to move it along
    • Tim added himself as reviewer in addition to Kim and Giuseppe
  • #3338
    • Has merge conflicts; Tim added as secondary reviewer
  • #3540
    • Has had some testing and code reviewers
    • Contains lint failures
    • Kim will do final cleanup and Tim will do another review
    • 4Science invited to review as well
  • #3722
    • still waiting on reviews
  • #10237 
    • needs code review
    • Giuseppe will test; Tim added as well
    • could port to main if its working well; if not need to delay it
  • #10294 and #3882
    • needs rebasing; merge conflicts in frontend have been resolved
    • Tim will review this week
  • #10333
    • Tim will do code review today or tomorrow
  • #10407
    • Had reviews and testing, in good state
    • Kim needs to tidy things up and will request review
    • in a good spot; just a matter of getting them cleaned up and ready to go
  • #10410
    • Had early reviews from Tim; in good spot to be rereviewed
    • Tim will get to them again if not this week, next week
    • Paulo: if you have a hance to look at them Tim would welcome feedback
  • #10431
    • waiting on dev; frontend hasn't been fully updated yet
    • need Tim to look at more closely
    • Tim will add feedback 
  • #10433 and #4017
    • Has had lots of testing; lots of code cleanup has occurred; moving forward
    • Tim needs to revisit; going well
    • Some unit test failures the dev needs to clean up
    • Giuseppe needs to review angular side
  • #10435
    • Looking good, has had a lot of testing and reviews; small things to clean up in reviews and bugs related to download not showing up properly
  • #10436
    • Waiting on Francesco and Yuri, please give it a quick look 
  • #4022
    • Probably going to miss release
    • Difficult to understand changes; can't test without rebase; waiting on dev to respond

Action items