Versions Compared

Old Version 2

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Tim Donohue

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

...

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

Announcements

  • No meeting next week (Sept 18)

    • Tim and Holger will attend a LYRASIS staff retreat.

    • Next scheduled meeting: Sept 25.

  • Upcoming Q&A webinar on Sept 30 (DSpace–DSpace-CRIS merger update).

Updates

  • Merger planning

    • Technical Planning Group: working on accelerating merging of DSpace-CRIS code into DSpace (creating/merging PRs). Still early, brainstorming stage.

    • Strategic Planning Group: preparing the Sept 30 Q&A webinar; broader updates will be shared there.

Discussion Topics

  • HTML in metadata fields

    • Issue: HTML behaves inconsistently:

      • In My Submissions and search results, HTML tags like <a> links are rendered.

      • On item pages, HTML is escaped (except for abstracts).

    • Concerns:

      • Unexpected/misleading links in titles and search results.

      • Inconsistent user experience.

      • Possible issues for OAI-PMH and external apps that assume plain text metadata.

    • Views shared:

      • Pascal: not a major security risk since JavaScript is blocked; links can be acceptable in abstracts.

      • Art: root cause is Solr hit highlighting returning HTML. Proposed adding a sanitizer to allow only <i> and <b> tags. Suggested long-term solution: store plain text metadata alongside optional HTML versions.

      • Tim: prefers consistency — only process HTML/Markdown in abstracts, display plain text elsewhere.

      • Mark: suggested validation to block HTML in certain fields (like titles).

    • Decision/Next Steps:

      • Quick fix: sanitize Solr results to remove links in search results.

      • Assigned to Art Lowel.

      • Longer-term: explore plain text + HTML dual-field approach.

  • Angular modularization (NX vs Angular CLI)
    • Update by Art Lowel:

      • Modularized code into core/config/util modules. Build works, but:

        • Tree-shaking issues: unnecessary services bundled, leading to crashes.

        • Modules don’t rebuild automatically; need scripts (e.g., nodemon) to watch/rebuild.

        • Config library problem: used by Angular, Webpack, and Node scripts → currently bypassing library boundaries.

      • NX may solve these problems automatically but has its own complexities.

    • Next Steps:

      • Art will continue documenting pros/cons of both approaches.

      • Discussion postponed until Giuseppe returns from holiday.

      • Notes may be collected in wiki/GitHub tickets for group review.

  • Session/logout inconsistency across tabs/browsers

    • Issue raised by Sasha:

      • User logs in across multiple tabs.

      • Logging out in one tab invalidates the session but doesn’t update other tabs immediately.

      • Leads to inconsistent state until user interacts (see GitHub ticket).

    • Discussion:

      • Backend limitation: REST API doesn’t support multiple independent sessions.

      • Art: not necessarily a bug — expected behavior in same browser, but frontend error handling is poor.

      • Suggestion: extend authentication interceptor to catch invalid sessions and redirect user to login.

      • Kim: problem is similar to backend downtime → needs a global UI handler.

    • Consensus:

      • Short-term: improve frontend to catch errors and redirect/log out gracefully.

      • Long-term: backend session handling more complex and unresolved.

    • Next Steps:

      • No volunteer yet; Art may pick up in a few weeks if unclaimed.

  • ORCID document type mapping (PR by Pierre Lasou)

    • Small PR: improves mapping precision between DSpace document types and ORCID types.

    • Straightforward and non-controversial.

    • Approved during meeting with quick thumbs-up.

    • Action: Tim will merge PR after applying proper tags.

  • Project board & pull requests

    • Tim highlighted:

      • Many PRs in under review with merge conflicts → need cleanup by authors.

      • Encouraged developers to review/test each other’s PRs.

      • Merge backlog is shrinking but still large; needs broader participation.

    • Reminder:

      • Easy, obvious PRs should be approved quickly.

      • Tag Tim if something is stuck but trivial.

Code reviews (time-permitting)

Decisions & Agreements

  • HTML in metadata: Only render HTML/Markdown in abstracts; sanitize elsewhere.

  • ORCID PR approved for merge.

  • Frontend should handle session invalidation gracefully (interceptor solution).

  • Angular modularization: continue analysis; revisit with Giuseppe.

Action Items

  • Art Lowel →

    • Quick fix: sanitize Solr search results to remove unexpected HTML.

    • Continue Angular CLI modularization testing; document pros/cons.

  • Tim Donohue →

    • Merge Pierre’s ORCID PR (with version tags).

    • Test “required relation field” PR in UI, port to 9.x.

  • All developers →

    • Review/test PRs, especially those with conflicts.

    • Raise visibility for small, obvious PRs.

  • Future →

    • UI improvement for logout/session invalidation handling.

    • Longer-term solution for plain text + HTML metadata fields.