Versions Compared

Old Version 2

changes.mady.by.user Dragan Ivanovic

Saved on

compared with

New Version Current

changes.mady.by.user Dragan Ivanovic

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Date

Call-in Information

Time: 10:00 am, Eastern Time (New York, GMT-04:00)

Attendees

(star)  Indicating note-taker

  1. Brian Lowe  
  2. Georgy Litvinov (star)
  3. William Welling 
  4. Dragan Ivanovic 
  5. Huda Khan 
  6. Ralph O'Flinn 
  7. Benjamin Gross

Agenda

  1. Releases management
    1. Status
      1. Making VIVO 1.12.2 functional
        1. https://github.com/vivo-project/VIVO/pull/3611 
    2. Next steps
      1. Possible solutions
        1. Docker container for preparation of a release
        2. Pair deployment / preparation of a release

  2. Moving forward reviewing PRs on VIVO and Vitro

    1. https://github.com/vivo-project/Vitro/pulls and https://github.com/vivo-project/VIVO/pull
  3. Add Spring/Spring Boot in VIVO
    1. There is some progress

Notes

Dragan: One way is to use docker to prepare in release and another to work in pairs. For April minor release we should try it and hopefully Ralph can help how to make releases. Hopefully all of us became capable of making releases. I tried myself to create a release but only until the point of real publishing.

Brian: Is there some kind of sandbox we can try creating releases? 

Dragan: I forked repository and created a release in my repository. The next step is to publish the release outside of Github.

Brian: We need to create test releases with Sonatype and test it before publishing. 

Dragan: For the issue just described you think it wasn’t possible to detect the issue before publishing?

Brian: We know about the issue now, but beforehand might be not possible.

Dragan: My impression that the problem appears before uploading.

Brian: Hopefully we can build a process to check that. But everything doesn’t look easy.

Dragan: I think we are not alone with this problem. For me it is weird that it isn’t possible to test it before publishing.

Brian: If we release RC we can use RC versions to test it thoroughly.

Dragan: I can research a little bit about that. Ralph sent a message to Slack that soon he would need a tester for the new release.

Dragan: We also have a status of reviewing Vitro and VIVO PRs.

My intention is to give a little bit of time for everyone to check PRs and have some meetings for this. 

Brian: Sure. 

Dragan: I started from 2021 issues. First one is about the VIVO citation. I commented on that PR. I am not sure whether it is the best approach to cite it. 

Brian: Do we know about any other examples like we have.

Dragan: Probably. I will look into it. I am not sure I can find an example right now.

Brian: It assumed that you cite it somehow. Journal of open source software was standard VIVO citation, but maybe it makes sense to create real VIVO citation. 

Huda provided this link explaining CITATION files.

Dragan: Should we switch to this approach or use the old one.

This is not a priority PR, but we should decide on that.

Dragan: Michel’s pull request. Georgy commented and Michel responded.

Georgy: I am going to work on it more.

Dragan: 3611 PR to fix current release. I reviewed this PR.

Dragan: 3613 PR I provided some feedback to Benjamin.

In Vitro we have more PRs:

Dragan: PR to delete individuals. I reviewed it, so it is completed from my side. It is not so trivial and small. I suggest 2 reviewers, at least one of you should test it.

Brian: Hopefully I can do that next week.

Dragan: PR from Georgy to configure email. I tried it now and it works for me. 

This is a task to review for Brian.

Dragan: Online translations. I tested it and maybe Benjamin or William can test it.

Dragan: The next PR is created by Michel. It is messy PR. Let's wait for Michel.

Dragan: Vitro PR250 by Veljko we are not under pressure to merge it now. After publishing next release, we can merge this PR (to be ready for April release).

Dragan: Uploading documents PR. Might be of interest for integration between DSPACE and VIVO. It might be a simplified version of supporting deposit of files. If somebody expects something more than that,  might use DSPACE or some other digital repository behind VIVO.

Benjamin: I have seen some requests for proposals and I agree that this is a basic storing feature.

Dragan: What is our strategy for documenting new features? 

Benjamin: I would prefer to not write documentation before it merged. It never required to review documentation. 

Dragan: Is it usually the task for a PR author?

Brian: There is no organized documentation team. It is good to document features by authors but it is a tricky question.

Dragan: I can help with it together with Georgy.

Benjamin: I can take a look at it later Today.

Brian: Do we have a filter to get PRs by reviewers?

Dragan: Not sure

Benjamin posted an example how to filter PRs is:open is:pr review-requested:brianjlowe

Dragan: There is also small PR in Vitro languages related to documents uploading. I am not sure who is assigned to it. 

Dragan: Georgy, can you send a note to Tatiana Walther if she can review Russian translations PR in Vitro and VIVO.

Georgy: Sure.

Dragan: There is PR in VIVO-languages 99 from Michel. William suggested fixing it.

Dragan: In pom files we also have developers’ names and all of the developers are not active.  Do we need this in the pom files? 

Brian: I don't think so. We might don’t need a developer list in pom files.


Draft notes on Google Drive

Actions 

  •  Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.1 release
  •  Georgy Litvinov to add some details in the Dynamic API diagram and continue working on proof of concept
  •  Dragan Ivanovic to discuss with Lyrasis officer whether we need Contributor license agreements in the process

Previous actions 

  •  Dragan Ivanovic to update PR template to discourage large PRs or at least to ask contributor for reason why it is necessary to have large PR

Previous actions 

  •