Page History

...

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

• Reminders about 9.0 deadlines coming up (see note at the top of the agenda)
  • Will be strict about the Feature PR deadline.  Any major features or changes not in PR form by Feb 21 will not be considered for 9.0 (unless you notify Tim in advance of Feb 21 and we work something out)
• Discussion of Giving someone Workflow privileges (Reviewer, Editor, Final Editor) also gives them submit privileges:  https://github.com/DSpace/dspace-angular/issues/3849
  • Several Committers not surprised by this behavior.  We are only checking for "ADD" privileges to determine if you can ADD content to a Collection (i.e. submit).  Workflow privileges also  require ADD privileges in order to allow them to edit in-progress submissions (for Editor & Final Editor roles). 
  • This doesn't seem high priority for 8.1 at least.  Needs more discussion to determine if there's a way to separate these permissions better
  • Several note they are not concerned about this.  Not seen as a major issue as those who are doing workflow approval are "trusted". They do not gain submit to other collections. They only can submit items back into the same workflow approval process.
  • Tim will update the ticket with this feedback
• Most of the meeting was spent on 8.1/7.6.3
  • Reviewed everything in TO DO list which is not  already merged.
  • Using both public/private REST API URLs for better performance (Frontend PR: https://github.com/DSpace/dspace-angular/pull/3358, Backend PR: https://github.com/DSpace/DSpace/pull/9856)→ WILL BE Updated by Giuseppe Digilio (4Science) by next week.  Pascal-Nicolas Becker will help to test these PRs.
  • Exclude search & browse components from Angular SSR (https://github.com/DSpace/dspace-angular/pull/3709) → Will be merged after meeting
  • Prevent request with page size of 9999 (https://github.com/DSpace/dspace-angular/pull/3694) → Approved by Art.  Just needs a second set of eyes for Testing.  Tim Donohue will test.
  • Support configurable limit for exporting items (https://github.com/DSpace/DSpace/pull/10030) → Deemed as not high priority.  It has been changed to "optional" for 8.1/7.6.3.  That said, Atmire staff are working on cleaning this up.  Cleanup will involve adding a UI warning when a export limit is in effect.
  • Processes should only be failed after a Tomcat restart (https://github.com/DSpace/DSpace/pull/10158) → Tim plans to test and merge this as-is.  Andrea's feedback is valid & should be moved to a separate ticket for future work.  However, we cannot wait on that work, as we have a severe bug on "main" branch caused by https://github.com/DSpace/DSpace/pull/9728 (already merged).  This new PR (10158) fixes that severe bug.  We cannot release 8.1/7.6.3 without this bug fix.  But, Tim agrees that Andrea's approach would be better for the long term.
  • Browse Performance Fixes (https://github.com/DSpace/dspace-angular/pull/3846) → Needs review/testing. Tim will review.  This will be optional
  • Accessibility: Make reorder buttons keyboard accessible: https://github.com/DSpace/dspace-angular/pull/3372 → Needs review/testing.  Tim & Art will review. This will be optional
  • Accessibility: Support for disabled elements for screen readers: https://github.com/DSpace/dspace-angular/pull/3268 → Needs review/testing. Tim & Giuseppe will review.  This will be optional.
  • (Optional) On error in DOI organizer bulk operations, continue instead of stopping (https://github.com/DSpace/DSpace/pull/9835) → Needs review/testing.  Tim & Kim will review.  This will be optional.
• Goal for 8.1/7.6.3 is still January 30.  However, because of the large number of PRs still open, this may be a difficult deadline .  It may be more likely that the release will occur by February 6. 
  • That said, we are doing our best to get this out on/by Jan 30. If we miss that deadline, it will be out by Feb 6 (assuming no other complications, obviously)

Action items