Versions Compared

Old Version 1

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Tim Donohue

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

...

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

Merger Discussions

Announcements

  • No meeting next week (Sept 18)

    • Tim and Holger will attend a LYRASIS staff retreat.

    • Next scheduled meeting: Sept 25.

  • No major new developments.

  • Upcoming

  • Q&A webinar

    scheduled for September 30, 2025 with registration details forthcoming.
  • Technology group working on a potential roadmap (how to merge code, timelines, review processes).

...

Updates

  • Merger planning

    • Technical Planning Group: working on accelerating merging of DSpace-CRIS code into DSpace (creating/merging PRs). Still early, brainstorming stage.

    • Strategic Planning Group: preparing the Sept 30 Q&A webinar; broader updates will be shared there.

Discussion Topics

  • HTML in metadata fields

    • Issue: HTML behaves inconsistently:

      • In My Submissions and search results, HTML tags like <a> links are rendered.

      • On item pages, HTML is escaped (except for abstracts).

    • Concerns:

      • Unexpected/misleading links in titles and search results.

      • Inconsistent user experience.

      • Possible issues for OAI-PMH and external apps that assume plain text metadata.

    • Views shared:

      • Pascal: not a major security risk since JavaScript is blocked; links can be acceptable in abstracts.

      • Art: root cause is Solr hit highlighting returning HTML. Proposed adding a sanitizer to allow only <i> and <b> tags. Suggested long-term solution: store plain text metadata alongside optional HTML versions.

      • Tim: prefers consistency — only process HTML/Markdown in abstracts, display plain text elsewhere.

      • Mark: suggested validation to block HTML in certain fields (like titles).

    • Decision/Next Steps:

      • Quick fix: sanitize Solr results to remove links in search results.

      • Assigned to Art Lowel.

      • Longer-term: explore plain text + HTML dual-field approach.

  • Angular modularization (NX vs Angular CLI)

      • Art Lowel delegated initial prototyping to Yury; Art to continue next week.

      • Preparation PR: may be useful regardless of final decision (NX or Angular CLI). Needs multiple reviews and tests.

      • Tim to test; Art/Yury to review and give feedback.

      • Rename PR for broader relevance.

      Aggressive Bot Mitigation

      • Please use this discussion ticket on GitHub to share best practices and feedback

      • Fedora-led webinar series also exploring solutions (AI Showcase Series).

        • Showcasing institutions' attempts to deal with aggressive bots; first sessions held last week

      • Existing PR: upgrade to rate limiter (default: 500 hits/IP); please share feedback if you have experience with changing the limiter

      PRs and Issues Raised

      • Metadata Import Script:

        • Refactored for modularity and customization.

        • Reviewers: Kim (confirmed), Tim (tentative).

      • Key Code vs Key Character Handling:

        • Fix for keyboard input inconsistencies.

        • Art to test and merge after meeting.

      • Audit Trail Feature:

        • Large PR; requires multiple reviewers.

        • Planned demo on September 25, 2025 meeting.

      • File Upload/Download Fix:

        • Bug due to symbolic links and canonical paths.

        • Small PR; Tim to review/merge soon.

      • Archival Information Packages (AIP):

        • Proposal: include groups/people at collection/community level (not just site).

        • General agreement: useful for restoration flexibility, despite duplication.

        • Concern: performance issues for large repositories. Ticket needed.

      • JPEG Orientation Fix:

        • Correct rendering of thumbnails with EXIF rotation metadata.

        • Needs more tests and JavaDocs.

      Other Notes

      • Emphasis on bringing PRs/tickets to meetings for feedback.

      • Project board still has a large backlog; more reviewers/testers needed.

      Action items

        • Update by Art Lowel:

          • Modularized code into core/config/util modules. Build works, but:

            • Tree-shaking issues: unnecessary services bundled, leading to crashes.

            • Modules don’t rebuild automatically; need scripts (e.g., nodemon) to watch/rebuild.

            • Config library problem: used by Angular, Webpack, and Node scripts → currently bypassing library boundaries.

          • NX may solve these problems automatically but has its own complexities.

        • Next Steps:

          • Art will continue documenting pros/cons of both approaches.

          • Discussion postponed until Giuseppe returns from holiday.

          • Notes may be collected in wiki/GitHub tickets for group review.

      • Session/logout inconsistency across tabs/browsers

        • Issue raised by Sasha:

          • User logs in across multiple tabs.

          • Logging out in one tab invalidates the session but doesn’t update other tabs immediately.

          • Leads to inconsistent state until user interacts (see GitHub ticket).

        • Discussion:

          • Backend limitation: REST API doesn’t support multiple independent sessions.

          • Art: not necessarily a bug — expected behavior in same browser, but frontend error handling is poor.

          • Suggestion: extend authentication interceptor to catch invalid sessions and redirect user to login.

          • Kim: problem is similar to backend downtime → needs a global UI handler.

        • Consensus:

          • Short-term: improve frontend to catch errors and redirect/log out gracefully.

          • Long-term: backend session handling more complex and unresolved.

        • Next Steps:

          • No volunteer yet; Art may pick up in a few weeks if unclaimed.

      • ORCID document type mapping (PR by Pierre Lasou)

        • Small PR: improves mapping precision between DSpace document types and ORCID types.

        • Straightforward and non-controversial.

        • Approved during meeting with quick thumbs-up.

        • Action: Tim will merge PR after applying proper tags.

      • Project board & pull requests

        • Tim highlighted:

          • Many PRs in under review with merge conflicts → need cleanup by authors.

          • Encouraged developers to review/test each other’s PRs.

          • Merge backlog is shrinking but still large; needs broader participation.

        • Reminder:

          • Easy, obvious PRs should be approved quickly.

          • Tag Tim if something is stuck but trivial.

      Code reviews (time-permitting)

      Decisions & Agreements

      • HTML in metadata: Only render HTML/Markdown in abstracts; sanitize elsewhere.

      • ORCID PR approved for merge.

      • Frontend should handle session invalidation gracefully (interceptor solution).

      • Angular modularization: continue analysis; revisit with Giuseppe.

      Action Items

      • Art Lowel →

        • Quick fix: sanitize Solr search results to remove unexpected HTML.

        • Continue Angular CLI modularization testing; document pros/cons.

      • Tim Donohue →

        • Merge Pierre’s ORCID PR (with version tags).

        • Test “required relation field” PR in UI, port to 9.x.

      • All developers →

        • Review/test PRs, especially those with conflicts.

        • Raise visibility for small, obvious PRs.

      • Future →

        • UI improvement for logout/session invalidation handling.

        • Longer-term solution for plain text + HTML metadata fields

      • Art/Yury: Continue NX vs Angular CLI prototyping; review preparation PR.

      • Community: Share aggressive bot mitigation tips in discussion ticket.

      • Kim: Review metadata import refactor; Art to test and merge key character PR.

      • Stefano: Present Audit Trail feature demo on September 25.

      • Tim: Review/merge symbolic link fix; test AIP duplication changes; ensure ticket created for large-repository AIP performance.

      • Contributors: Add tests/JavaDocs for JPEG rotation fix

        • .