Versions Compared

Old Version 1

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Tim Donohue

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • (30 mins) General Discussion Topics
    1. DSpace 7 at OR2022 - What talk(s) are we submitting for OR2022? Proposals due on March 6.
    2. Review tentative 7.3 Release Schedule above. This is based on a new 4-month release window, but could conflict with OR2022 plans.
    3. Any assigned 7.3 work needing early discussion?
      1. What do we need out of e2e (end to end) tests in the Angular UI?  Prompted by discussion of https://github.com/DSpace/dspace-angular/pull/1513
        1. Should e2e tests be only supported against a full DSpace REST API backend, with valid test data (like the Demo entities test data set)?
          1. Cypress notes some advantages/disadvantages: https://docs.cypress.io/guides/guides/network-requests#Use-Server-Responses
          2. Advantages: More like a full system test.  May allow us to automate some of the (usually manual) tests that currently only occur during Testathon.
          3. Disadvantages: May not perform well if you attempt to run it against api7.dspace.org (demo site), as these tests would be highly dependent on the backend being responsive (any major delays in responsiveness will result in tests timing out / failing).  May require anyone who wants to run e2e tests locally to first spin up a backend locally and then populate it with test data expected by the e2e tests (similar to GitHub CI)local backend with valid test data.
        2. Should e2e tests be only supported against mock data (e.g. via Cypress Stubbing)?
          1. Cypress notes some advantages/disadvantages: https://docs.cypress.io/guides/guides/network-requests#Stub-Responses 
          2. Advantages: Much better performance of tests. More stability running tests both locally and in GitHub CI.
          3. Disadvantages: Mock data must be accurate at all times. If the mock data is ever "out of sync" with the backend responses, it's possible that e2e tests may not find bugs or errors that would exist in a real site.
          Should e2e tests be runnable against both mock data or a full backend?
        3. Advantages: Both of the advantages provided above.  Mock data could be used for quick verification, while a full backend provides more detailed testing.
          4. Disadvantages: Maintenance.  Also may require test duplication as it's unclear if Cypress can run the same tests against either mock data or a real backend.
        4. Recommendations from Cypress
          1. Use full backend for critical paths in your application, or places you want to drive the application like a user would
          2. Use stubs/mocks for edge cases or "hard to create" application states.
      2. (Tentative, only if time allows) What to do about SWORDv2 support?  The Java SWORDv2 library will break as soon as we upgrade Solr Client to 8.10.0 or above (currently we are on 8.8.1), see https://github.com/DSpace/DSpace/issues/8188
        1. How can we address this rapidly?  (If there are any future security vulnerabilities from Apache Solr which require us to upgrade to the latest version of 8.x, then we'll immediately break SWORDv2.)
  • (30 mins) Planning for next week
    • Review the Backlog Board - Are there any tickets here stuck in the "Triage" column?  We'd like to keep this column as small as possible.
    • Review the 7.3 Project Board - Assign tickets to developers & assign PRs to reviewers.
      • Paid (by DSpace project) developers must keep in mind priority. If new "high" or "medium" priority tickets come in, developers should move effort off of "low" priority tasks.
      • Volunteer developers are allowed to work on tickets regardless of priority, but ideally will review code in priority order.

...

Current Work

Project Board

...

  • Discussing Release Support now that 7.x is out
    1. The DSpace Software Support Policy notes that we support the "most recent three (3) major releases" (where a major release is defined by the changing of the first number, e.g. 6.x → 7.x).  This would mean that 5.x, 6.x and 7.x are all supported at this time.
    2. Should we propose to Committers / Governance a change of policy to the "most recent two (2) major releases"?  This would mean that we move to only supporting 6.x and 7.x.

Notes

...

  • Luca demoed the Spring Boot Admin Server user interface.
  • We decided that we'd still like a very basic Angular UI for the "Control Panel".  It should ONLY display the "info" and "health" actuators, which align well with the sort of basic status updates that the old DSpace XMLUI Control Panel had.
  • Anyone who wants more complex "Control Panel" functionality should install/use the Spring Boot Admin Server.  We should add instructions on how to do so, as this is a very powerful tool for anyone who wants more insight into their DSpace site's performance.
  • The old XMLUI Control Panel also included a "Systemwide Alerts" section. However, this needs to be split out as a separate Ticket, as it cannot be achieved with Spring Boot Actuators. It's more an Angular UI task.

...

  • Ben went over updates of the new (edge) use case: two Publications linked via a relationship where Publication A is the review of Publication B.  If Publication B is then versioned into B2, it may be important for Publication A to somehow retain an "original" link to Publication B (as that was the version which was reviewed), even if B2 is now the latest version.
    • Feels that the current design can be extended to support this use case easily
    • Mark W noted that this use case may need to be a separate task .  Start simple and address the edge cases later.  Tim agrees.
    • Andrea said he's not sure it's that hard to achieve this use case, but also says the approach of splitting this up is fine.
  • Updated estimate from Ben of 80-120 hours
  • All agree that the original design is good as-is.  Minor feedback is still welcome on either the ticket (https://github.com/DSpace/DSpace/issues/7937) or the Google Doc.  Development can begin.
  • All agree that the edge case can be a secondary PR later on. However, if Ben finds a way to achieve it easily, it's OK to achieve in the same PR.  As of today though, it seems like it may need more analysis & therefore is not required for the first PR.

...