...
- Brian Lowe
- Benjamin Kampe
- Georgy Litvinov
- Michel Héon
- William Welling
- Huda Khan
- Benjamin Gross
- Ralph O'Flinn
- Don Elsborg
Agenda
- Announcements / updates
- Mailing list / Slack discussion
- RC1 issues to resolve:Need to decide correct behavior for:
Jira server LYRASIS JIRA keyserverId c815ca92-fd23-34c2-8fe3-956808caf8c5 VIVO-1983 Jira server LYRASIS JIRA jqlQuery project = VIVO AND fixVersion = v1.12 AND priority = Blocker AND (status = Open OR status = "In Review" OR status = "In Progress" ) serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 - Testing / results: Release Testing - 1.12.0
- VIVO WCAG 2 A/AA accessibility audit results from Deque
- Updates on Data Ingest Task Force discussions
- Prioritizing and planning post-1.12 development
...
- Were hoping for release on Friday, but additional issues came up.
- Thanks to Georgy and Benjamin K for effort resolving issues
- Lingering issues, might still be a couple blockers but should be resolved by this week
- VIVO-1994- Behavior of manage publications functionality backwards when operating in French.
- Text is misleading. Text says ‘display the conferences’ but the functionality actually is for ‘hiding’ the selected publications.
- VIVO-1993- Publication count shows for sparkline, but no graph
- Does not seem to be consistent.
- Seems to affect newly created persons, but not older
- Brian - there was a previous fix for the google sparkline location
- For reference: https://jira.lyrasis.org/browse/VIVO-1950
- Benjamin G - would be helpful if we could see if there is any error being thrown by the google viz library or if it is failing silently.
- VIVO-1992- UMLS search not working
- Legacy issue for setting this up: https://jira.lyrasis.org/browse/VIVO-1534
- Hopefully the search is still working… but we don’t know anybody actually being able to set it up and use it
- Brian - in the custom form generator for this page there is a list of the services. We could add a property to runtime.properties to turn UMLS off so it doesn’t appear if it isn’t set up correctly.
- Benjamin - can we actually set up the username and password setup in runtime.properties instead of just having a flag for the generator template?
- Brian - that’s actually more difficult than it would seem since the UMLS doesn’t use the context.
- Don - We are using MeSH terms pulled out of Elements.
- Leaning toward middle option where we add option to hide the service (and issue) but not actually fix the issue.
- https://jira.lyrasis.org/browse/VIVO-1991
- Security issue in past couple versions of VIVO
- Difference between how md5 and argon hashes work
- Hash could be guessed in past
- A little tricky to test since smtp server needs to be set up
- Brian can set up with gmail and test
- Georgy had set up a postfix server locally before (see https://gist.github.com/haccks/7ec2fe500332a6d23ee68d1c1a2279d5)
- https://jira.lyrasis.org/browse/VIVO-1990
- https://jira.lyrasis.org/browse/VIVO-1989
- Brian discovered while testing other issues
- End up with a redirect issue if you aren’t running VIVO at root context
- Should be a simple test
- Okay for a single review and merge
- Benjamin G will test
- https://jira.lyrasis.org/browse/VIVO-1988
- Unfortunately a little thornier than expected.
- We likely want to retain the functionality to delete label in ‘all languages’
- But it should probably be documented.
- No loud objections and one thumbs up… will be pushed to 1.13
- https://jira.lyrasis.org/browse/VIVO-1987
- Brian has been unable to reproduce
- Georgy - it always returns the first added language
- Not hard-coded to English
- If Brian set accept-language header in linked data request or via the dropdown, then he seemed to get the results he expected
- We need to find specific steps to reproduce bug otherwise not a blocker
- https://jira.lyrasis.org/browse/VIVO-1986
- Has approval
- Needs some committer attention
- Benjamin G will test
- https://jira.lyrasis.org/browse/VIVO-1985
- Occured when you had multiple fallback languages but it was inconsistent between what was shown in view mode and what it was trying to edit.
- We probably want to reconsider a better priority mechanism for fallback languages.
- Can anybody take a look…..? *crickets*
- https://jira.lyrasis.org/browse/VIVO-1984
- Brian could not reproduce
- Michel will retry to confirm
- https://jira.lyrasis.org/browse/VIVO-1983
- We talked a lot about this last week.
- Led to same error as 1985.
- PR makes behavior consistent with other forms
- Will just see label for current language now (or insert new label) unless you’ve ingested data where there are multiple labels in a single language
- Should be a fairly quick one to test
- Michel has a new ticket
- Installer - condition to adding a new language is all source code must be in installation
- Cannot only download via Maven, must clone repo
- It would be nice if we had an option to clone all repositories easily.
- Brian - the wrinkle is the behavior for VIVO/Vitro doesn’t match what the language repos does.
- Michel will create a new issue to describe issue
- Georgy - will there be another meeting Friday?
- Brian - if committers meet tomorrow we should hopefully rally and get things merged
- If there’s still more to do a Friday meeting might be necessary.
- Stay tuned!