Page History

Date

05 Mar 2020 from 15:00-16:00 UTC

...

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (25 mins) General Discussion Topics
  
  1. Revisiting Tim's questions about changing types in all REST API responses to "core.item" (and similar) instead of "item". 
     1. See https://github.com/DSpace/DSpace/pull/2663#issuecomment-590453066 and RestAddressableModel.getUniqueType() in that PR
  2. Revisiting Scripts & Processes endpoint PR#2648: concerns about usage of Bitstreams for temporary files (like uploaded CSVs, SAF Zips, AIPs, etc)
     1. See also discussion notes from Feb 6
     Revisiting 
  3. (Please add a topic)
• (20 mins) Planning for next week
  
  • Claim tasks for next week from DSpace 7 Release Plan spreadsheet
  • Assigning PRs for Review

...

• Available Angular UI Tickets
  
  • Open issues in 7.0beta1 0beta2 milestone (highest priority)
  • Open issues in 7.0beta2 0beta3 milestone (second highest priority)
  • Open issues flagged as "Difficulty: low".  These may be a good starting point for newer developers.
• Available REST API Tickets
  
  • Unassigned tickets scheduled for 7.0beta10beta2 (highest priority)
  • Unassigned tickets scheduled for 7.0beta20beta3 (second highest priority)
  • General REST API tickets flagged as "low hanging fruit".  These may be a good starting point for newer developers.
  • General REST API unassigned bug tickets.  Again, might be a good starting point for newer developers.

PRs Needing Review

1. (NEW) (REST Contract) (beta3 - but dev starts Mar 2) Link to workflow steps and actions  Projections embedding (related to PR 2670 below) https://github.com/DSpace/Rest7Contract/pull/104  StatuscolourBluetitle1 approval106 (Tim Donohue, Andrea Bollini (4Science)?)
2. (NEW) (REST Contract) (beta2 - but dev starts Mar 2) Edit Community/Collection - Assign Roles/Groups HIGH PRIORITY) Group/EPerson management continued https://github.com/DSpace/Rest7Contract/pull/105107 (Tim Donohue, Andrea Bollini (4Science)?)
3. (RESTNEW) (beta2) Select specific embeds: REST Contract) Administer Workflow https://github.com/DSpace/DSpaceRest7Contract/pull/2670 (WAITING ON AN UPDATE)108 (Tim Donohue, Ben BosmanAndrea Bollini (4Science)?)
4. (REST Contract)  Scripts & processes: importing and exporting csv's related to the scripts & processes PR above (related to PR 2648 below) https://github.com/DSpace/DSpaceRest7Contract/pull/264899 (Andrea Bollini (4Science) -  REVIEWED, Tim Donohue )
5.  (REST) Select specific embeds: https://github.com/DSpace/DSpace/pull/2670 (Maybe one approval) (Tim Donohue - REVIEW Commentsadded feedback), Mark H. Wood  Ben Bosman)
6. (REST Contract) related to the scripts & processes PR above ) (beta4) Scripts & processes: importing and exporting csv's https://github.com/DSpace/Rest7ContractDSpace/pull/992648 (Andrea Bollini (4Science) -  REVIEWED, Tim Donohue - REVIEW Comments, Mark H. Wood  )
7.  (REST) Shibboleth authentication https://github.com/DSpace/DSpace/pull/2651 (Paulo Graça - REREVIEW, Ben Bosman   - REREVIEW)(REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 
8. StatuscolourBluetitle1 approval(Tim Donohue - minor feedback, almost ready to merge) (REST) DS-4043 Revisit security layer of submission (depend on the DS-4418) submission https://github.com/DSpace/DSpace/pull/2675 (Tim Donohue, OTHER REVIEWERS WELCOME Ben Bosman )
9.  (REST) Initial implementation of the authorizations endpoints https://github.com/DSpace/DSpace/pull/2663 (Ben Bosman -  REVIEWED, Tim Donohue - feedback added, bugs found)
10.  (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673  StatuscolourBluetitle1 approval( Tim Donohue, Andrea Bollini (4Science) - changes requested)(REST) Read only versioning endpoints https://github.com/DSpace/DSpace/pull/2680 

    Status
    colour Blue title 1 approval

     (Tim Donohue, OTHER REVIEWERS WELCOME)
11. (REST) (beta 3)  Workflow Workflow step definitions: action validation https://github.com/DSpace/DSpace/pull/2685 (Tim Donohue,  Ben Bosman, Andrea Bollini (4Science))
12.  (REST) (beta 2 - has upcoming dependencies) Manage HIGH PRIORITY) Manage Groups - https://github.com/DSpace/DSpace/pull/2686 - DS-4026 (Tim Donohue, Andrea Bollini (4Science) if needed)
13.  (REST) DS-4123 : (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously 4278: Fix bug where submitters can edit all metadata : https://github.com/DSpace/DSpace/pull/2687 -2689 (MERGE CONFLICT) 

    Status
    colour Blue title 1 approval

     (Tim Donohue - added feedback, Ben Bosman if needed)
14. (REST) DS-4124 : Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously NEW) (beta 3) Expose the action as an embed on claimedtasks https://github.com/DSpace/DSpace/pull/2688 -2701 

    Status
    colour Blue title 1 approval

     (Tim Donohue - added feedback, Ben Bosman if needed)(REST) DS-4278: Fix bug where submitters can edit all metadata : https://github.com/DSpace/DSpace/pull/2689   StatuscolourBluetitle1 approval(Tim Donohue) )
15.  (Angular) Shibboleth authentication (merge with REST PR #2651) https://github.com/DSpace/dspace-angular/pull/568 (Paulo Graça, Ben Bosman)
16.  (Angular) (beta 2) Edit Item Bitstreams Tab  https://github.com/DSpace/dspace-angular/pull/577 (NEEDS REBASE) (Tim Donohue, Giuseppe Digilio (4Science))
17.  (Angular) (beta 2) List versions - https://github.com/DSpace/dspace-angular/pull/585 - (Tim Donohue, NEEDS SECOND REVIEWER)
18.  (Angular) (beta 2) Specify Embeds (merge with REST PR #2670) - https://github.com/DSpace/dspace-angular/pull/588 -

    Status
    colour Blue title 1 approval

    (Tim Donohue)
19.  (Angular) (beta 1) Breadcrumbs2) Notice regarding the availability of new version on item pages: https://github.com/DSpace/dspace-angular/pull/591595 - (Tim Donohue, Giuseppe Digilio (4Science)reviewed and added feedbackNEEDS SECOND REVIEWER)
20.  (NEW) (Angular) (beta 1) MyDSpace ClaimedTask link resolving fixes: 2) Manage EPeople https://github.com/DSpace/dspace-angular/pull/594 - 609 (depends on #2686) (Tim Donohue, Giuseppe Digilio (4Science))Ben Bosman)
21. (AngularNEW) (beta 2) Notice regarding the availability of new version on item pages:3) Ensure workflow members can only perform actions assigned (dependent on PR 2701) https://github.com/DSpace/dspace-angular/pull/595 - (608 (Giuseppe Digilio (4Science), Tim Donohue, NEEDS SECOND REVIEWER) (Angular) Submission bug fix: https://github.com/DSpace/dspace-angular/pull/597 StatuscolourBluetitle1 approval(Tim Donohue, Paulo Graça Art Lowel (Atmire))
22. (Backend) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 ( NEEDS REVIEWERS)

...

1. Jira
   server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-4122

    Create Integration Tests to prove access restricted Communities/Collections cannot be accessed anonymously
2.  (Angular) (beta2) Manage Groups ETA March 9th
3. (Angular) (beta3) Administrative Search ETA March 12th

PRs Merged this week!

1.   (REST) Respect client-provided projections for non-GETS: https://github.com/DSpace/DSpace/pull/2684  

   Status
   colour Blue title 1 approval

2.   (Angular) Submission bug fix: https://github.com/DSpace/dspace-angular/pull/597

   Status
   colour Blue title 1 approval

3.   (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673 

   Status
   colour Blue title 1 approval

4.   (Angular) (beta 1) Breadcrumbs: https://github.com/DSpace/dspace-angular/pull/591 
5.   (Angular) Login name fixes & Submission required fields: https://github.com/DSpace/dspace-angular/pull/602
6.   (Angular) Allow optional HALLinks: https://github.com/DSpace/dspace-angular/pull/607
7.   (Angular) MyDSpace ClaimedTasks link resolving fixes: https://github.com/DSpace/dspace-angular/pull/606
8.  (REST Contract) Link to workflow steps and actions https://github.com/DSpace/Rest7Contract/pull/104 

   Status
   colour Blue title 1 approval

9.  (REST Contract) Edit Community/Collection - Assign Roles/Groups https://github.com/DSpace/Rest7Contract/pull/105
10.  (REST) DS-4123 : (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2687 

    Status
    colour Blue title 1 approval

11.  (REST) DS-4124 : Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2688 - 

    Status
    colour Blue title 1 approval

12.  (REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 

    Status
    colour Blue title 1 approval

Blocked

1. (Blocked PRs go here)

...

1. Managing Authorization info in Angular UI : How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example:  https://github.com/DSpace/dspace-angular/issues/393
   1. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
   2. Work is ongoing, but has been started in these areas:
      1. Summary of ideas: REST Authorization 
      2. Contract for Authorization Endpoints: https://github.com/DSpace/Rest7Contract/pull/92
      3. Contract for ResourcePolicies: https://github.com/DSpace/Rest7Contract/pull/87
   REST API Projections: 

   Jira
   server DuraSpace JIRA serverId c815ca92-fd23-34c2-8fe3-956808caf8c5 key DS-3533

2. Work begun in https://github.com/DSpace/DSpace/pull/2547 (by Chris Wilper)
   1. Based on detail discussions in our Oct 17 meeting. 
3. (Outdated) Early work begun at https://github.com/DSpace/DSpace/pull/1847.  Discussed in more detail in our Aug 22 meeting.  Overall, this approach seems like a good direction, need volunteers to move it forward.
https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)
4. Initial Performance Testing from Chris.
   1. https://cwilper.github.io/dspace-perftest/
5. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
6.  (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
7. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
   1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
   2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
   3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

...