Page History

...

See Trading reviews on Pull Requests for how to get immediate attention to that PR!

Notes

• Meeting time is now 15:00UTC.  Will stay this way until 2026 when Daylight Saving Time starts back up.  See note at the top of the page for more details
• DSpace & DSpace-CRIS potential merger discussions
  • Both the Technology Planning Group and Strategic Planning Group have sent their reports/recommendations to DSpace Steering.  Steering will now discuss and work towards a final decision.  Unclear when decision will occur exactly, as it's possible Steering could also ask for more details or similar.  Tim hopes we'll get to a decision in the next month, but difficult to put a date on. 
• Open Topics
  • Audit Framework PRs: https://github.com/DSpace/DSpace/pull/11072 and https://github.com/DSpace/dspace-angular/pull/4576
    • Good feedback on backend.  All feedback has been addressed, and PR is waiting on re-review.
    • No major feedback yet on the frontend.  Testers are welcome.
    • Overall, this seems to be moving, but we need reviewers to give an updated review.  Also need more testing/review of the frontend.
  • ORCID Sync bug: https://github.com/DSpace/dspace-angular/issues/4654
    • Pierre notes this is a severe bug.  Unfinished work (workspace and workflow items) is being synced to ORCID by accident.
    • Pierre / his team has found a fix that works for them, described in this comment: https://github.com/DSpace/dspace-angular/issues/4654#issuecomment-3468544481.  Pierre wants feedback on that approach
    • Tim notes that small addition of a "item.isArchived()" check seems reasonable
    • Giuseppe notes this isn't occurring in DSpace-CRIS.  He wants to check and see if there's something that missed being ported to DSpace
    • UPDATE: Giuseppe checked and the fix that Pierre noted is the best approach
    • ACTION ITEM: Pierre, or someone from his team, should create a PR with their proposed fix.  We'll then try to move that forward quickly.
  • Pierre notes there's many issue tickets related to the "Administrative Reports" feature that are still open.  Can any of these be closed?
    • https://github.com/DSpace/dspace-angular/issues/2908
      • Needs a closer check, but Tim suspects this might still be an issue. 
    • https://github.com/DSpace/dspace-angular/issues/2907
      • This issue may need a re-test.  It's possible it's fixed or partially fixed by https://github.com/DSpace/dspace-angular/pull/3694 (which was first merged in 9.0, 8.1 and 7.6.3).  But, we need someone to verify.
    • https://github.com/DSpace/dspace-angular/issues/2906
      • May be related to 2907 (prior issue) but also needs rechecking. Unsure if this still exists or not.
    • General note from Tim (not specific to these tickets): It's not unusual for tickets to stay open for a while.  But, it can be good to recheck things because tickets are sometimes either purposefully or accidentally fixed without the ticket being closed.  So, if you find a ticket that you think is fixed, retest it.  If it's fixed, then let us know to close it.
  • Accessibility fixes to placeholder text in Submission Form: https://github.com/DSpace/dspace-angular/pull/4199  
    • This PR just needs attention / reviews.  Accessibility fixes are a priority of Steering.
    • Assigned to Nick W and Tim.
  • PR to fix issue discussed recently where User Registration page is still accessible after login: https://github.com/DSpace/dspace-angular/pull/4764
    • Needs reviewers.  Kim was assigned
• Team Code Review
  • Reviewed bug fix to better enforce non-repeatable fields in submission
    • Backend PR (https://github.com/DSpace/DSpace/pull/10679)
      • Code looks reasonable.  Has good tests.
      • Kim notes that we should see if this validation can also occur in Workflow steps.  Current code limits validation to Submission Scope?  Added comment at https://github.com/DSpace/DSpace/pull/10679#issuecomment-3468743413
    • Frontend PR (https://github.com/DSpace/dspace-angular/pull/4274)
      • Giuseppe notes this all looks very familiar to him.  He believes that DSpace-CRIS already has a similar backend fix, and has an enhancement to the submission form to better handle this scenario.
      • Giuseppe will review these PRs and look closer at the DSpace-CRIS code.  He's surprised that this is a bug in DSpace as it was meant to be ported from DSpace-CRIS to DSpace.
      • Tim notes if the backend PR is mostly the same, maybe we can get this backend one merged and have 4Science just port the frontend.
      • This frontend PR also has outstanding feedback from Yury that seems to need addressing.
• Meeting concluded.