...
- Readme and slack
- Contribution guideline
- contributing.md
- screenshots???
- Profile linking with Matching ID doesn't work
- Query text parameter not sanitized
- Replace slf4j-log4j12 with slf4j-reload4j
Notes
I forgot my password
German and Russian labels are fine. Dragan contacted Spanish, Portuguese and French speakers for help in validation of labels, the feedback will be provided at the beginning of the next week. Georgy provided some comments to Ivan, and he thinks PR looks quite nice now and we are getting close to merging this PR.
Readme and slack
The README.md file has been slightly changed, there is a draft PR (https://github.com/vivo-project/VIVO/pull/3954). The PR will be ready for a review once the CONTRIBUTING.md file is linked from the README.md file.
Contribution guideline
Dragan asked for suggestions on how to link images in an md file (screenshots which might help in explanation how anyone can create a pull request). Michel saw in some other projects that a doc directory is created for this purpose. The committers meeting should result in a decision about this.
Profile linking with Matching ID doesn't work
Dragan reviewed those PRs and provided some comments in some of them. Georgy already started addressing some comments.
Query text parameter not sanitized
A ticket has been opened by Benjamin Gross. Georgy has implemented a solution. Hopefully, Benjamin will find time to confirm it is a solution for the issue. Dragan will also test it and review the code. Dragan asked why filter.id is also sanitized, Georgy responded he would like also to mitigate potential adding of javaScript code elements in extended search n3 configuration file.
Replace slf4j-log4j12 with slf4j-reload4j
Dragan created the PR for relocating slf4j-log4j12 artifact. Testing of this PR is neede - https://github.com/vivo-project/VIVO/issues/3953
The GESAH project
Georgy shared the news about released GESAH installer - https://github.com/TIBHannover/gesah-installer
...