Page History

...

Trading PRs is also very beneficial to DSpace in general!  The more developers we have helping to test or review PRs, the more quickly those PRs can be merged into the codebase (once approved).  It also ensures that bugs may be found more quickly as different people test things in different ways.  

How do I trade

...

PRs with another developer?

Simply reach out to other DSpace developers and ask!  The easiest way to reach out is usually via Slack (see our #dev channel).  You can either ask a specific person to trade, or generally post that you are open to a trade for one of your PRs. 

...

• If you don't feel comfortable doing a code review, you can still trade by offering to test the other developer's PR.  Testing can be just as beneficial as code review in that it helps us ensure the changes seems stable & bug free.
• If you aren't sure how to test a specific PR, please ask the PR's author.  Sometimes the author may accidentally leave out important information regarding how to reproduce the bug they fixed, or similar.  So, if you aren't sure, please don't be afraid to ask.
• You do not need to be assigned as a reviewer of a PR to review or test it.  Reviews/Testing is welcome from any developer at any time.  So, you can make trades with any open PR provided another developer wants to trade with you. 

How do I trade

...

PRs with the Technical Lead?

The DSpace Technical Lead (Tim Donohue) also is available for PR trading (based on the general rules above).  However, a few additional rules apply, as he generally has a lot of code reviews on his plate.

...