Page History

...

What is

...

Pull Request trading? Why would I want to do this?

"Pull Request trading" is when two developers agree to review or test each others Pull Requests.  This can be used to obtain more immediate feedback for both developers, and is also a way to build collaborations with developers at other institutions.

You can also "trade" by asking a developer to review a PR that you did not author, but are interested in seeing it get immediate feedback.  Simply let the developer know which PR you are asking them to review in exchange.

Trading PRs is also very beneficial to DSpace in general!  The more developers we have helping to test or review PRs, the more quickly those PRs can be merged into the codebase (once approved).  It also ensures that bugs may be found more quickly as different people test things in different ways.  

How do I trade reviews with another developer?

...

• If you don't feel comfortable doing a code review, you can still trade by offering to test the other developer's PR.  Testing can be just as beneficial as code review in that it helps us ensure the changes seems stable & bug free.
• If you aren't sure how to test a specific PR, please ask the PR's author.  Sometimes the author may accidentally leave out important information regarding how to reproduce the bug they fixed, or similar.  So, if you aren't sure, please don't be afraid to ask.
• You do not need to be assigned as a reviewer of a PR to review or test it.  Reviews/Testing is welcome from any developer at any time.  So, you can make trades with any open PR provided another developer wants to trade with you. 

How do I trade reviews with the Technical Lead?

...