Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Table of Contents

Date

 from 15:00-16:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

Info
titleBeta 1 & 2 Sprint : Feb 17-28
  • Finish Beta1 tasks in DSpace 7 Release Plan spreadsheetGoal is to have Beta1 released week of Feb 24.
  • Continuing work on Beta2 tasks (especially those with many dependencies)

Agenda

  • (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (25 mins) General Discussion Topics
    1. Revisiting Scripts & Processes endpoint PR#2648: concerns about usage of Bitstreams for temporary files (like uploaded CSVs, SAF Zips, AIPs, etc)
      1. See also discussion notes from Feb 6
    2. Revisiting 
    3. (Please add a topic)
  • (20 mins) Planning for next week

Attendees

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

Current Work

Panel
titleLegend for status icons

(blue star) = Highest Priority tasks (please prioritize these reviews/tasks over others).

(error) = review done, changes were requested or bugs found.

(tick) = review done, approved.

(warning) = review done, merge conflict or other minor changes requests

Status
colourBlue
title1 approval
 = pull request only requires a single approval to merge.  This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.  

Claim a Ticket!

If you do not have access in JIRA or GitHub to officially claim the ticket you wish to work on, contact Tim Donohue

PRs Needing Review

  1. (REST Contract) (beta3 - but dev starts Mar 2) Link to workflow steps and actions https://github.com/DSpace/Rest7Contract/pull/104 
    Status
    colourBlue
    title1 approval
    (Tim Donohue)
  2. (REST Contract) (beta2 - but dev starts Mar 2) Edit Community/Collection - Assign Roles/Groups https://github.com/DSpace/Rest7Contract/pull/105 (Tim DonohueAndrea Bollini (4Science))
  3. (REST) (beta2) Select specific embeds: https://github.com/DSpace/DSpace/pull/2670 (WAITING ON AN UPDATE) (Tim DonohueBen Bosman)
  4. (REST) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue - REVIEW CommentsMark H. Wood  )
  5. (REST Contract) related to the scripts & processes PR above https://github.com/DSpace/Rest7Contract/pull/99 (Andrea Bollini (4Science) - (error) REVIEWEDTim Donohue )
  6. (REST) Shibboleth authentication https://github.com/DSpace/DSpace/pull/2651 (Paulo Graça - REREVIEW, Ben Bosman   - REREVIEW)
  7. (REST) DS-4418 remove uuid from resource policy rest https://github.com/DSpace/DSpace/pull/2665 
    Status
    colourBlue
    title1 approval
    (Tim Donohue - minor feedback, almost ready to merge)
  8. (REST) DS-4043 Revisit security layer of submission (depend on the DS-4418) https://github.com/DSpace/DSpace/pull/2675 (Tim Donohue, OTHER REVIEWERS WELCOME)
  9. (REST) Initial implementation of the authorizations endpoints https://github.com/DSpace/DSpace/pull/2663 (Ben Bosman - (error) REVIEWEDTim Donohue - feedback added, bugs found)
  10. (blue star) (REST) Breadcrumbs in header https://github.com/DSpace/DSpace/pull/2673 
    Status
    colourBlue
    title1 approval
    ((tick) Tim Donohue, Andrea Bollini (4Science) - changes requested)
  11. (REST) Read only versioning endpoints https://github.com/DSpace/DSpace/pull/2680 
    Status
    colourBlue
    title1 approval
     (Tim Donohue, OTHER REVIEWERS WELCOME)
  12. (REST) Workflow step definitions: action validation https://github.com/DSpace/DSpace/pull/2685 (Tim DonohueBen BosmanAndrea Bollini (4Science))
  13. (REST) (beta 2 - has upcoming dependencies) Manage Groups - https://github.com/DSpace/DSpace/pull/2686 - DS-4026 (Tim DonohueAndrea Bollini (4Science) if needed)
  14. (REST) DS-4123 : (High priority because of dependencies) Create Integration Tests to prove access restricted Items cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2687 - 
    Status
    colourBlue
    title1 approval
     (Tim Donohue - added feedback, Ben Bosman if needed)
  15. (REST) DS-4124 : Create Integration Tests to prove access restricted Bitstreams cannot be accessed anonymously https://github.com/DSpace/DSpace/pull/2688 - 
    Status
    colourBlue
    title1 approval
     (Tim Donohue - added feedback, Ben Bosman if needed)
  16. (REST) DS-4278: Fix bug where submitters can edit all metadata : https://github.com/DSpace/DSpace/pull/2689  
    Status
    colourBlue
    title1 approval
    (Tim Donohue)
  17. (Angular) Shibboleth authentication (merge with REST PR #2651) https://github.com/DSpace/dspace-angular/pull/568 (Paulo GraçaBen Bosman)
  18. (Angular) (beta 2) Edit Item Bitstreams Tab  https://github.com/DSpace/dspace-angular/pull/577 (NEEDS REBASE) (Tim DonohueGiuseppe Digilio (4Science))
  19. (Angular) (beta 2) List versions - https://github.com/DSpace/dspace-angular/pull/585 - (Tim Donohue, NEEDS SECOND REVIEWER)
  20. (Angular) (beta 2) Specify Embeds (merge with REST PR #2670) - https://github.com/DSpace/dspace-angular/pull/588 -
    Status
    colourBlue
    title1 approval
    (Tim Donohue)
  21. (blue star) (Angular) (beta 1) Breadcrumbs: https://github.com/DSpace/dspace-angular/pull/591 - (Tim DonohueGiuseppe Digilio (4Science)reviewed and added feedback)
  22. (blue star) (Angular) (beta 1) MyDSpace ClaimedTask link resolving fixes: https://github.com/DSpace/dspace-angular/pull/594 - (Tim DonohueGiuseppe Digilio (4Science))
  23. (Angular) (beta 2) Notice regarding the availability of new version on item pages: https://github.com/DSpace/dspace-angular/pull/595 - (Tim DonohueNEEDS SECOND REVIEWER)
  24. (blue star) (Angular) Submission bug fix: https://github.com/DSpace/dspace-angular/pull/597
    Status
    colourBlue
    title1 approval
    (Tim Donohue, Paulo Graça )
  25. (Backend) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 ( NEEDS REVIEWERS)

PRs Coming Soon

  1. Jira
    serverDuraSpace JIRA
    serverIdc815ca92-fd23-34c2-8fe3-956808caf8c5
    keyDS-4122
     Create Integration Tests to prove access restricted Communities/Collections cannot be accessed anonymously

PRs Merged this week!

  1. (tick) (blue star) (REST) Respect client-provided projections for non-GETS: https://github.com/DSpace/DSpace/pull/2684  
    Status
    colourBlue
    title1 approval

Blocked

  1. (Blocked PRs go here)

Delayed / Needs Discussion

  1. Managing Authorization info in Angular UI How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular?  See for example:  https://github.com/DSpace/dspace-angular/issues/393
    1. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
    2. Work is ongoing, but has been started in these areas:
      1. Summary of ideas: REST Authorization 
      2. Contract for Authorization Endpoints: https://github.com/DSpace/Rest7Contract/pull/92
      3. Contract for ResourcePolicies: https://github.com/DSpace/Rest7Contract/pull/87
  2. Initial Performance Testing from Chris.
    1. https://cwilper.github.io/dspace-perftest/
  3. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
    1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
    2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
    3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.
  4. (warning) (Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
  5. Concurrency in DSpace 7 (or 8).  What do we want to do when multiple editors are editing the same object?  Needs further analysis regarding implementation details
    1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
    2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
    3. ETags seems to have broader support in other REST APIs.  Recommended also by both Art and Andrea.

Notes