Tim Donohue [9:44 AM] @here: Reminder that our DSpace 7 Working Group meeting is at the top of the hour in Slack. For the first 1/2 hour we'll be in #angular-ui talking Angular updates. The second 1/2 hour we'll be in #rest-api talking REST API updates. All are welcome to join us, or catch up later. As always, more info & all past mtg notes are at: https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group Tim Donohue [10:01 AM] @here: It's time for our weekly checking on DSpace 7 progress. As always, we'll start with Angular UI updates in this channel. @art-lowel, would you like to take the lead? Art Lowel [10:01 AM] Sure [10:01] These are the PRs that have been merged since our last meeting: [10:01] The collection home page: [10:01] https://github.com/DSpace/dspace-angular/issues/63 [10:01] The full item page: [10:01] https://github.com/DSpace/dspace-angular/pull/100 [10:01] Test and docs for the item page: [10:01] https://github.com/DSpace/dspace-angular/pull/96 [10:02] The addition of types to rest resources: [10:02] https://github.com/DSpace/dspace-angular/pull/97 [10:02] And the changes to travis builds to prevent timeouts during tests: [10:02] https://github.com/DSpace/dspace-angular/issues/101 [10:02] That’s a lot more than average, so good work everyone :y: Tim Donohue [10:03 AM] Yes, excellent progress this week! Thanks to @lotte, @rivaldi8, @art-lowel and @wwelling
Art Lowel [10:03 AM] Lotte is making progress with the DSO list task, I expect there to be a PR early next week [10:04] Afterwards we can create the collection and community browse pages which are the final large pieces of the puzzle still missing for browse Tim Donohue [10:05 AM] Awesome to hear! Yes, I'd love to see the hierarchical browse make it in by OR2017, if it's still possible. I realize though we are now only a few weeks away though [10:05] (So, admittedly, I don't know if that timeline is doable...thoughts?) Art Lowel [10:06 AM] apologies, my slack froze there for a minute [10:06] I think browse should be doable by OR yes [10:06] the hard part was the list element [10:06] when that’s done, it’s basically configuring it for the specific pages [10:07] that’ll be simply browse by title at first [10:07] don’t know if we’ll get anything else done Tim Donohue [10:07 AM] Sounds great then. I think we still need Community Home page too, of course (thought hopefully that's very similar to Collection homepages) Art Lowel [10:07 AM] Yes it should be [10:08] I left it unclaimed for now to see if @rivaldi8 wanted to claim it :slightly_smiling_face: [10:08] but if not I’ll ask lotte to work on that when she’s done with the dso lists Tim Donohue [10:08 AM] (Note: I think rivaldi8 isn't in Slack yet...we may want to ping him via GitHub and/or invite him to join us in Slack) Art Lowel [10:09 AM] He _was_ on slack [10:09] the fact that his name no longer autocompletes may mean he’s closed his account (edited) [10:09] or that he’s changed it Tim Donohue [10:10 AM] huh, maybe he did. Well, we can ping him via GitHub I guess. I'm not seeing his name here in the list anymore either way [10:10] So, were there other updates to add in here, @art-lowel ? Art Lowel [10:10 AM] yeah [10:10] I saw you reviewed that PR of mine that adds support for embedded resources [10:10] https://github.com/DSpace/dspace-angular/pull/99 [10:11] did you get a chance to test it again after I added instructions on how to? Tim Donohue [10:11 AM] (Sidenote: Oh wait, my apologies, rivaldi8 *is* here in Slack. He's @alexm in here) (edited) Art Lowel [10:12 AM] Good news :slightly_smiling_face: Tim Donohue [10:12 AM] I have not had a chance to re-test PR#99. Honestly though, It looks good codewise, so if it's holding anything up, I'd say merge it. I may not get back to testing it until tomorrow at the earliest Art Lowel [10:12 AM] I see there are merge conflicts on that PR now [10:12] I’ll fix them ASAP Tim Donohue [10:12 AM] thanks Art Lowel [10:13 AM] is there a way to get notified of them automatically? Tim Donohue [10:13 AM] Not to my knowledge. That'd be a nice feature of GitHub though Art Lowel [10:13 AM] yeah [10:14] So I’ll fix the conflicst verify that the AoT build and the tests still work, and merge it Tim Donohue [10:14 AM] Sounds good to me Art Lowel [10:14 AM] because it is a prerequistie for the switch to the live rest backend I’m working on atm
Tim Donohue [10:15 AM] Yes, I don't want to hold that up :wink: Art Lowel [10:15 AM] Here you can find a branch that’s mostly working: [10:15] https://github.com/artlowel/dspace-angular/tree/live-rest-backend Andrea Bollini [10:15 AM] :slightly_smiling_face: you have anticipated my question Art Lowel [10:15 AM] However bitstreams on item pages don’t work yet [10:15] because bitstreams are currently a property of an Item, they’re not considere realted resources by the rest api [10:15] e.g. if you look here: [10:15] http://dspace7.4science.it/dspace-spring-rest/#/dspace-spring-rest/api/core/items/9f3288b2-f2ad-454f-9f4c-70325646dcee [10:16] You’ll see that bitstreams are not in the `_links` and `_embedded` sections but, like metadata, bitstreams is a direct property of an item Andrea Bollini [10:16 AM] ohh I haven't noted yet! Art Lowel [10:17 AM] so that wasn’t purposfully done that way? Andrea Bollini [10:17 AM] no by me :slightly_smiling_face: Tim Donohue [10:17 AM] Sounds like a bug then :wink: Art Lowel [10:18 AM] Good, because it would save me some issues if I didn’t have to account for that :slightly_smiling_face: Andrea Bollini [10:18 AM] absolutely [10:18] we need to agree about the relation [10:18] item -> bitstreams ? or item -> bundles -> bitstreams ? Art Lowel [10:19 AM] yeah, we discussed bundles briefly last week Andrea Bollini [10:19 AM] we can also change later, but for OR we need to decide one of the two Art Lowel [10:19 AM] I also added a comment to the Jira ticket about that [10:19] https://jira.duraspace.org/browse/DS-3490 [10:19] to recap: I don’t mind that bundles are now a field on bitstreams [10:20] but we have to ensure that we don’t lose features in the process [10:20] such as the primaryBitstream property Andrea Bollini [10:20 AM] I know that most out of there are in favor to remove bundle... but I'm a fan of them [10:21] so, for me it makes perfect sense to keep them in place as first citizen, this should mean to have bundles inside the item and not directly the bitstreams Art Lowel [10:22 AM] I have adapted the UI to the fact that they’re gone now, but it wouldn’t be hard to change back Tim Donohue [10:22 AM] That's fine by me for now. I wasn't meaning to imply we should remove them now. Perhaps this is a decision we should wait on (i.e. leave them in place as a first class citizen until we are sure we have a better plan) (edited) Art Lowel [10:23 AM] yeah, because I like the idea @mdiggory added to that ticket [10:23] to consider bundlenames to be something like s3 buckets Tim Donohue [10:23 AM] And that seems to be how the mockups treat Bundles here: https://github.com/DSpace/dspace-angular/blob/master/src/backend/items.ts Art Lowel [10:23 AM] but that would probably lead us too far right now Andrea Bollini [10:23 AM] (I haven't noted the comment... unfortunately I was not watching the ticket... my fault) Tim Donohue [10:24 AM] So, my simple question here is... is this something we can "solve" quickly (in some way) prior to OR2017? [10:24] I'd really like to have bitstreams "working" at least at some level Art Lowel [10:24 AM] The quickest way to solve it right now (for me anyway) is to leave bundles out [10:25] but we do have to add bitstreams as a relation, not a property Andrea Bollini [10:25 AM] on the rest side it will take the same time and yes, we will definitively have a relation (_link) in place here Art Lowel [10:25 AM] great [10:26] and then I’d just leave that ticket open, or another place to discuss the issue so it gets handled properly eventually Tim Donohue [10:27 AM] So, what should be our plan for OR2017 then? Just create a new ticket about the relation (_link, etc) bug, and get that resolved ASAP? And then leave bundles to post-OR2017? Art Lowel [10:27 AM] That’s what I proposed yes Tim Donohue [10:28 AM] Does that sound reasonable to you @bollini? Is the relation bug solvable quickly? Or do you need to look at it more?
Andrea Bollini [10:28 AM] ok. Just a note my intent was to use the rest-api half hour to plan for OR Tim Donohue [10:28 AM] Ok, well, we are almost into that 1/2 hour anyhow :wink: So, we could move this discussion over to #rest-api, if you wish Andrea Bollini [10:29 AM] yes, just in case other want to check Tim Donohue [10:29 AM] Ok, let's do that. Moving over to #rest-api now. I'll let #dev know as well Andrea Bollini [10:29 AM] oh sorry, @atarix83 probably want to say something about his tickets Giuseppe Digilio [10:30 AM] only one thing, I think to start working on https://github.com/DSpace/dspace-angular/issues/103 maybe early next week Tim Donohue [10:31 AM] @atarix83 : thanks for the update on that. Sorry to cut you off [10:31] @art-lowel : see above final update
Art Lowel [10:31 AM] :white_check_mark: |