If you identify any potential areas where the DSpace code/architecture could do with some cleaning up, please add them here.
Add
/dspace/bin |
wrapper scripts for all command-line tools
Remove calls to
System.exit |
from any method that isn't
public void main(String[""]) |
Eliminate business logic from
jsp/edit-metadata.jsp |
(and any other offending JSPs)
Using enums instead of
public static final int |
s etc
Collection.countItems() |
throws an
SQLException |
, but is directly used by JSPs. This isn't following the usual DSpace servlet/JSP idiom; in general, all database access activity should be complete before control of a request passes to a JSP, so that an error is unlikely to occur halfway through rendering a page.
Creative commons licenses go in the
CC_LICENSE |
bundle, but a deposit license (the license that a depositor grants the host institution to redistribute/migrate an item) goes in the
LICENSE |
bundle. Why not just
LICENSE |
for both??
(Wouldn't it be better to be as granular as possible - can always go from granular to general easily but the inverse not true. If we are able to distinguish between different license bundle types institutions can treat CC and site license differently if they want, and others can generalise if they wish. If you generalise all license types up front you can't go the other way without looking at filenames and content --SY)
why do the stylesheet include
nowrap |
directive for
navigationBarItem |
? If we need, we can insert
|
s in the message. If it wouldn't be nowrapping style (along with some other styles) there could be many
<br/> |
tags eliminated from the Messages file. If some styles must be kept nowrapping, then
<br/> |
tags must be allowed in the message keys: it's much better to have a message
"Primary<br/>Bitstream |
" than having 2 separate messages that by accident would be traslated independently each other.
Should be easier to specify an alternative location for DSpace than
/dspace |
in
dspace.cfg |
. Perhaps other
.dir |
properties should be permitted to be relative to
dspace.dir |
? Or somehow refer to it? (e.g.
\{dspace.dir\}/search |
. Then you could just change
dspace.dir |
to move the whole install. Done
LDAP authentication: Should have been implemented as a separate implementation of
SiteAuthenticator |
rather than added to
SimpleAuthenticator |
. Needs to be cleaned up as part of moving to StackableAuthenticationMethods