View Source

Date

25 Oct 2019 from 15:00-16:00 UTC

As of Oct 31, 2019 this meeting has switched to 15:00 UTC (as daylight savings ends in Europe on Oct 27). This means the local time will be unchanged for European attendees.

In North America, as daylight savings ends one week later (on Nov 3), attendees will attend this meeting at 11:00am EDT on Oct 31, but as of November 7 it will switch back to 10:00am EST.

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

More connection options available at DSpace Meeting Room

Agenda

(15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).
- Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
- Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
(30 mins) General Discussion Topics
1. Revisiting Authorization Discussion (from last week's meeting). Andrea Bollini (4Science)will provide a draft REST Contract for how to check authorizations (using the AuthorizeService)
2. Reviewing & scoping tasks flagged as "NEEDS MORE INFO" in Development Planning Spreadsheet
  1. This is necessary to prepare for the next phase of the DSpace 7 Estimation Process
(15 mins) Planning for next week
- Assigning PRs for Review
- Next tasks from Development Planning Spreadsheet

Attendees

Current Work

= Highest Priority tasks (please prioritize these reviews/tasks over others). These are tasks with lots of dependencies

= review done, changes were requested or bugs found.

= review done, approved.

= review done, merge conflict or other minor changes requests

= pull request only requires a single approval to merge. This is generally reserved for PRs which are either smaller, obvious, and/or bug fixes with tests to prove they work.

Tickets / PRs In Progress

(Angular) Adding Accessibility via Travis CI https://github.com/DSpace/dspace-angular/pull/356 (work in progress) (Lower priority)
(Angular Bug) https://github.com/DSpace/dspace-angular/issues/368 ( Art Lowel (Atmire) )
(REST Contract) Edit Homepage news: https://github.com/DSpace/Rest7Contract/pull/45 (Ben Bosman - has outstanding questions/comments) (Lower priority)
(REST) DS-4043: Revisit the security layer of the submission (work in progress) Andrea Bollini (4Science)
(REST) Pagination bug with withdrawn items: https://github.com/DSpace/DSpace/pull/2406 (Dimitris Pierrakos , Ben Bosman - Feedback provided)
(REST Contract) ResourcePolicy endpoint - coming before next meeting

PRs Needing Review

(REST Contract) Group and eperson management: https://github.com/DSpace/Rest7Contract/pull/41 (Tim Donohue - feedback provided, Andrea Bollini (4Science) - feedback provided)
(NEW) REST Contract for resourcepolicies: https://github.com/DSpace/Rest7Contract/pull/87 (Ben Bosman , Tim Donohue )
(REST) Scripts and processes endpoint https://github.com/DSpace/DSpace/pull/2529 FEEDBACK HAS BEEN PROCESSED (Tim Donohue - concerns about creating a lot of new Controllers, Dimitris Pierrakos) - Was reviewed by Ben Bosman internally.
(REST) Ds 4317 bundles in rest https://github.com/DSpace/DSpace/pull/2548 ( Ben Bosman, Tim Donohue - concerns about creating a lot of new Controllers, Chris Wilper )
1. Also requires an Angular branch (WIP)
(REST) REST Projections initial PR: https://github.com/DSpace/DSpace/pull/2547 (Andrea Bollini (4Science) , Ben Bosman , Tim Donohue )
(REST) Ds 4358 tests in modules https://github.com/DSpace/DSpace/pull/2553 (Tim Donohue - dependencies need cleanup, NEEDS SECOND REVIEWER)
(REST) CRUD on Collection & Community logo https://github.com/DSpace/DSpace/pull/2562 (Chris Wilper, Tim Donohue)
(Angular) Shibboleth integration support: https://github.com/DSpace/dspace-angular/pull/429 (Giuseppe Digilio (4Science) reviewed again fixed error with yarn start, Fernando FCT/FCCN, Paulo Graça - feedback provided)
(Angular) forceBypassCache should be removed from the RequestService: https://github.com/DSpace/dspace-angular/pull/468 (Art Lowel (Atmire) - approved again, Giuseppe Digilio (4Science) )
(Angular) Routing by handle and uuid: https://github.com/DSpace/dspace-angular/pull/490 (Art Lowel (Atmire) - provided feedback, Giuseppe Digilio (4Science), Tim Donohue , Andrea Bollini (4Science) - might be able to help with pid endpoint)
(Angular) Tracking stats from the UI https://github.com/DSpace/dspace-angular/pull/495 (Tim Donohue , NEEDS SECOND REVIEWER)
(Angular) (HIGH PRIORITY) Refactor object lists https://github.com/DSpace/dspace-angular/pull/497 (Giuseppe Digilio (4Science), Tim Donohue)
(NEW) (Angular) Add community & collection tree https://github.com/DSpace/dspace-angular/pull/505 (Tim Donohue , NEEDS SECOND REVIEWER)
(NEW) (Angular) (HIGH PRIORITY) i18n sync script https://github.com/DSpace/dspace-angular/pull/504 (Giuseppe Digilio (4Science), Tim Donohue , Bram Luyten (Atmire) )
(NEW) (Angular) Edit collection - content source tab https://github.com/DSpace/dspace-angular/pull/506 (Paulo Graça , NEEDS SECOND REVIEWER)
(Backend) dspace.bat file: https://github.com/DSpace/DSpace/pull/2544 (Tim Donohue - will test on Windows, Alexander Sulfrian, Chris Wilper , Andrea Bollini (4Science) - will test on linux)

PRs Merged this week!

(REST Contract) bundle DELETE contract https://github.com/DSpace/Rest7Contract/pull/86
(REST) DS-4337 implement bitstream-bitstreamformat relation endpoints https://github.com/DSpace/DSpace/pull/2503

Blocked

(Blocked PRs go here)

Delayed / Needs Discussion

Managing Authorization info in Angular UI: How to pass Authorization rights (i.e. logged in user's access rights) from REST API to Angular? See for example: https://github.com/DSpace/dspace-angular/issues/393
1. Can this be achieved via passed HAL "_links" (e.g. the existence of an "edit" link in REST response means you must have Edit rights)?
2. In July 25 meeting, we noted this probably cannot be resolved with just one simple solution. May need to look at different options for different scenarios
  1. Also likely to need to store/cache a user's Groups in UI layer, as some areas (e.g. Administrative) require knowledge of user group membership

Andrea Bollini (4Science) has investigated on that and created the following resources/proposals:

REST Authorization

https://github.com/DSpace/Rest7Contract/pull/87

https://github.com/4Science/Rest7Contract/pull/1

2. REST API Projections:

Early work begun at https://github.com/DSpace/DSpace/pull/1847. Discussed in more detail in our Aug 22 meeting. Overall, this approach seems like a good direction, need volunteers to move it forward.
1. https://github.com/DSpace/Rest7Contract/issues/2 (discussion resumed by Andrea Bollini (4Science) could be relevant for the projection)

Initial Performance Testing from Chris.
1. https://cwilper.github.io/dspace-perftest/
(REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
1. Delayed until after Preview release. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior. Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata. Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.
2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question. May allow for more CMS-lite behavior in the future
3. Timeline for this is uncertain. Possibly in 7 or 8. May depend on how/whether it can be scoped.
Concurrency in DSpace 7 (or 8). What do we want to do when multiple editors are editing the same object? Needs further analysis regarding implementation details
1. We've decided (in meeting on March 7, 2019) to use ETags to implement concurrency. REST Contract notes on ETags: https://github.com/DSpace/Rest7Contract#etags--conditional-headers
2. ETags only update of the two fields match. If someone edits first, your edit would fail and you would get a fail response (422?)
3. ETags seems to have broader support in other REST APIs. Recommended also by both Art and Andrea.

Notes

Discussions of Managing Authorization Info sharing between REST API and Angular UI
- Andrea talked us through REST Authorization notes
- Also contract on "resourcepolicies": https://github.com/DSpace/Rest7Contract/pull/87
- All agree this "features" endpoint seems in line with ideas from last week's discussion
- We need to keep a tight scope here...we don't want to reinvent/recreate the Authorization system in v7 (that's out of scope). But, we do want to see if we can remove authorization "decisions" (i.e. code) from the Angular UI layer, and ensure they are made in the REST or Java API. In v6, some of these decisions were in the Java API, but some were wrongly made in the XMLUI and JSPUI.
- Ben questions on how to get embargo dates back from new "features" endpoint? Andrea notes that the embargo date will be available from the resourcepolicies endpoint (at least for now). So, this may need to be two calls.
  - Tim notes that in future (v8 or beyond) there may be opportunities to simplify (and maybe even remove need for resourcepolicies endpoint), but we need to not put too much in scope of v7.
- TODO: Andrea will create a Contract for the "features" endpoint for next week
- Implementations for both these endpoints (resourcepolicies and features) is being planned for new student working at 4Science
  - These are HIGH PRIORITY endpoints though, so the sooner we can agree on REST Contracts, the sooner the implementation can occur & get reviewed. Maybe even by end of Nov if we act quick.
  - TODO: All should review resourcepolicies contract to move forward. Also review the notes Andrea created on (upcoming) features endpoint to ensure no further major questions.