Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
Discussion (combined Angular UI & REST meeting)
Attendees
Notes
- General updates (from Tim)
- Nothing to share today. Not as much activity because of Thanksgiving holiday in USA last week
- Angular UI Team updates (from Art)
- Merged several PRs:
- Needs review PRs
- New Travis PR from Courtney: https://github.com/DSpace/dspace-angular/pull/208 (Tim will review)
- Needs testing that grid view works: https://github.com/DSpace/dspace-angular/pull/202 (Tim will also look at. Currently build issues in Travis though)
- Lotte working on truncation of text based on window width, etc. It's a bit of a challenge
- Also working on adding in missing tests, e.g. https://github.com/DSpace/dspace-angular/pull/205 (Please review)
- We should work to merge the missing tests ASAP, and have separate followup PRs
- Art has 3 in progress PRs. Looking to make progress on those in coming weeks
- Andrea announces that two new developers will be joining the Angular UI development efforts soon: antonioru and andreachiapparelli
- They will be concentrating on the Submission UI. Art already gave them commit access to dspace-angular
- Is anyone ready to work on Authentication at the Angular UI level (once merged into REST API)?
- Art says likely not before end of year, at least for him. But, it's a high priority after that.
- Andrea notes that maybe new developers could look into it, if they find it is needed before early next year.
- Andrea notes the 4Science team also looking into building the MyDSpace UI. It'll be based on the new Search UI code, as the new design is tabbed interface to view/search/sort your past submissions, tasks, etc (See MyDSpace as a dashboard)
- REST API Updates
- Contract updates
- Merged: https://github.com/DSpace/Rest7Contract/pull/13
- Implementation at: https://github.com/DSpace/DSpace/pull/1881
- Code Style updates
- Andrea notes that recent PRs have shown that we really could use a definitive Code Style for `master`. It's hard to review PRs which make a lot of small alignment or similar changes.
- Tim had started this effort at Code Style Guide. But, set it aside, as was worried about affecting development on master
- Now may be the time to try to move this forward more rapidly. Let's get this into master by early 2018 (or earlier if possible) as it'll help in the long run.
- Ready to merge: https://github.com/DSpace/Rest7Contract/pull/18
- Contract for CLI/Curation tasks: https://github.com/DSpace/Rest7Contract/pull/17
- Tim concerned about expanding our scope here to include other CLI tasks
- Art notes that Tom's plan was to build this more for Curation, but build it in a flexible way so as to support other CLI tasks. Initially maybe only a few CLI tasks would be enabled, and we'd enable/refactor others in the future
- Andrea likes this idea / contract PR
- Tim agrees with Tom's approach. Let's move this forward, but keep in mind that we should concentrate on Curation tasks, and not put too much effort into enabling many CLI tasks (those could come later)
- Needs a review: https://github.com/DSpace/Rest7Contract/pull/16 (Tim will look at this. Previously reviewed implementation)
- Implementation is now one massive PR: https://github.com/DSpace/DSpace/pull/1889
- It was too hard to break up, and the three PRs were overlapping
- We'll need to test this using the example curl commands in PR#16, when it's ready. Still a WIP though
- Implementation is now one massive PR: https://github.com/DSpace/DSpace/pull/1889
- RE-REVIEW: https://github.com/DSpace/DSpace/pull/1884 Recent updates from Tom need re-reviewing. This looks like it's almost ready
- Good work from Tom & others at Atmire on enhancing integration tests: https://github.com/DSpace/DSpace/pull/1893
- We'd like to see this initial PR get merged soon (once WIP can be taken off) and follow it up with additional PRs for any other integration tests
- I.e. let's not wait for all integration tests, but merge several smaller PRs more rapidly.
- Ready to merge: https://github.com/DSpace/DSpace/pull/1881
- Stateless AuthN. Andrea plans to give it a test and then merge it: https://github.com/DSpace/DSpace/pull/1873
- NEEDS MORE DISCUSSION: https://github.com/DSpace/DSpace/pull/1879
- Andrea notes most of the changes are at the Java API level, not in REST. This could be reviewed by someone else. Tim will ping other Committers on this & bring to next DevMtg (next Weds) as needed
- Art notes that Tom is working on following as well:
- This bug:
- Also looking into generating Spring REST docs on this branch: https://github.com/atmire/DSpace/tree/DS-3484_Spring-REST-Docs
- Contract updates
- Schedule for rest of year.
- Tim is only around on Dec 7 and 14. On vacation/holiday from Dec 18 - Jan 2.
- Art & Andrea said they are both around on Dec 21 as well. But, after that are on holiday until week of Jan 8.
- So, on Dec 21, Art and Andrea could touch base if they wanted. After that, the next meeting would be Thurs, Jan 11 (once all have returned).
- Open Repositories 2018
- Proposal deadline is JAN 5!!
- Started brainstorming workshops & talks
- Tim started a Google doc for this brainstorming. All our notes/brainstorms have been added there. Feel free to enhance!
- https://docs.google.com/document/d/1LL3czkqklcZpSnDT7bvjmSu4FqzOa6uX7KIMO69PSBk/edit
- Next Meeting will be Thurs, Dec 7 at 15:00UTC via Google Hangouts
Overview
Content Tools