Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
Discussion (combined Angular UI & REST meeting)
Attendees
Notes
- Angular UI Team updates (from Art)
- Lots of great work this week on Angular UI. All these PRs were merged:
Plus these new bugs/issues were discovered, fixed and merged:
- Also added Coveralls this week to check our spec/test coverage. We've setup GitHub to faile PRs which decrease test coverage by more than 1%
- https://github.com/DSpace/dspace-angular/pull/157
- After enabling Coveralls though, we realized the initial numbers were inaccurate, as it only calculates coverage on classes loaded into test environment.
- William Welling will investigate how to get a more accurate coverage percentage, and start to add in some missing top level route tests
- PRs for review
- https://github.com/DSpace/dspace-angular/pull/163 (Approved and merged)
- https://github.com/DSpace/dspace-angular/pull/169 (To be merged)
- https://github.com/DSpace/dspace-angular/pull/168 (To be merged)
- New tasks added for Search functionality:
- REST API Updates (from Andrea)
- Andrea Bollini (4Science) is out today, but passed along his updates via Slack
On the REST part it will be nice if
you can check if there is an agreement on https://github.com/DSpace/DSpace/pull/1726 and eventually merge
- Tom said looks good enough for now. Tim will review too
discuss further the https://github.com/DSpace/DSpace/pull/1843 as there are some questions that need clarifications
- Mark W attended meeting and said he was satisfied. Wanted to just be sure his question was being considered as this moves forward
verify the latest comments on https://github.com/DSpace/Rest7Contract/pull/11
In progress PRs that could receive reviews:
Tickets that need volunteers
- test framework for the REST webapp
- Tom Desair may be interested. Art will ask
- authentication, we have had a very useful conversation on that in August but now we need to start some concrete exploration https://github.com/DSpace/Rest7Contract/issues/10
- Art thinks Tom has been doing a bit of testing. May need to get a report back, if so.
- test framework for the REST webapp
- Discussion of Testing of Java API / REST API
- Tim is investigating enabling ErrorProne on "master" branch: https://github.com/google/error-prone and http://errorprone.info/
- It has already find a good number of minor issues in our Java API
- PR will be coming along with fixes
- Tim also investigated enabling Unit Test coverage on "master" (via Coveralls or similar) like we've done on dspace-angular
- Unfortunately, this is not easy to do. Our Unit Test classes were never refactored in line with the DSpace 6 API refactor (e.g. DSpace 6 API has "ItemService" classes, but unit tests are still named "ItemTest")...so, coverage tests report 0% coverage. We'd have to refactor Unit Test classes first, then work to add in more coverage. Tim will create a JIRA ticket about this.
- Ticket created:
- Tim is investigating enabling ErrorProne on "master" branch: https://github.com/google/error-prone and http://errorprone.info/
- Giuseppe mentions he's still having issues when debugging code with Lazy Routes. Will create a ticket about this in dspace-angular to discuss how to more easily debug code when using Lazy routing.
- Next Meeting is Thurs, Oct 12 at 15UTC via Google Hangouts
- Give updates on latest status.
- Report back from next DSpace 7 Outreach meeting on Oct 11.
- Everyone should also add more feedback to the Submission wizard and Duplicate detection and merge tool mockups