Date
Call-in Information
Time: 10:00 am, Eastern Standard Time, or 4:00 pm, Central European Time
Join Zoom Meeting
https://lyrasis.zoom.us/j/81398228834?pwd=SE0wdFN3NnFVbEhYVUhuM3BtQmVUQT09Meeting ID: 813 9822 8834
Passcode: 728426- calendar invitation - ics
Attendees
Indicating note-taker
Agenda
- Dependencies
- Orcid client api
dependency-check-maven
- replace with https://github.com/marketplace/actions/dependency-check
- upgrade https://github.com/chenejac/Vitro/commit/dc8b2b1e9aaaff3ba706dfe4af751ea78ebe240e, and use mvn site
- GitLab self-managed instance
- PRs
- M1 mac chip and VIVO
- Captcha
- I forgot my password
- Avoid lock on graph uri update in RdfServiceSparql
- ABAC
- Dynamic API: XML transformation logging
- Wilma theme
Notes
- Dependencies
- Orcid client api
Dragan identified vulnerabilities in the orchid client API linked to Jackson Data Bind library and proposed an update to resolve the issue (https://github.com/vivo-project/orcid-api-client/pull/17). Dragan suggested releasing a new version of the ORCID client API and updating this dependency in the VIVO/Vitro project.
- Dependency-check-maven
The dependency-check-maven library is outdated and there is a security vulnerability. Dragan and Georgy discussed whether dependency-check-maven is needed at all in the VIVO/Vitro codebase. Dragan suggested to upgrade the library (https://github.com/chenejac/Vitro/commit/dc8b2b1e9aaaff3ba706dfe4af751ea78ebe240e), and to investigate whether it can be used in some github action. Georgy suggested to investigate mvn verify, it might include some report generated from dependency-check-maven.
- GitLab self-managed instance
We discussed possible alternatives to GitLab self-managed instance for mirroring GitHub repositories. Dragan suggested investigating using the gitlab.com SaaS solution and offered licenses (https://about.gitlab.com/pricing/). The team agreed to investigate the volume of a backup from Litvinovg's Gitlab instance and consider requesting an enterprise license from their leaders due to storage limitations.
- PRs
- M1 mac chip and VIVO
The fix is working for Milos Popovic’s laptop, and we are investigating at the moment whether it is working on Kshitij Sinha’s laptop.
Ivan Mrsulja found that some UI messages in contact form are hard-coded in the Java code. Ivan will refactor that to be i18n and suggest draft versions of translation by using ChatGPT. Dragan will coordinate validation of those messages by native speakers. Google reCAPTCHA not working behind an http proxy. Dragan suggested defining the proxy parameters in the running properties file in a separated PR. The team discussed the issue of HTTP proxy and its configuration in their system. They agreed to investigate further, particularly regarding the use of the HttpClient and the potential need for proxy configuration in different parts of their system.
- I forgot my password
This PR should be rebased to the main branch once CAPTCHA improvement PR is merged.
- Avoid lock on graph uri update in RdfServiceSparql
Brian will try to find time to review this PR.
Dragan asked about the progress on basic access control PR. Georgy discussed a series of commits he had made to the ontology, with Dragan seeking clarification on the purpose of these commits. They also discussed a pending PR commitment and the need for documentation and potential presentations in future meetings.
This might be ready for merging. Dragan will review PR and communicate with Georgy if some improvement is needed.
- Dynamic API: XML transformation logging
This is already merged
Dragan discusses an issue with the nemo theme reported by Rodrigo Villagran and mentions that Milos Popovic has resolved the issue (https://github.com/vivo-project/VIVO/pull/3921). Benjamin Gross suggested via PR comment to consider upgrading JQuery. We are planning to make the nemo theme deprecated, so don’t want to investigate too much effort in resolving issues with this theme. Brian asked whether JQuery is used in the wilma theme. Dragan will check this, if it is the case then it should be upgraded, but if it is only used in the nemo theme, the fix created by Milos is good enough. The team has three tasks to complete: complete a fix for Nemo, merge the responsive Wilma team, and to make nemo and tenderfoot themes deprecated (separated directory and warning about using deprecated themes).
Actions
- Dragan Ivanovic to discuss with Milos Popovic about usage of JQuery in the nemo theme
- Georgy Litvinov to provide Dragan the information about volume size needed for mirroring GitHub into GitLab
- Dragan Ivanovic and Georgy Litvinov to complete merging the ABAC PRs
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/424
Previous actions
- Dragan Ivanovic to review extended search PR and Avoid lock on graph uri update in RdfServiceSparql PR
- William Welling will continue working on vivo-solr upgrade branch
- Ivan Mrsulja will consider adding a configuration flag for turning on/off the "I forgot my password" feature
- Dragan Ivanovic to talk with Ivan Mrsulja about improvements of https://github.com/vivo-project/Vitro/pull/421 in accordance with committers' discussion
- Dragan Ivanovic to inform Miloš Popović that bootstrap javascript functions are used in the extended search
- Georgy Litvinov to continue working on ABAC PR and inform us back when it is completed and ready for testing and reviewing
- Dragan Ivanovic to open a GitHub ticket for Mac M1 chip issue
- Dragan Ivanovic to create a PR for upgrading slf4j-log4j12 - https://github.com/vivo-project/Vitro/blob/main/dependencies/pom.xml#L215
- All will review assigned PRs
- Dragan Ivanovic will open a GitHub ticket for Log4j vulnerability
- Dragan Ivanovic will open a GitHub ticket for Removing trash icon for some specific types
- Dragan Ivanovic will further investigate mirroring GitHub repositories to a self-managed instance of a GitLab platform
- Georgy Litvinov will upgrade https://github.com/vivo-project/Vitro/pull/398
- Dragan Ivanovic should investigate https://github.com/marketplace?category=backup-utilities
- Dragan Ivanovic to prepare VIVO 1.14.0 release
- Dragan Ivanovic to prepare release candidate 4
- Georgy Litvinov to align https://vivo.tib.eu/vivorc/ with release candidate 4
- Dragan Ivanovic to respond to slack messages
- Dragan Ivanovic will try to collect wiki pages where strategy, vision and roadmap for development of VIVO were discussed in the past
- Georgy Litvinov will try to address the issue https://github.com/vivo-project/VIVO/issues/3871
- Dragan Ivanovic will ask Michael to open a GitHub ticket for the issue about UF performance during login (https://vivo-project.slack.com/archives/C8RL9L98A/p1684174222986709), Brian Lowe and others can continue discussion about this issue once a ticket is open
- Dragan Ivanovic will ask Rodrigo to open a GitHub ticket for the issue about custom theme and VIVO Docker (https://vivo-project.slack.com/archives/C8RL9L98A/p1684962021101889), William Welling and others can continue discussion about this issue once a ticket is open
- Brian Lowe to open a GitHub issue for index page exception
- https://github.com/vivo-project/VIVO/issues/3867
- add sample (minimal RDF to reproduce the issue)
- Miloš Popović or Ivan Mrsulja to review (https://github.com/vivo-project/VIVO/issues/3862)
- Georgy Litvinov to review (https://github.com/vivo-project/VIVO/issues/3847)
- Review (https://github.com/vivo-project/VIVO/issues/3865)
- Review (https://github.com/vivo-project/VIVO/issues/3864)
- Review (https://github.com/vivo-project/VIVO/issues/3858)
- Review (https://github.com/vivo-project/VIVO/issues/3859)
- Review (https://github.com/vivo-project/VIVO/issues/3855)
- Review (https://github.com/vivo-project/VIVO/security/dependabot/3)
- Brian Lowe and William Welling to review https://github.com/vivo-project/VIVO/pull/3853
- William Welling to review https://github.com/vivo-project/VIVO/pull/3861
- All to think how to organize scripts for VIVO (at the moment for dump and restore) - https://github.com/vivo-project/Vitro/pull/380
- Dragan Ivanovic to make consultation with the VIVO ontology group and Lyrasis system administrators about non-resolvable VIVO ontology links
- Committers to take part in the sprint PR review process
- Dragan Ivanovic to make a PR for fixing privileges for adding grant collaborators
- Brian Lowe to make a PR for fixing ordering of instances with multilingual properties
- Georgy Litvinov will investigate the problem of searching instances with multilingual properties
- Ralph O'Flinn to help with Preparing Documentation for Release by coping space VIVO 1.12.x Documentation to the space VIVO 1.13.x Documentation (or to grant Dragan Ivanovic permissions to do that)
- Dragan Ivanovic to work on documenting new features for VIVO 1.13.x Documentation
- Dragan Ivanovic to create the third one google form for reporting the testing results, that form should be used for testing new features introduced in VIVO 1.13.0
- Everyone to review https://docs.google.com/forms/d/13W2vynR6OmavoV2Px_kJ-k-dlQDv3ERWG0PnXX7ekQA/edit?usp=sharing and https://docs.google.com/forms/d/1dks3b3sJsmM7Q33bwHW_1iVem5VRjg3fqpx8UTFKIfI/edit?usp=sharing
- Brian Lowe to work on removing spring dependencies (https://github.com/vivo-project/VIVO/issues/3686)
- Georgy Litvinov to work on PR for merging back a lost fix he noticed
- Everyone to review spreadsheet for defining requirements for JS and CSS framework selection - https://docs.google.com/spreadsheets/d/1p-86FdqQR2SpFIsK5Xa-k6Dgm5ORg6Lrc7eeOEetm8g/edit?usp=sharing
- Benjamin Gross to review https://github.com/vivo-project/Vitro/pull/251
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/251
- Georgy Litvinov to fix the issue with GitHub action https://github.com/vivo-project/Vitro/pull/269
- Ralph O'Flinn to review https://github.com/vivo-project/Vitro/pull/269
- William Welling to review https://github.com/vivo-project/Vitro/pull/269
- Georgy Litvinov to update pom versions in https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Dragan Ivanovic to review and merge https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Georgy Litvinov to review https://github.com/vivo-project/VIVO/pull/3613
- Dragan Ivanovic to review https://github.com/vivo-project/Vitro/pull/240
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/240
- Ralph O'Flinn to publish orcid-api-client 0.6.4 and update version of this library at https://github.com/vivo-project/VIVO/blob/main/api/pom.xml#L62
- Dragan Ivanovic to create announcement for the demo meeting and to spread it
- Dragan Ivanovic to reorganize code of https://github.com/vivo-project/Vitro/pull/287 and to get rid of enumerations for data types
- Dragan Ivanovic to investigate organizational (management) aspects of DSpace community and to prepare discussion for the next meeting what might be adopted from there (GitHub actions, labels for issues, template for issue, template for PR)
- William Welling Georgy Litvinov to review sprint PRs (there should be three PRs)
- Brian Lowe to review N3Template operation PR (https://github.com/vivo-project/Vitro/pull/286)
- Georgy Litvinov to review/test https://github.com/vivo-project/orcid-api-client/pull/12
- Ralph O'Flinn to merge https://github.com/vivo-project/orcid-api-client/pull/12 and publish orcid-api-client 0.6.4
- Georgy Litvinov to complete https://github.com/vivo-project/Vitro/pull/251
- Ralph O'Flinn to merge https://github.com/vivo-project/VIVO/pull/3611, after that Georgy Litvinov will create a branch for the sprint and move the code from his fork to there
- Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
- Georgy Litvinov to work on specification for Dynamic API, Dragan Ivanovic to help Georgy on request
- Ralph O'Flinn to resolve missing i18n directory issue in VIVO 1.12.2 release
- Dragan Ivanovic to find some examples for citation of a GitHub repositories (https://github.com/vivo-project/VIVO/pull/247)
- Georgy Litvinov to contact Tatiana Walther for reviewing https://github.com/vivo-project/VIVO-languages/pull/104 and https://github.com/vivo-project/Vitro-languages/pull/54
- Benjamin Gross to review https://github.com/vivo-project/VIVO/pull/250, https://github.com/vivo-project/Vitro/pull/251, and https://github.com/vivo-project/Vitro-languages/pull/56
- Brian Lowe to review https://github.com/vivo-project/Vitro/pull/213, https://github.com/vivo-project/Vitro-languages/pull/44, https://github.com/vivo-project/Vitro/pull/240, and https://github.com/vivo-project/VIVO-languages/pull/103
- William Welling to review https://github.com/vivo-project/Vitro/pull/241
- Huda Khan to review https://github.com/vivo-project/VIVO/pull/247