2020-05-28 DSpace 7 Working Group Meeting

Date

28 May 2020 from 14:00-15:00 UTC

Location: https://lyrasis.zoom.us/my/dspace (Meeting ID: 502 527 3040).

• More connection options available at DSpace Meeting Room

Agenda

• (15 mins) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

  • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
  • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
• (30 mins) General Discussion Topics
  • (20 mins) Next Steps on BTE transition to Live Import (based loosely on 2020-05-18 DSpace 7 Transition BTE to Live Import Mtg and BTE transition: 4Science implementation proposal and estimation) 
    • 7.0beta3:  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
    • 7.0beta3:  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
    • 7.0beta5:  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
    • 7.1 :  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
    • 7.1 :  Unable to locate Jira server for this macro. It may be due to Application Link configuration.
  • (10 mins) Quick update on Controlled Vocabularies and Authority Control (Discussion may be held for following week)
    • Proposal for addressing side effects: 4Science proposal to improve authority support in DSpace7 
    • Prior discussion documented in Controlled Vocabularies and Authority Control in DSpace 7
  • Tabled Topics (will not be discussed this week, but possible for next week)
    
    • Finalize / approve the initial list of all authorization features which we should implement for the /api/authz/features REST endpoint.  This list of features should be limited to only features which are required to enable/disable User Interface functionality. (In other words, we can always add more features in the future.  We just need to approve the list necessary for 7.0)
      1. Review current spreadsheet (from Andrea Bollini (4Science) ) : https://docs.google.com/spreadsheets/d/1182LcD_WqIZRbUGWpLtBw0aOMR9jhbOVB7GZqtTpR9A/edit?usp=sharing 
         1. Art Lowel (Atmire) : I don't see any immediate issues with the current set of features, but I would prefer a consistent naming scheme. I'd use canDoSomething for everything
         2. Tim Donohue added possible renames of these features based on Art's idea (see cell comments in spreadsheet).  I like the "can[DoSomething]" naming scheme as well.
• (15 mins) Planning for next week
  
  • Assigning PRs for Review
  • (As necessary) claim tasks for next week from DSpace 7 Release Plan spreadsheet

Attendees

• Art Lowel (Atmire) 

• Andrea Bollini (4Science)  

• Tim Donohue

• Lieven Droogmans 

• Giuseppe Digilio (4Science) 
• Ben Bosman
• Paulo Graça 

7.0 Release Goals

These resources define the prioritization and general schedule we are working towards

• DSpace 7 Release Goals : overview of goals/timelines & beta release process
• DSpace 7 Release Plan spreadsheet:  our planning spreadsheet which details which features are scheduled for each Beta release.

Current Work

Claim a Ticket!

If you do not have access in JIRA or GitHub to officially claim the ticket you wish to work on, contact Tim Donohue

• Available Angular UI Tickets
  
  • Open issues in 7.0beta3 milestone (highest priority)
  • Open issues flagged as "Difficulty: low".  These may be a good starting point for newer developers.
• Available REST API Tickets
  
  • Unassigned tickets scheduled for 7.0beta3 (highest priority)
  • General REST API tickets flagged as "low hanging fruit".  These may be a good starting point for newer developers.
  • General REST API unassigned bug tickets.  Again, might be a good starting point for newer developers.

PRs Needing Review

1. (REST Contract) (beta 3) Authorization for Downloads of restricted Bitstreams https://github.com/DSpace/Rest7Contract/pull/126 (NEEDS REVIEWERS)
2. (REST Contract) (beta 4) (hoping to start development next week - PLEASE REVIEW THIS WEEK) Stats reports https://github.com/DSpace/Rest7Contract/pull/125 (Tim Donohue - REREVIEW, Andrea Bollini (4Science)  minor feedback)
3. (REST) (beta3) New user registration & forgot password https://github.com/DSpace/DSpace/pull/2763 (Tim Donohue -  Needs major code cleanup, especially in ITs, Andrea Bollini (4Science) waiting for a better status before review)
4. (REST) (beta3) Scripts & processes: importing and exporting csv's https://github.com/DSpace/DSpace/pull/2648 (Andrea Bollini (4Science) - REREVIEW, Tim Donohue -  prior feedback has not yet been addressed )
5. (REST) (beta3) DS-4042: Fix implementation and add IT for wrong PATCH request in submission: https://github.com/DSpace/DSpace/pull/2760 (Tim Donohue - REREVIEW, Ben Bosman)
6. (REST) (beta 3) CC License support: https://github.com/DSpace/DSpace/pull/2764 (Tim Donohue, Craig Rosenbeck)
7. (REST) (beta 4) Configuration property retrieval Rest endpoint/Google Analytics support: https://github.com/DSpace/DSpace/pull/27621 APPROVAL (Tim Donohue, POSSIBLY A SECOND REVIEWER)
8. (NEW) (REST) Update JQuery and Toastr used in HAL Browser: https://github.com/DSpace/DSpace/pull/2769 1 APPROVAL (NEEDS REVIEWERS)
9. (NEW) (REST) (beta 3) Performance issues with finding Collections a user can submit to  https://github.com/DSpace/DSpace/pull/2771 (NEEDS REVIEWERS)
10. (NEW) (REST) (beta 3) DS-4495 Restricted endpoints are sometimes the only HAL link path to public endpoints REST API v7 https://github.com/DSpace/DSpace/pull/2766 (NEEDS REVIEWERS)
11. (Coming today) (REST) (beta 3) DS-4486 Add support/tests for Collection/Community role-based groups for Community/Collection Admins
12. (Angular) (beta 3) Edit resource policies https://github.com/DSpace/dspace-angular/pull/645 (Tim Donohue, Art Lowel (Atmire)   Julian Timal (eScire) )
13. (Angular) (beta3) Scripts & Processes Admin UI https://github.com/DSpace/dspace-angular/pull/636 (Tim Donohue, Giuseppe Digilio (4Science), Craig Rosenbeck)
    1. Depends on REST PR #2648 (see above) 
14. (Angular) Fix delay in breadcrumb rendering https://github.com/DSpace/dspace-angular/pull/675 1 APPROVAL (Giuseppe Digilio (4Science), Tim Donohue)
15. (Angular) Fix issue with environment UI variables being ignored https://github.com/DSpace/dspace-angular/pull/677 (Paulo Graça , Tim Donohue - Tested and it works, but requested TypeDocs/comments)
16. (NEW)(Angular) Fix authentication issue with CSR https://github.com/DSpace/dspace-angular/pull/682  (Art Lowel (Atmire) , POSSIBLY A SECOND REVIEWER)
17. (NEW) (Angular) Add multi-field sorting https://github.com/DSpace/dspace-angular/pull/634 (NEEDS REVIEWERS)
18. (NEW) (Angular) Fix issue with polyfill order in safari and firefox https://github.com/DSpace/dspace-angular/pull/689 1 APPROVAL  (NEEDS REVIEWER)
19. (NEW) (Angular) New User Registration https://github.com/DSpace/dspace-angular/pull/687 (Art Lowel (Atmire) , NEEDS REVIEWERS)
20. (NEW) Angular UI does not properly logout when clicking logout https://github.com/DSpace/dspace-angular/pull/691 1 APPROVAL (NEEDS REVIEWER)
21. (Backend) (low priority) DS-626 : Exchange usage data with IRUS https://github.com/DSpace/DSpace/pull/2664 (Craig Rosenbeck, Tim Donohue - REREVIEW)
    
22. (Backend) (low priority) (tentative 7.2) DS-4440 GDPR - Anonymize Statistics Feature: https://github.com/DSpace/DSpace/pull/2692 (Andrea Bollini (4Science), Ben Bosman, Tim Donohue)
23. (Backend) [DS-4149] porting XOAI additional indexer https://github.com/DSpace/DSpace/pull/2756 (Paulo Graça  feedback added, Andrea Bollini (4Science) )

PRs Needing Updates  / On Hold

1. (REST Contract) (beta 3) related to the scripts & processes PR above (related to PR 2648 below) https://github.com/DSpace/Rest7Contract/pull/99 (NEEDS UPDATES FROM Kevin Van de Velde (Atmire) ) (Andrea Bollini (4Science) -  REVIEWED, Tim Donohue )
2. (REST Contract) Language support on the backend (possible new cookie for Angular?) https://github.com/DSpace/Rest7Contract/pull/122 ( NEEDS UPDATES FROM Andrea Bollini (4Science) ) (Tim Donohue, Ben Bosman, Art Lowel (Atmire) )
3. (REST) (WAITING ON DISCUSSION, SEE 2020-05-18 DSpace 7 Transition BTE to Live Import Mtg) (tentative 7.1) [DS-4281]: Metadata suggestions in the live import https://github.com/DSpace/DSpace/pull/2712  (Tim Donohue , Andrea Bollini (4Science))
4. (REST) (WAITING ON DISCUSSION, SEE Controlled Vocabularies and Authority Control in DSpace 7) (beta 3) Controlled vocabularyMykhaylo Boychuk https://github.com/DSpace/DSpace/pull/2743 (REST Contract #120) (Tim Donohue, Kevin Van de Velde (Atmire) )
5. (Angular) (WAITING ON PROPOSAL FROM Art Lowel (Atmire) FOR RESOLVING CACHING MISBEHAVIOR IN SUBMISSION UI) Alternative links https://github.com/DSpace/dspace-angular/pull/652 (Giuseppe Digilio (4Science)  feedback added, Tim Donohue -  feedback added)

PRs Coming Soon

1. (beta 3) REST Language Support on the backend Mykhaylo Boychuk (blocked internally, it is under review by Andrea Bollini (4Science))
2. (input from Andrea Bollini (4Science) coming?) Support Community or Collection Admins adding/managing Community/Collection Groups. See  Unable to locate Jira server for this macro. It may be due to Application Link configuration.  and this early brainstorm REST Contract PR

PRs Merged this week!

1.   (HIGH PRIORITY) (REST) (beta 3) Subresources should obey access restrictions (blocks other work) https://github.com/DSpace/DSpace/pull/2726
2.   (REST) (beta3) DS-4499: Fix cleanup of test environment in earlier ITs (and performance increase in ITs): https://github.com/DSpace/DSpace/pull/2759
3.  (REST) Configurable whitelist for "Access-Control-Allow-Origin" header: https://github.com/DSpace/DSpace/pull/2735 1 APPROVAL
4.  (REST) Add JavaDocs to JWTTokenHolder and cleanup related tests: https://github.com/DSpace/DSpace/pull/2765 1 APPROVAL 
5.  (Angular) Login as EPerson  https://github.com/DSpace/dspace-angular/issues/653

Blocked

1. (Blocked PRs go here)

Delayed / Needs Discussion

1. Initial Performance Testing from Chris.  Needs revisiting / retesting prior to 7.0. 
   1. https://cwilper.github.io/dspace-perftest/
   2. These performance tests were run prior to the work on "projections" (to limit the data returned by the REST API).  Therefore, it is likely performance is much improved, but needs verification testing.
2. (REST Contract) Edit Homepage News: https://github.com/DSpace/Rest7Contract/pull/45
   
   1. Delayed. General agreement (in meeting on March 21, 2019) that storing HTML in metadata fields is not really ideal behavior.  Metadata (from a librarian standpoint) tends to be free of format-related markup (as that allows for easier sharing, understanding of metadata.  Currently Community & Collection homepage information is HTML-based and is stored in metadata that is appropriate for a minor subset of information (like the title) but it is better to move large/rich text to bitstreams.  
   2. Proposal here is to consider storing HTML-based markup (for Site, Community & Collection homepages) in Bitstream(s) associated with the object in question.  May allow for more CMS-lite behavior in the future
   3. Timeline for this is uncertain.  Possibly in 7 or 8. May depend on how/whether it can be scoped.

Notes