Contribute to the DSpace Development Fund
The newly established DSpace Development Fund supports the development of new features prioritized by DSpace Governance. For a list of planned features see the fund wiki page.
Date
from 14:00-15:00 UTC
Location: DSpace Meeting Room
Agenda
General development / planning updates (Tim)
- Sprint Planning: DSpace 7 Community Sprints
- DSpace 7 Entities Working Group (2018-19)
- Quick updates on Angular UI tickets and/or PRs (Art)
- Quick updates on REST API tickets and/or PRs (Andrea)
- [Last 10 mins] Development planning/updates in Development Planning Spreadsheet.
Attendees
Notes
- General Updates (Tim)
- DSpace 7 Entities Working Group (2018-19) page now exists. This is a separate/new working group. Call for participants coming in next week or two. First meetings won't start likely until late Aug or early Sept.
- Tim notes that in yesterday's DevMtg, there was discussion about use cases / needs for how to implement Curation Tasks in Angular UI / new REST API. See notes at DevMtg 2018-08-08
- Tim will create an Angular ticket to summarize this discussion and ensure it links back to the notes.
- Angular Team Updates
- Merged PRs:
- In Progress tickets / PRs:
- Tickets / PRs requiring review:
- New PR from Mohamed : https://github.com/DSpace/dspace-angular/pull/282
- Reviewed by Art. Tim will give second review
- Kristoff's Browse By Title / Metadata Pull Request: https://github.com/DSpace/dspace-angular/pull/283
- Needs tests/reviews. Tim will add to his list
- Lotte's final Search PR now ready: https://github.com/DSpace/dspace-angular/pull/280 (However PR now fails tests. Tim notified Lotte via a comment)
- Is dependent on: https://github.com/DSpace/dspace-angular/pull/271 (And this PR has been updated/fixed)
- Is also dependent on https://github.com/DSpace/DSpace/pull/2041 (This PR was replaced by https://github.com/DSpace/DSpace/pull/2163)
- Giuseppe's PR : https://github.com/DSpace/dspace-angular/pull/279
- Art has not had a chance to review
- Tim gave it a test yesterday (see comments on PR). The /submit path seems to work well. But, workspace/workflow items cannot be easily tested, as there's no UI to list them.
- New PR from Mohamed : https://github.com/DSpace/dspace-angular/pull/282
- Next up:
- Kristoff will update old RxJS operators to pipeable to prepare for Angular 6: https://github.com/DSpace/dspace-angular/issues/201
- Lotte to use resolvers to fetch database object while page is loading (to increase performance). This was introduced for Angular 5? Ticket: https://github.com/DSpace/dspace-angular/issues/284
- REST Team Updates
- Merged PRs:
- In Progress tickets / PRs:
- Pablo recently claimed https://jira.duraspace.org/browse/DS-3904
- Tickets / PRs requiring review:
- Pablo's PR needs final approval: https://github.com/DSpace/DSpace/pull/2108
- Tim will move forward
- Pablo notes that there has been frustration with getting PR feedback / reviews over the last month. We need to find ways to improve this
- Tim agrees. Notes that holidays/vacations have slowed down our feedback loop in July & August especially. Hopes we can get back to quicker feedback in September.
- We could also use more people willing to provide code reviews on PRs. Currently, a lot of code reviews wait on Tim, Andrea or Art. Others are starting to join in (like Terry), but could use more folks reviewing each others' code.
- https://github.com/DSpace/DSpace/pull/2135
- Has been tested by Pablo. Needs final reviews/merger
- Pablo's PR needs final approval: https://github.com/DSpace/DSpace/pull/2108
- Discussion
- Mark asks about throwing Exceptions in RestRepository classes. Should we be wrapping in RuntimeException?
- This topic came up on Slack and in this PR: https://github.com/DSpace/DSpace/pull/2126#pullrequestreview-143324207
- Andrea Bollini (4Science) seems to have built most of the *RestRepository classes and is wrapping exceptions in RuntimeException in nearly all of them. Tim hasn't had a chance to ask why that is, and whether this is necessary for some reason, or if we should create a ticket to change it.
- For now, recommend that Mark and others follow this same pattern – continue to wrap exceptions in RuntimeException, until we are able to discuss/determine a better pattern.
- Mark asks about throwing Exceptions in RestRepository classes. Should we be wrapping in RuntimeException?
- Development Planning Spreadsheet
- Skipped this for today, as most of the REST API team was unavailable.
- Next week, continue from Submission section
- The Next Meeting will be on Thursday, Aug 16 at 14:00UTC (10:00am EDT) in DSpace Meeting Room
- Terrence W Bradywill be out the next 2 weeks (back week of Aug 20)
- Giuseppe Digilio (4Science)will be out until early September
Overview
Content Tools