Page History

When we review your code, we are mostly ensuring it generally follows our Code Contribution Standards. However, there are a few other things we generally check for:

• The code is well commented (e.g. has JavaDocs or TypeDocs)
• The code follows our Code Style Guide (only required for DSpace 7.x and above)
• The code provides Unit and/or Integration Tests (see Code Testing Guide) (required for DSpace 7.x and above)
• The code is stable and has no stability or security concerns
• The code is properly using existing APIs, etc.
• The code is not too specific to one institution's local policies or workflows. (I.e. we will review the code to ensure it looks to be generally useful to most institutions, or configurable enough such that others can change it to match their own local policies/workflows)
• Any third-party tools/libraries used by your code have compatible open source licenses. See Licensing of Contributions

As our developers/Committers are all volunteers, they don't always have the time to rework code changes for you. If you want your code change accepted in a timely manner, please offer to make the changes yourself (otherwise your patch suggestion may wait in a "holding queue" until someone has enough time to work on any necessary fixes).

If you are unsure of next steps, please let us know by adding a comment to your issue/PR in the Issue TrackerGitHub. Communication is absolutely necessary to ensure that we can help you rework anything that needs reworking. If we don't hear from you, we'll assume you are hard at work. So, if you've run into issues, please let us know! If, locally, you don't have the time or expertise to do the rework that is necessary, also let us know. We can try to locate a community developer to help out, and/or ask both the Committers Team and the DSpace Community Advisory Team if they know of any interested developers with time to spare.